smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: mv src/lib/gui/VersionChecker => src/gui/src/

Browse source
This commit is contained in:
sithlord48 2024-11-27 17:11:28 -05:00 committed by Chris Rizzitello
parent 7f9fd80f98
commit 03f1408a98
4 changed files with 3 additions and 76 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/gui/src/MainWindow.h
View file

@ -27,8 +27,8 @@
#include "ServerConfig.h"
#include "TrayIcon.h"
#include "VersionChecker.h"
#include "common/ipc.h"
#include "gui/VersionChecker.h"
#include "gui/config/AppConfig.h"
#include "gui/config/ConfigScopes.h"
#include "gui/config/ServerConfigDialogState.h"

2
src/lib/gui/VersionChecker.cpp → src/gui/src/VersionChecker.cpp
View file

@ -18,7 +18,7 @@
#include "VersionChecker.h"
#include "common/constants.h"
#include "env_vars.h"
#include "gui/env_vars.h"
#include <QLocale>
#include <QNetworkAccessManager>

2
src/lib/gui/VersionChecker.h → src/gui/src/VersionChecker.h
View file

@ -17,7 +17,7 @@
#pragma once
#include "proxy/QNetworkAccessManagerProxy.h"
#include "gui/proxy/QNetworkAccessManagerProxy.h"
#include <QObject>
#include <QString>

73
src/test/unittests/gui/VersionCheckerTests.cpp
View file

@ -1,73 +0,0 @@
/*
* Deskflow -- mouse and keyboard sharing utility
* Copyright (C) 2024 Symless Ltd.
*
* This package is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* found in the file LICENSE that should have accompanied this file.
*
* This package is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "gui/VersionChecker.h"
#include "shared/gui/TestQtCoreApp.h"
#include <gmock/gmock.h>
#include <gtest/gtest.h>
using namespace deskflow::gui::proxy;
using namespace testing;
class VersionCheckerTests : public ::testing::Test
{
protected:
int compareVersions(const QString &left, const QString &right)
{
return VersionChecker::compareVersions(left, right);
}
};
class MockNetworkAccessManager : public QNetworkAccessManagerProxy
{
public:
MOCK_METHOD(void, init, (), (override));
MOCK_METHOD(void, get, (const QNetworkRequest &request), (const, override));
};
TEST_F(VersionCheckerTests, checkLatest_callsNetworkGet)
{
TestQtCoreApp app;
const auto network = std::make_shared<NiceMock<MockNetworkAccessManager>>();
const VersionChecker checker(network);
EXPECT_CALL(*network, get(testing::_)).Times(1);
checker.checkLatest();
}
TEST_F(VersionCheckerTests, compareVersions_major_isValid)
{
EXPECT_EQ(compareVersions("1.0.0", "2.0.0"), 1);
EXPECT_EQ(compareVersions("2.0.0", "1.0.0"), -1);
EXPECT_EQ(compareVersions("1.0.0", "1.0.0"), 0);
}
TEST_F(VersionCheckerTests, compareVersions_minor_isValid)
{
EXPECT_EQ(compareVersions("1.1.0", "1.2.0"), 1);
EXPECT_EQ(compareVersions("1.2.0", "1.1.0"), -1);
EXPECT_EQ(compareVersions("1.1.0", "1.1.0"), 0);
}
TEST_F(VersionCheckerTests, compareVersions_patch_isValid)
{
EXPECT_EQ(compareVersions("1.0.1", "1.0.2"), 1);
EXPECT_EQ(compareVersions("1.0.2", "1.0.1"), -1);
EXPECT_EQ(compareVersions("1.0.1", "1.0.1"), 0);
}