refactor: remove unused --host arg from deskflow-client

src/lib/client/Client.cpp

@@ -134,24 +134,20 @@ void Client::connect(size_t addressIndex)
   auto securityLevel = m_useSecureNetwork ? SecurityLevel::PeerAuth : SecurityLevel::PlainText;
 
   try {
-    if (m_args.m_hostMode) {
+    // resolve the server hostname.  do this every time we connect
-      LOG((CLOG_NOTE "waiting for server connection on %i port", m_serverAddress.getPort()));
+    // in case we couldn't resolve the address earlier or the address
-    } else {
+    // has changed (which can happen frequently if this is a laptop
-      // resolve the server hostname.  do this every time we connect
+    // being shuttled between various networks).  patch by Brent
-      // in case we couldn't resolve the address earlier or the address
+    // Priddy.
-      // has changed (which can happen frequently if this is a laptop
+    m_resolvedAddressesCount = m_serverAddress.resolve(addressIndex);
-      // being shuttled between various networks).  patch by Brent
-      // Priddy.
-      m_resolvedAddressesCount = m_serverAddress.resolve(addressIndex);
 
-      // m_serverAddress will be null if the hostname address is not reolved
+    // m_serverAddress will be null if the hostname address is not reolved
-      if (m_serverAddress.getAddress() != nullptr) {
+    if (m_serverAddress.getAddress() != nullptr) {
-        // to help users troubleshoot, show server host name (issue: 60)
+      // to help users troubleshoot, show server host name (issue: 60)
-        LOG(
+      LOG(
-            (CLOG_NOTE "connecting to '%s': %s:%i", m_serverAddress.getHostname().c_str(),
+          (CLOG_NOTE "connecting to '%s': %s:%i", m_serverAddress.getHostname().c_str(),
-             ARCH->addrToString(m_serverAddress.getAddress()).c_str(), m_serverAddress.getPort())
+           ARCH->addrToString(m_serverAddress.getAddress()).c_str(), m_serverAddress.getPort())
-        );
+      );
-      }
     }
 
     // create the socket
@@ -509,11 +505,8 @@ void Client::setupScreen()
 void Client::setupTimer()
 {
   assert(m_timer == NULL);
-
+  m_timer = m_events->newOneShotTimer(2.0, NULL);
-  if (!m_args.m_hostMode) {
+  m_events->adoptHandler(Event::kTimer, m_timer, new TMethodEventJob<Client>(this, &Client::handleConnectTimeout));
-    m_timer = m_events->newOneShotTimer(2.0, NULL);
-    m_events->adoptHandler(Event::kTimer, m_timer, new TMethodEventJob<Client>(this, &Client::handleConnectTimeout));
-  }
 }
 
 void Client::cleanup()

src/lib/deskflow/ArgParser.cpp

@@ -88,8 +88,6 @@ bool ArgParser::parseClientArgs(deskflow::ClientArgs &args, int argc, const char
       args.m_enableLangSync = true;
     } else if (isArg(i, argc, argv, nullptr, "--invert-scroll")) {
       args.m_clientScrollDirection = deskflow::ClientScrollDirection::INVERT_SERVER;
-    } else if (isArg(i, argc, argv, nullptr, "--host")) {
-      args.m_hostMode = true;
     } else if (isArg(i, argc, argv, nullptr, "client")) {
       ++i;
       continue;

src/lib/deskflow/ClientApp.cpp

@@ -113,7 +113,6 @@ void ClientApp::help()
        << " [--yscroll <delta>]"
        << " [--sync-language]"
        << " [--invert-scroll]"
-       << " [--host]"
 #ifdef WINAPI_XWINDOWS
        << " [--display <display>]"
        << " [--no-xinitthreads]"
@@ -131,8 +130,6 @@ void ClientApp::help()
        << "      --sync-language      enable language synchronization.\n"
        << "      --invert-scroll      invert scroll direction on this\n"
        << "                             computer.\n"
-       << "      --host               act as a host; invert server/client mode\n"
-       << "                             and listen instead of connecting.\n"
 #if WINAPI_XWINDOWS
        << "      --display <display>  when in X mode, connect to the X server\n"
        << "                             at <display>.\n"

src/lib/deskflow/ClientArgs.h

@@ -34,12 +34,6 @@ public:
    */
   ClientScrollDirection m_clientScrollDirection = ClientScrollDirection::SERVER;
 
-  /**
-   * @brief m_hostMode - activates host mode.
-   * Client starts a listener and waits for a server connection.
-   */
-  bool m_hostMode = false;
-
   /**
    * @brief m_serverAddress stores deskflow server address
    */