refactor: SecureUtils use QStringLiterals where possible

This commit is contained in:
sithlord48 2025-11-24 21:17:40 -05:00 committed by Chris Rizzitello
parent 2dfba73cfb
commit 1a6f81a34b

View file

@ -160,9 +160,9 @@ QString formatSSLFingerprintColumns(const QByteArray &fingerprint)
const auto take = std::min<size_t>(kMaxColumns, hex.size()); const auto take = std::min<size_t>(kMaxColumns, hex.size());
formattedString.append(hex.first(take)); formattedString.append(hex.first(take));
hex.remove(0, take); hex.remove(0, take);
if (formattedString.endsWith(':')) if (formattedString.endsWith(QLatin1Char(':')))
formattedString.removeLast(); formattedString.removeLast();
formattedString.append('\n'); formattedString.append(QLatin1Char('\n'));
} }
formattedString.removeLast(); formattedString.removeLast();
return formattedString; return formattedString;
@ -200,7 +200,7 @@ QString generateFingerprintArt(const QByteArray &rawDigest)
const auto baseSize = 8; const auto baseSize = 8;
const auto rows = (baseSize + 1); const auto rows = (baseSize + 1);
const auto columns = (baseSize * 2 + 1); const auto columns = (baseSize * 2 + 1);
const QString characterPool = " .o+=*BOX@%&#/^SE"; const QString characterPool = QStringLiteral(" .o+=*BOX@%&#/^SE");
const std::size_t len = characterPool.length() - 1; const std::size_t len = characterPool.length() - 1;
std::uint8_t field[columns][rows]; std::uint8_t field[columns][rows];
@ -233,17 +233,17 @@ QString generateFingerprintArt(const QByteArray &rawDigest)
QString result; QString result;
result.reserve((columns + 3) * (rows + 2)); result.reserve((columns + 3) * (rows + 2));
result.append("╔═════════════════╗\n"); result.append(QStringLiteral("╔═════════════════╗\n"));
/* output content */ /* output content */
for (y = 0; y < rows; y++) { for (y = 0; y < rows; y++) {
result.append("║"); result.append(QStringLiteral("║"));
for (x = 0; x < columns; x++) for (x = 0; x < columns; x++)
result.append(characterPool.at(std::min<int>(field[x][y], len))); result.append(characterPool.at(std::min<int>(field[x][y], len)));
result.append("║\n"); result.append(QStringLiteral("║\n"));
} }
result.append("╚═════════════════╝"); result.append(QStringLiteral("╚═════════════════╝"));
return result; return result;
} }