resolved code smell reported

This commit is contained in:
Ignacio Rodriguez 2021-01-21 22:32:12 +07:00
parent 6c72c0ce1c
commit 1dbf35dfba

View file

@ -14,7 +14,7 @@ public:
TrayIcon() TrayIcon()
{ {
set = [this](const QIcon &icon){ m_set = [this](const QIcon &icon){
m_init = [this,icon](){ m_init = [this,icon](){
this->set(icon); this->set(icon);
}; };
@ -39,7 +39,7 @@ public:
m_pTrayIcon = std::make_unique<QSystemTrayIcon>(); m_pTrayIcon = std::make_unique<QSystemTrayIcon>();
m_pTrayIcon->setContextMenu(m_pTrayIconMenu.get()); m_pTrayIcon->setContextMenu(m_pTrayIconMenu.get());
m_pTrayIcon->setToolTip("Synergy"); m_pTrayIcon->setToolTip("Synergy");
set = [this](const QIcon& icon) { m_pTrayIcon->setIcon(icon); }; m_set = [this](const QIcon& icon) { m_pTrayIcon->setIcon(icon); };
tryCreate(); tryCreate();
if (m_init) { if (m_init) {
@ -49,12 +49,12 @@ public:
} }
void tryCreate() const; void tryCreate() const;
void set(const QIcon& icon) const { m_set(icon); }
std::function<void(const QIcon& icon)> set;
private: private:
std::unique_ptr<QSystemTrayIcon> m_pTrayIcon {}; std::unique_ptr<QSystemTrayIcon> m_pTrayIcon {};
std::unique_ptr<QMenu> m_pTrayIconMenu {}; std::unique_ptr<QMenu> m_pTrayIconMenu {};
TConnector m_connector; TConnector m_connector;
std::function<void()> m_init; std::function<void()> m_init;
std::function<void(const QIcon& icon)> m_set;
}; };