smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tls): prevent DoS by removing blocking sleep

Browse source
This commit is contained in:
Nick Bolton 2026-04-28 11:31:23 +01:00
parent 70c8c8f668
commit 329783490b
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/lib/net/SecureSocket.cpp
View file

@ -423,13 +423,12 @@ int SecureSocket::secureAccept(int socket)
checkResult(r, retry); checkResult(r, retry);
if (isFatal()) { if (isFatal()) {
// tell user and sleep so the socket isn't hammered. // Never block here; this thread services every connected socket.
// Historically a 1s sleep let any failed handshake DoS all clients.
LOG_ERR("failed to accept secure socket"); LOG_ERR("failed to accept secure socket");
LOG_WARN("client connection may not be secure");
m_secureReady = false; m_secureReady = false;
Arch::sleep(1);
retry = 0; retry = 0;
return -1; // Failed, error out return -1; // Fail
} }
// If not fatal and no retry, state is good // If not fatal and no retry, state is good
@ -455,7 +454,7 @@ int SecureSocket::secureAccept(int socket)
// no good state exists here // no good state exists here
LOG_ERR("unexpected state attempting to accept connection"); LOG_ERR("unexpected state attempting to accept connection");
return -1; return -1; // Fail
} }
int SecureSocket::secureConnect(int socket) int SecureSocket::secureConnect(int socket)