From 378fdae140c6d9b81f702de9c979d390e2497baa Mon Sep 17 00:00:00 2001 From: Nick Bolton Date: Thu, 16 Jan 2025 17:47:55 +0000 Subject: [PATCH] feat: Handle empty response from update server --- src/apps/deskflow-gui/VersionChecker.cpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/apps/deskflow-gui/VersionChecker.cpp b/src/apps/deskflow-gui/VersionChecker.cpp index e88ef0740..763413e34 100644 --- a/src/apps/deskflow-gui/VersionChecker.cpp +++ b/src/apps/deskflow-gui/VersionChecker.cpp @@ -48,11 +48,17 @@ void VersionChecker::replyFinished(QNetworkReply *reply) reply->deleteLater(); qDebug("version check response: %s", qPrintable(newestVersion)); - if (!newestVersion.isEmpty() && compareVersions(kVersion, newestVersion) > 0) { - qDebug("update found"); + if (newestVersion.isEmpty()) { + qWarning() << "version check is response is empty"; + return; + } + + if (compareVersions(kVersion, newestVersion) > 0) { + qWarning().noquote() // + << QStringLiteral("current version %1 out of date, update available: %2").arg(kVersion, newestVersion); Q_EMIT updateFound(newestVersion); } else { - qDebug("no updates found"); + qDebug().noquote() << QStringLiteral("current version %1 is upto date").arg(kVersion); } }