chore: use final for overrides and remove virtual for non base classes

This commit is contained in:
sithlord48 2025-05-23 13:48:39 -04:00 committed by Nick Bolton
parent d2ac36f3ed
commit 3eb3969a01
8 changed files with 14 additions and 14 deletions

View file

@ -63,10 +63,10 @@ public:
void closeMutex(ArchMutex) override; void closeMutex(ArchMutex) override;
void lockMutex(ArchMutex) override; void lockMutex(ArchMutex) override;
void unlockMutex(ArchMutex) override; void unlockMutex(ArchMutex) override;
ArchThread newThread(ThreadFunc, void *) override; ArchThread newThread(ThreadFunc, void *) final;
ArchThread newCurrentThread() override; ArchThread newCurrentThread() override;
ArchThread copyThread(ArchThread) override; ArchThread copyThread(ArchThread) override;
void closeThread(ArchThread) override; void closeThread(ArchThread) final;
void cancelThread(ArchThread) override; void cancelThread(ArchThread) override;
void setPriorityOfThread(ArchThread, int n) override; void setPriorityOfThread(ArchThread, int n) override;
void testCancelThread() override; void testCancelThread() override;

View file

@ -130,7 +130,7 @@ public:
//@} //@}
// IScreen overrides // IScreen overrides
void *getEventTarget() const override; void *getEventTarget() const final;
bool getClipboard(ClipboardID id, IClipboard *) const override; bool getClipboard(ClipboardID id, IClipboard *) const override;
void getShape(int32_t &x, int32_t &y, int32_t &width, int32_t &height) const override; void getShape(int32_t &x, int32_t &y, int32_t &width, int32_t &height) const override;
void getCursorPos(int32_t &x, int32_t &y) const override; void getCursorPos(int32_t &x, int32_t &y) const override;

View file

@ -43,9 +43,9 @@ public:
//@} //@}
// IClipboard overrides // IClipboard overrides
bool empty() override; bool empty() final;
void add(EFormat, const std::string &data) override; void add(EFormat, const std::string &data) override;
bool open(Time) const override; bool open(Time) const final;
void close() const override; void close() const override;
Time getTime() const override; Time getTime() const override;
bool has(EFormat) const override; bool has(EFormat) const override;

View file

@ -46,14 +46,14 @@ public:
For a secondary screen it also means disabling the screen saver if For a secondary screen it also means disabling the screen saver if
synchronizing it and preparing to synthesize events. synchronizing it and preparing to synthesize events.
*/ */
virtual void enable(); void enable();
//! Deactivate screen //! Deactivate screen
/*! /*!
Undoes the operations in activate() and events are no longer Undoes the operations in activate() and events are no longer
reported. It also releases keys that are logically pressed. reported. It also releases keys that are logically pressed.
*/ */
virtual void disable(); void disable();
//! Enter screen //! Enter screen
/*! /*!
@ -168,14 +168,14 @@ public:
/*! /*!
Resets all options to their default values. Resets all options to their default values.
*/ */
virtual void resetOptions(); void resetOptions();
//! Notify of options changes //! Notify of options changes
/*! /*!
Set options to given values. Ignores unknown options and doesn't Set options to given values. Ignores unknown options and doesn't
modify options that aren't given in \c options. modify options that aren't given in \c options.
*/ */
virtual void setOptions(const OptionsList &options); void setOptions(const OptionsList &options);
//! Set clipboard sequence number //! Set clipboard sequence number
/*! /*!

View file

@ -35,7 +35,7 @@ public:
~EiScreen() override; ~EiScreen() override;
// IScreen overrides // IScreen overrides
void *getEventTarget() const override; void *getEventTarget() const final;
bool getClipboard(ClipboardID id, IClipboard *) const override; bool getClipboard(ClipboardID id, IClipboard *) const override;
void getShape(std::int32_t &x, std::int32_t &y, std::int32_t &width, std::int32_t &height) const override; void getShape(std::int32_t &x, std::int32_t &y, std::int32_t &width, std::int32_t &height) const override;
void getCursorPos(std::int32_t &x, std::int32_t &y) const override; void getCursorPos(std::int32_t &x, std::int32_t &y) const override;

View file

@ -96,7 +96,7 @@ public:
// IKeyState overrides // IKeyState overrides
bool fakeCtrlAltDel() override; bool fakeCtrlAltDel() override;
KeyModifierMask pollActiveModifiers() const override; KeyModifierMask pollActiveModifiers() const override;
int32_t pollActiveGroup() const override; int32_t pollActiveGroup() const final;
void pollPressedKeys(KeyButtonSet &pressedKeys) const override; void pollPressedKeys(KeyButtonSet &pressedKeys) const override;
protected: protected:

View file

@ -42,7 +42,7 @@ public:
//@} //@}
// IScreen overrides // IScreen overrides
void *getEventTarget() const override; void *getEventTarget() const final;
bool getClipboard(ClipboardID id, IClipboard *) const override; bool getClipboard(ClipboardID id, IClipboard *) const override;
void getShape(int32_t &x, int32_t &y, int32_t &width, int32_t &height) const override; void getShape(int32_t &x, int32_t &y, int32_t &width, int32_t &height) const override;
void getCursorPos(int32_t &x, int32_t &y) const override; void getCursorPos(int32_t &x, int32_t &y) const override;

View file

@ -357,7 +357,7 @@ public:
explicit InputFilter(IEventQueue *events); explicit InputFilter(IEventQueue *events);
InputFilter(const InputFilter &); InputFilter(const InputFilter &);
virtual ~InputFilter(); ~InputFilter();
InputFilter &operator=(const InputFilter &); InputFilter &operator=(const InputFilter &);
@ -372,7 +372,7 @@ public:
// enable event filtering using the given primary client. disable // enable event filtering using the given primary client. disable
// if client is nullptr. // if client is nullptr.
virtual void setPrimaryClient(PrimaryClient *client); void setPrimaryClient(PrimaryClient *client);
// convert rules to a string // convert rules to a string
std::string format(const std::string_view &linePrefix) const; std::string format(const std::string_view &linePrefix) const;