ci: Fix naming conventions for step names and bash vars

This commit is contained in:
Nick Bolton 2025-08-06 20:21:47 +01:00
parent cf1789545a
commit 436f5b7f0a
3 changed files with 13 additions and 12 deletions

View file

@ -16,7 +16,7 @@ runs:
steps: steps:
- name: Unit Tests - name: Unit Tests
id: unittests id: unit-tests
env: env:
QT_QPA_PLATFORM: offscreen QT_QPA_PLATFORM: offscreen
run: | run: |
@ -30,7 +30,7 @@ runs:
continue-on-error: true continue-on-error: true
- name: Legacy Tests - name: Legacy Tests
id: legacytests id: legacy-tests
env: env:
QT_QPA_PLATFORM: offscreen QT_QPA_PLATFORM: offscreen
run: | run: |
@ -48,12 +48,12 @@ runs:
run: | run: |
pass="✅ Pass" pass="✅ Pass"
fail="❌ Fail" fail="❌ Fail"
unittests_outcome="${{ steps.unittests.outcome }}" unit_tests_outcome="${{ steps.unit-tests.outcome }}"
legacytests_outcome="${{ steps.legacytests.outcome }}" legacy_tests_outcome="${{ steps.legacy-tests.outcome }}"
unittests=$( [ "$unittests_outcome" = "success" ] && echo $pass || echo $fail ) unit_tests=$( [ "$unit_tests_outcome" = "success" ] && echo $pass || echo $fail )
legacytests=$( [ "$legacytests_outcome" = "success" ] && echo $pass || echo $fail ) legacy_tests=$( [ "$legacy_tests_outcome" = "success" ] && echo $pass || echo $fail )
echo "unittests=$unittests" >> $GITHUB_OUTPUT echo "unit-tests=$unit_tests" >> $GITHUB_OUTPUT
echo "legacytests=$legacytests" >> $GITHUB_OUTPUT echo "legacy-tests=$legacy_tests" >> $GITHUB_OUTPUT
shell: bash shell: bash
- name: Summary row - name: Summary row
@ -63,8 +63,8 @@ runs:
row="" row=""
row+="| ${{ inputs.job }} " row+="| ${{ inputs.job }} "
row+="| ${{ steps.results.outputs.unittests }} " row+="| ${{ steps.results.outputs.unit-tests }} "
row+="| ${{ steps.results.outputs.legacytests }} " row+="| ${{ steps.results.outputs.legacy-tests }} "
echo "$row" > $file echo "$row" > $file
echo "file=$file" > $GITHUB_OUTPUT echo "file=$file" > $GITHUB_OUTPUT
@ -77,7 +77,7 @@ runs:
path: ${{ steps.row.outputs.file }} path: ${{ steps.row.outputs.file }}
- name: Check test outcome - name: Check test outcome
if: (steps.unittests.outcome != 'success' || steps.legacytests.outcome != 'success') if: (steps.unit-tests.outcome != 'success' || steps.legacy-tests.outcome != 'success')
run: | run: |
echo "Tests failed" echo "Tests failed"
exit 1 exit 1

View file

@ -29,7 +29,7 @@ runs:
header=$(cat <<EOF header=$(cat <<EOF
# Test results # Test results
| Job name | Unit tests | Integration tests | | OS | Unit tests | Legacy tests |
| --- | --- | --- | | --- | --- | --- |
EOF EOF
) )

View file

@ -38,6 +38,7 @@
"Kitware", "Kitware",
"Kutytska", "Kutytska",
"Lanz", "Lanz",
"legacytests",
"libei", "libei",
"Libera", "Libera",
"libportal", "libportal",