smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: ScreenSettingsDialog, do not create nested validators in the Lines setValidator method

Browse source
This commit is contained in:
sithlord48 2025-07-03 09:03:14 -04:00 committed by Nick Bolton
parent ede27975d7
commit 4a92a3295b
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/lib/gui/dialogs/ScreenSettingsDialog.cpp
View file

@ -35,14 +35,15 @@ ScreenSettingsDialog::ScreenSettingsDialog(QWidget *parent, Screen *pScreen, con
ui->m_pLabelNameError->setStyleSheet(kStyleErrorActiveLabel);
ui->m_pLineEditName->setText(m_pScreen->name());
ui->m_pLineEditName->setValidator(new validators::ScreenNameValidator(
ui->m_pLineEditName, new validators::ValidationError(this, ui->m_pLabelNameError), pScreens
));
auto valNameError = new validators::ValidationError(this, ui->m_pLabelNameError);
auto valName = new validators::ScreenNameValidator(ui->m_pLineEditName, valNameError, pScreens);
ui->m_pLineEditName->setValidator(valName);
ui->m_pLineEditName->selectAll();
ui->m_pLineEditAlias->setValidator(new validators::AliasValidator(
ui->m_pLineEditAlias, new validators::ValidationError(this, ui->m_pLabelAliasError)
));
auto valAliasError = new validators::ValidationError(this, ui->m_pLabelAliasError);
auto valAlias = new validators::AliasValidator(ui->m_pLineEditAlias, valAliasError);
ui->m_pLineEditAlias->setValidator(valAlias);
for (int i = 0; i < m_pScreen->aliases().count(); i++)
new QListWidgetItem(m_pScreen->aliases()[i], ui->m_pListAliases);