From 53903016b12afa011c99c530436007e35f4111b9 Mon Sep 17 00:00:00 2001 From: SASANO Takayoshi Date: Mon, 18 May 2026 23:31:39 +0900 Subject: [PATCH] fix: remove unneeded EVP_PKEY_new() (causes memory leak) --- src/lib/net/SecureUtils.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/lib/net/SecureUtils.cpp b/src/lib/net/SecureUtils.cpp index bc820a723..d6e0d24b7 100644 --- a/src/lib/net/SecureUtils.cpp +++ b/src/lib/net/SecureUtils.cpp @@ -66,14 +66,12 @@ void generatePemSelfSignedCert(const QString &path, int keyLength) { auto expirationDays = 365; - auto *privateKey = EVP_PKEY_new(); + auto *privateKey = EVP_RSA_gen(keyLength); if (!privateKey) { - throw std::runtime_error("could not allocate private key for certificate"); + throw std::runtime_error("failed to generate a " + std::to_string(keyLength) + "bit key for certificate"); } auto privateKeyFree = finally([privateKey]() { EVP_PKEY_free(privateKey); }); - privateKey = EVP_RSA_gen(keyLength); - auto *cert = X509_new(); if (!cert) { throw std::runtime_error("could not allocate certificate");