smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: Silence two compiler signedness warnings

Browse source 
Both trigger:
  warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]

In the first hunk we already checked for i < 0 so casting to size_t is
fine. In the second hunk we don't use i so we can pick the right type.
This commit is contained in:
Peter Hutterer 2025-04-30 11:07:28 +10:00 committed by Nick Bolton
parent 35f0e9e6e4
commit 59df2db7b7
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/lib/base/String.cpp
View file

@ -56,7 +56,7 @@ std::string vformat(const char *fmt, va_list args)
index.push_back(i); index.push_back(i);
pos.push_back(static_cast<size_t>((scan - 1) - fmt)); pos.push_back(static_cast<size_t>((scan - 1) - fmt));
width.push_back(static_cast<size_t>((end - scan) + 2)); width.push_back(static_cast<size_t>((end - scan) + 2));
if (i > maxIndex) { if (static_cast<size_t>(i) > maxIndex) {
maxIndex = i; maxIndex = i;
} }
scan = end; scan = end;
@ -74,7 +74,7 @@ std::string vformat(const char *fmt, va_list args)
std::vector<size_t> length; std::vector<size_t> length;
value.push_back("%"); value.push_back("%");
length.push_back(1); length.push_back(1);
for (int i = 0; i < maxIndex; ++i) { for (size_t i = 0; i < maxIndex; ++i) {
const char *arg = va_arg(args, const char *); const char *arg = va_arg(args, const char *);
size_t len = strnlen(arg, SIZE_MAX); size_t len = strnlen(arg, SIZE_MAX);
value.push_back(arg); value.push_back(arg);