smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: MainWindow::updateIpLabel, remove single use vars

Browse source
This commit is contained in:
sithlord48 2025-12-31 10:10:48 -05:00 committed by Chris Rizzitello
parent a84e91a3f2
commit 61fcad2c14
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/lib/gui/MainWindow.cpp
View file

@ -1281,8 +1281,6 @@ void MainWindow::updateIpLabel(const QList<QHostAddress> &addresses)
labelText = tr("Suggested IP: "); labelText = tr("Suggested IP: ");
toolTipText = tr("<p>If connecting via the hostname fails, try %1</p>"); toolTipText = tr("<p>If connecting via the hostname fails, try %1</p>");
static auto s_toolTipSuggestIP = tr("the suggested IP.");
static auto s_toolTipIpList = tr("one of the following IPs:<br/>%1");
// Determine which IP to show and tooltip based on server state // Determine which IP to show and tooltip based on server state
if (m_coreProcess.isStarted()) { if (m_coreProcess.isStarted()) {
@ -1316,14 +1314,13 @@ void MainWindow::updateIpLabel(const QList<QHostAddress> &addresses)
} else { } else {
// Server is not running - update normally // Server is not running - update normally
m_currentIpAddress = m_networkMonitor->getSuggestedIPv4Address(); m_currentIpAddress = m_networkMonitor->getSuggestedIPv4Address();
QString displayIP = m_currentIpAddress.isNull() ? m_currentIpAddress.toString() : ipList.first(); labelText.append(m_currentIpAddress.isNull() ? m_currentIpAddress.toString() : ipList.first());
labelText.append(displayIP);
} }
if (ipList.count() < 2) { if (ipList.count() < 2) {
toolTipText = toolTipText.arg(s_toolTipSuggestIP); toolTipText = toolTipText.arg(tr("the suggested IP."));
} else { } else {
toolTipText = toolTipText.arg(s_toolTipIpList.arg(ipList.join("<br/>"))); toolTipText = toolTipText.arg(tr("one of the following IPs:<br/>%1").arg(ipList.join("<br/>")));
} }
ui->lblIpAddresses->setText(labelText); ui->lblIpAddresses->setText(labelText);