smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(SettingsDialog): move the Messages readonly dialog to the settingsDialog method

Browse source
This commit is contained in:
sithlord48 2026-08-05 23:16:24 -04:00 committed by Chris Rizzitello
parent f765e829f2
commit 6692fa5636
9 changed files with 53 additions and 63 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/lib/gui/Messages.cpp
View file

@ -205,17 +205,6 @@ bool showNewClientPrompt(QWidget *parent, const QString &clientName)
return message.buttonRole(message.clickedButton()) == QMessageBox::AcceptRole;
}
void showReadOnlySettings(QWidget *parent, const QString &systemSettingsPath)
{
const auto title = QObject::tr("%1 Read-only settings").arg(kAppName);
const auto message = QObject::tr(
"<p>Settings are read-only because you only have read access "
"to the file:</p><p>%1</p>"
)
.arg(QDir::toNativeSeparators(systemSettingsPath));
QMessageBox::information(parent, title, message);
}
bool showUpdateCheckOption(QWidget *parent)
{
QMessageBox message(parent);

2
src/lib/gui/Messages.h
View file

@ -27,8 +27,6 @@ void showCloseReminder(QWidget *parent);
bool showNewClientPrompt(QWidget *parent, const QString &clientName);
void showReadOnlySettings(QWidget *parent, const QString &systemSettingsPath);
bool showUpdateCheckOption(QWidget *parent);
bool showDaemonOffline(QWidget *parent);

7
src/lib/gui/dialogs/SettingsDialog.cpp
View file

@ -13,7 +13,6 @@
#include "common/I18N.h"
#include "common/Settings.h"
#include "gui/Messages.h"
#include "gui/TlsUtility.h"
#include "gui/core/NetworkMonitor.h"
@ -199,7 +198,11 @@ void SettingsDialog::showReadOnlyMessage()
{
if (Settings::isWritable())
return;
messages::showReadOnlySettings(this, Settings::settingsFile());
QMessageBox::information(
this, tr("%1 Read-only settings").arg(kAppName),
tr("<p>Settings are read-only because you only have read access to the file:</p><p>%1</p>")
.arg(QDir::toNativeSeparators(Settings::settingsFile()))
);
}
void SettingsDialog::resetAllSettings()

16
translations/deskflow_es.ts
View file

@ -700,14 +700,6 @@ Además, verifique que puede %1 el archivo de configuración del servidor: %2</t
<source>A new client called &apos;%1&apos; wants to connect</source>
<translation type="unfinished">Un nuevo cliente llamado &apos;%1&apos; quiere conectarse</translation>
</message>
<message>
<source>%1 Read-only settings</source>
<translation type="unfinished">%1 Configuración de solo lectura</translation>
</message>
<message>
<source>&lt;p&gt;Settings are read-only because you only have read access to the file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</source>
<translation type="unfinished">&lt;p&gt;Las configuraciones son de solo lectura porque solo tiene acceso de lectura al archivo:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</translation>
</message>
<message>
<source>No thanks</source>
<translation type="unfinished">No, gracias</translation>
@ -1167,6 +1159,14 @@ Al habilitar esta opción, se deshabilitará la interfaz gráfica de usuario (GU
<source>&lt;p&gt;Are you sure you want to clear all settings and restart %1?&lt;/p&gt; &lt;p&gt;This action cannot be undone.&lt;/p&gt;</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>%1 Read-only settings</source>
<translation type="unfinished">%1 Configuración de solo lectura</translation>
</message>
<message>
<source>&lt;p&gt;Settings are read-only because you only have read access to the file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</source>
<translation type="unfinished">&lt;p&gt;Las configuraciones son de solo lectura porque solo tiene acceso de lectura al archivo:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</translation>
</message>
<message>
<source>Required messages</source>
<translation type="unfinished">Mensajes obligatorios</translation>

16
translations/deskflow_it.ts
View file

@ -700,14 +700,6 @@ Inoltre, verifica di poter %1 il file di configurazione del server: %2</translat
<source>A new client called &apos;%1&apos; wants to connect</source>
<translation>Un nuovo client chiamato &quot;%1&quot; vuole connettersi</translation>
</message>
<message>
<source>%1 Read-only settings</source>
<translation>%1 Impostazioni di sola lettura</translation>
</message>
<message>
<source>&lt;p&gt;Settings are read-only because you only have read access to the file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</source>
<translation>&lt;p&gt;Le impostazioni sono di sola lettura perché hai solo accesso in lettura al file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</translation>
</message>
<message>
<source>No thanks</source>
<translation>No, grazie</translation>
@ -1167,6 +1159,14 @@ L&apos;abilitazione di questa impostazione disabiliterà l&apos;interfaccia graf
<source>&lt;p&gt;Are you sure you want to clear all settings and restart %1?&lt;/p&gt; &lt;p&gt;This action cannot be undone.&lt;/p&gt;</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>%1 Read-only settings</source>
<translation type="unfinished">%1 Impostazioni di sola lettura</translation>
</message>
<message>
<source>&lt;p&gt;Settings are read-only because you only have read access to the file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</source>
<translation type="unfinished">&lt;p&gt;Le impostazioni sono di sola lettura perché hai solo accesso in lettura al file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</translation>
</message>
<message>
<source>Required messages</source>
<translation>Messaggi richiesti</translation>

16
translations/deskflow_ja.ts
View file

@ -702,14 +702,6 @@ Additionally, check you are able to %1 the server config file: %2</source>
<source>A new client called &apos;%1&apos; wants to connect</source>
<translation>新しいクライアント &apos;%1&apos; が接続を求めています</translation>
</message>
<message>
<source>%1 Read-only settings</source>
<translation>%1 読み取り専用設定</translation>
</message>
<message>
<source>&lt;p&gt;Settings are read-only because you only have read access to the file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</source>
<translation>&lt;p&gt;以下のファイルへの書き込み権限がないため、設定は読み取り専用です:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</translation>
</message>
<message>
<source>No thanks</source>
<translation>不要です</translation>
@ -1193,6 +1185,14 @@ Enabling this setting will disable the server config GUI.</source>
<source>&lt;p&gt;Are you sure you want to clear all settings and restart %1?&lt;/p&gt; &lt;p&gt;This action cannot be undone.&lt;/p&gt;</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>%1 Read-only settings</source>
<translation type="unfinished">%1 読み取り専用設定</translation>
</message>
<message>
<source>&lt;p&gt;Settings are read-only because you only have read access to the file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</source>
<translation type="unfinished">&lt;p&gt;以下のファイルへの書き込み権限がないため、設定は読み取り専用です:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</translation>
</message>
<message>
<source>Required messages</source>
<translation>必須のメッセージ</translation>

16
translations/deskflow_ko.ts
View file

@ -700,14 +700,6 @@ Additionally, check you are able to %1 the server config file: %2</source>
<source>A new client called &apos;%1&apos; wants to connect</source>
<translation>새 클라이언트 &apos;%1&apos;이(가) 연결을 요청합니다</translation>
</message>
<message>
<source>%1 Read-only settings</source>
<translation>%1 읽기 전용 설정</translation>
</message>
<message>
<source>&lt;p&gt;Settings are read-only because you only have read access to the file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</source>
<translation>&lt;p&gt;다음 파일에 대한 쓰기 권한이 없어 설정이 읽기 전용입니다:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</translation>
</message>
<message>
<source>No thanks</source>
<translation>아니요</translation>
@ -1191,6 +1183,14 @@ Enabling this setting will disable the server config GUI.</source>
<source>&lt;p&gt;Are you sure you want to clear all settings and restart %1?&lt;/p&gt; &lt;p&gt;This action cannot be undone.&lt;/p&gt;</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>%1 Read-only settings</source>
<translation type="unfinished">%1 읽기 전용 설정</translation>
</message>
<message>
<source>&lt;p&gt;Settings are read-only because you only have read access to the file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</source>
<translation type="unfinished">&lt;p&gt;다음 파일에 대한 쓰기 권한이 없어 설정이 읽기 전용입니다:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</translation>
</message>
<message>
<source>Required messages</source>
<translation>필수 메시지</translation>

16
translations/deskflow_ru.ts
View file

@ -700,14 +700,6 @@ Additionally, check you are able to %1 the server config file: %2</source>
<source>A new client called &apos;%1&apos; wants to connect</source>
<translation>Новый клиент &apos;%1&apos; хочет подключиться</translation>
</message>
<message>
<source>%1 Read-only settings</source>
<translation>%1 Настройки только для чтения</translation>
</message>
<message>
<source>&lt;p&gt;Settings are read-only because you only have read access to the file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</source>
<translation>&lt;p&gt;Настройки доступны только для чтения, так как у вас есть доступ только на чтение к файлу:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</translation>
</message>
<message>
<source>No thanks</source>
<translation>Нет, спасибо</translation>
@ -1189,6 +1181,14 @@ Enabling this setting will disable the server config GUI.</source>
<source>&lt;p&gt;Are you sure you want to clear all settings and restart %1?&lt;/p&gt; &lt;p&gt;This action cannot be undone.&lt;/p&gt;</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>%1 Read-only settings</source>
<translation type="unfinished">%1 Настройки только для чтения</translation>
</message>
<message>
<source>&lt;p&gt;Settings are read-only because you only have read access to the file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</source>
<translation type="unfinished">&lt;p&gt;Настройки доступны только для чтения, так как у вас есть доступ только на чтение к файлу:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</translation>
</message>
<message>
<source>Required messages</source>
<translation>Обязательные сообщения</translation>

16
translations/deskflow_zh_CN.ts
View file

@ -702,14 +702,6 @@ Additionally, check you are able to %1 the server config file: %2</source>
<source>A new client called &apos;%1&apos; wants to connect</source>
<translation>名为“%1”的新客户端请求连接</translation>
</message>
<message>
<source>%1 Read-only settings</source>
<translation>%1 只读设置</translation>
</message>
<message>
<source>&lt;p&gt;Settings are read-only because you only have read access to the file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</source>
<translation>&lt;p&gt;设置是只读的，因为您对该文件只有读取权限：&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</translation>
</message>
<message>
<source>No thanks</source>
<translation>不，谢谢</translation>
@ -1193,6 +1185,14 @@ Enabling this setting will disable the server config GUI.</source>
<source>&lt;p&gt;Are you sure you want to clear all settings and restart %1?&lt;/p&gt; &lt;p&gt;This action cannot be undone.&lt;/p&gt;</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>%1 Read-only settings</source>
<translation type="unfinished">%1 只读设置</translation>
</message>
<message>
<source>&lt;p&gt;Settings are read-only because you only have read access to the file:&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</source>
<translation type="unfinished">&lt;p&gt;设置是只读的，因为您对该文件只有读取权限：&lt;/p&gt;&lt;p&gt;%1&lt;/p&gt;</translation>
</message>
<message>
<source>Required messages</source>
<translation>必要消息</translation>