From 6b2c3c18441f6d3f78fbdbe58343661f94cb57c2 Mon Sep 17 00:00:00 2001
From: sithlord48 <sithlord48@gmail.com>
Date: Sat, 25 Oct 2025 19:22:34 -0400
Subject: [PATCH] chore: remove unused ILogOutputters:show

---
 src/lib/base/ILogOutputter.h                 |  9 ---------
 src/lib/base/LogOutputters.cpp               | 20 --------------------
 src/lib/base/LogOutputters.h                 |  4 ----
 src/lib/platform/MSWindowsDebugOutputter.cpp |  5 -----
 src/lib/platform/MSWindowsDebugOutputter.h   |  1 -
 5 files changed, 39 deletions(-)

diff --git a/src/lib/base/ILogOutputter.h b/src/lib/base/ILogOutputter.h
index e46769a2d..048b194d6 100644
--- a/src/lib/base/ILogOutputter.h
+++ b/src/lib/base/ILogOutputter.h
@@ -39,15 +39,6 @@ public:
   */
   virtual void close() = 0;
 
-  //! Show the outputter
-  /*!
-  Causes the output to become visible.  This generally only makes sense
-  for a logger in a graphical user interface.  Other implementations
-  will do nothing.  Iff \p showIfEmpty is \c false then the implementation
-  may optionally only show the log if it's not empty.
-  */
-  virtual void show(bool showIfEmpty) = 0;
-
   //! Write a message with level
   /*!
   Writes \c message, which has the given \c level, to a log.
diff --git a/src/lib/base/LogOutputters.cpp b/src/lib/base/LogOutputters.cpp
index 6460c8032..82dd351ef 100644
--- a/src/lib/base/LogOutputters.cpp
+++ b/src/lib/base/LogOutputters.cpp
@@ -31,11 +31,6 @@ void StopLogOutputter::close()
   // do nothing
 }
 
-void StopLogOutputter::show(bool)
-{
-  // do nothing
-}
-
 bool StopLogOutputter::write(LogLevel, const QString &)
 {
   return false;
@@ -55,11 +50,6 @@ void ConsoleLogOutputter::close()
   // do nothing
 }
 
-void ConsoleLogOutputter::show(bool showIfEmpty)
-{
-  // do nothing
-}
-
 bool ConsoleLogOutputter::write(LogLevel level, const QString &msg)
 {
   if ((level >= LogLevel::Fatal) && (level <= LogLevel::Warning))
@@ -89,11 +79,6 @@ void SystemLogOutputter::close()
   ARCH->closeLog();
 }
 
-void SystemLogOutputter::show(bool showIfEmpty)
-{
-  // do nothing
-}
-
 bool SystemLogOutputter::write(LogLevel level, const QString &msg)
 {
   ARCH->writeLog(level, msg);
@@ -168,8 +153,3 @@ void FileLogOutputter::close()
 {
   // do nothing
 }
-
-void FileLogOutputter::show(bool showIfEmpty)
-{
-  // do nothing
-}
diff --git a/src/lib/base/LogOutputters.h b/src/lib/base/LogOutputters.h
index bdce88297..7af4c5c45 100644
--- a/src/lib/base/LogOutputters.h
+++ b/src/lib/base/LogOutputters.h
@@ -27,7 +27,6 @@ public:
   // ILogOutputter overrides
   void open(const QString &title) override;
   void close() override;
-  void show(bool showIfEmpty) override;
   bool write(LogLevel level, const QString &message) override;
 };
 
@@ -45,7 +44,6 @@ public:
   // ILogOutputter overrides
   void open(const QString &title) override;
   void close() override;
-  void show(bool showIfEmpty) override;
   bool write(LogLevel level, const QString &message) override;
   void flush() const;
 };
@@ -65,7 +63,6 @@ public:
   // ILogOutputter overrides
   void open(const QString &title) override;
   void close() override;
-  void show(bool showIfEmpty) override;
   bool write(LogLevel level, const QString &message) override;
 
   void setLogFilename(const QString &title);
@@ -87,7 +84,6 @@ public:
   // ILogOutputter overrides
   void open(const QString &title) override;
   void close() override;
-  void show(bool showIfEmpty) override;
   bool write(LogLevel level, const QString &message) override;
 };
 
diff --git a/src/lib/platform/MSWindowsDebugOutputter.cpp b/src/lib/platform/MSWindowsDebugOutputter.cpp
index 06cb85f41..4e901df0d 100644
--- a/src/lib/platform/MSWindowsDebugOutputter.cpp
+++ b/src/lib/platform/MSWindowsDebugOutputter.cpp
@@ -22,11 +22,6 @@ void MSWindowsDebugOutputter::close()
   // do nothing
 }
 
-void MSWindowsDebugOutputter::show(bool showIfEmpty)
-{
-  // do nothing
-}
-
 bool MSWindowsDebugOutputter::write(LogLevel level, const QString &msg)
 {
   std::wstring out = msg.toStdWString() + L"\n";
diff --git a/src/lib/platform/MSWindowsDebugOutputter.h b/src/lib/platform/MSWindowsDebugOutputter.h
index 1bf334790..671006937 100644
--- a/src/lib/platform/MSWindowsDebugOutputter.h
+++ b/src/lib/platform/MSWindowsDebugOutputter.h
@@ -23,7 +23,6 @@ public:
   // ILogOutputter overrides
   void open(const QString &title) override;
   void close() override;
-  void show(bool showIfEmpty) override;
   bool write(LogLevel level, const QString &message) override;
   void flush();
 };