From 71c1bb87cab5e48f71ba90408ab693090c5a845b Mon Sep 17 00:00:00 2001
From: sithlord48 <sithlord48@gmail.com>
Date: Fri, 17 Oct 2025 17:39:29 -0400
Subject: [PATCH] refactor: Mainwindow prepare for translations by simplifying
 MainWindow::serverClientsChanged to use plural form always

---
 src/lib/gui/MainWindow.cpp | 32 +++++++++++---------------------
 1 file changed, 11 insertions(+), 21 deletions(-)

diff --git a/src/lib/gui/MainWindow.cpp b/src/lib/gui/MainWindow.cpp
index 92bf2717f..beb1745c9 100644
--- a/src/lib/gui/MainWindow.cpp
+++ b/src/lib/gui/MainWindow.cpp
@@ -1196,30 +1196,20 @@ void MainWindow::serverClientsChanged(const QStringList &clients)
   if (m_coreProcess.mode() != CoreMode::Server || !m_coreProcess.isStarted())
     return;
 
-  switch (clients.size()) {
-  case 0:
+  if (clients.isEmpty()) {
     setStatus(tr("%1 is waiting for clients").arg(kAppName));
     ui->statusBar->setToolTip("");
-    break;
-
-  case 1:
-    setStatus(tr("%1 is connected to a client: %2").arg(kAppName, clients.first()));
-    ui->statusBar->setToolTip("");
-    break;
-
-  case 2:
-  case 3:
-  case 4:
-    setStatus(
-        tr("%1 is connected, with %2 clients: %3").arg(kAppName, QString::number(clients.size()), clients.join(", "))
-    );
-    ui->statusBar->setToolTip(tr("Clients:\n %1").arg(clients.join("\n")));
-    break;
-  default:
-    setStatus(tr("%1 is connected, with %n client(s)", "", clients.size()).arg(kAppName));
-    ui->statusBar->setToolTip(tr("Clients:\n  %1").arg(clients.join("\n")));
-    break;
+    return;
   }
+
+  //: Shown when in server mode and at least 1 client is connected
+  //: %1 is replaced by the app name
+  //: %2 will be a list of at least one client
+  //: %n will be replaced by the number of clients (n is >=1), it is not requried to be in the translation
+  setStatus(tr("%1 is connected, with %n client(s): %2", "", clients.size()).arg(kAppName, clients.join(", ")));
+
+  const auto toolTipString = clients.count() == 1 ? "" : tr("Clients:\n %1").arg(clients.join("\n"));
+  ui->statusBar->setToolTip(toolTipString);
 }
 
 void MainWindow::daemonIpcClientConnectionFailed()