From 71e271db495099b18516e37640f8254e7f9aebe0 Mon Sep 17 00:00:00 2001
From: Serhii Hadzhilov <serhii-external@symless.com>
Date: Fri, 2 Oct 2020 10:48:17 +0300
Subject: [PATCH] #6799 Synergy "Business" edition. Fix sonar issues
 SYNERGY-315

---
 src/lib/shared/SerialKeyEdition.cpp | 6 +++---
 src/lib/shared/SerialKeyEdition.h   | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/lib/shared/SerialKeyEdition.cpp b/src/lib/shared/SerialKeyEdition.cpp
index 67fe5222f..02c1cf25a 100644
--- a/src/lib/shared/SerialKeyEdition.cpp
+++ b/src/lib/shared/SerialKeyEdition.cpp
@@ -28,7 +28,7 @@ SerialKeyEdition::getType() const
 	return m_Type;
 }
 
-const std::string
+std::string
 SerialKeyEdition::getName() const
 {
 	std::string Name;
@@ -53,7 +53,7 @@ SerialKeyEdition::getName() const
 	return Name;
 }
 
-const std::string
+std::string
 SerialKeyEdition::getDisplayName() const
 {
 	const std::string ApplicationName = "Synergy 1 ";
@@ -65,7 +65,7 @@ SerialKeyEdition::getDisplayName() const
 			EditionName = "(" + EditionName +")";
 		}
 		else{
-			EditionName[0] = ::toupper(EditionName[0]);
+			EditionName[0] = static_cast<char>(::toupper(EditionName[0]));
 		}
 	}
 
diff --git a/src/lib/shared/SerialKeyEdition.h b/src/lib/shared/SerialKeyEdition.h
index 810a572b6..43fdb9efb 100644
--- a/src/lib/shared/SerialKeyEdition.h
+++ b/src/lib/shared/SerialKeyEdition.h
@@ -28,8 +28,8 @@ public:
 	explicit SerialKeyEdition(const std::string& type);
 
 	Edition getType() const;
-	const std::string getName() const;
-	const std::string getDisplayName() const;
+	std::string getName() const;
+	std::string getDisplayName() const;
 
 	void setType(Edition type);
 	void setType(const std::string& type);