smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(ipc): Log more detail on IPC error handling

Browse source
This commit is contained in:
Nick Bolton 2026-03-31 10:24:59 +01:00
parent 25f3eb3f22
commit 77bee2ddf3
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lib/deskflow/ipc/IpcServer.cpp
View file

@ -118,7 +118,7 @@ void IpcServer::processMessage(QLocalSocket *clientSocket, const QString &messag
if (clientVersion != versionId) { if (clientVersion != versionId) {
LOG_ERR("%s ipc client version mismatch (server: %s)", m_typeName.constData(), versionId.toUtf8().constData()); LOG_ERR("%s ipc client version mismatch (server: %s)", m_typeName.constData(), versionId.toUtf8().constData());
writeToClientSocket(clientSocket, "error"); writeToClientSocket(clientSocket, QStringLiteral("error=version mismatch, expected: %1").arg(versionId));
clientSocket->flush(); clientSocket->flush();
clientSocket->disconnectFromServer(); clientSocket->disconnectFromServer();
return; return;

8
src/lib/gui/ipc/IpcClient.cpp
View file

@ -163,6 +163,14 @@ void IpcClient::handleReadyRead()
void IpcClient::handleHandshakeMessage(const QStringList &parts) void IpcClient::handleHandshakeMessage(const QStringList &parts)
{ {
if (parts.at(0) == "error") {
const auto detail = parts.size() >= 2 ? parts.at(1) : QString("unknown");
qCritical().noquote() << m_typeName << "ipc server rejected connection:" << detail;
disconnectFromServer();
Q_EMIT connectionFailed();
return;
}
if (parts.at(0) != "hello") { if (parts.at(0) != "hello") {
return; return;
} }