refactor: Screen, Mark methods as no discard, remove uneeded method

This commit is contained in:
Tomaz Canabrava 2025-05-08 12:34:56 +02:00 committed by Nick Bolton
parent 7c279ec72d
commit 7ced794317

View file

@ -43,70 +43,67 @@ class Screen : public ScreenConfig
public: public:
explicit Screen(const QString &name = QString()); explicit Screen(const QString &name = QString());
const QPixmap &pixmap() const [[nodiscard]] const QPixmap &pixmap() const
{ {
return m_Pixmap; return m_Pixmap;
} }
const QString &name() const [[nodiscard]] const QString &name() const
{ {
return m_Name; return m_Name;
} }
const QStringList &aliases() const [[nodiscard]] const QStringList &aliases() const
{ {
return m_Aliases; return m_Aliases;
} }
bool isNull() const [[nodiscard]] bool isNull() const
{ {
return m_Name.isEmpty(); return m_Name.isEmpty();
} }
int modifier(int m) const [[nodiscard]] int modifier(int m) const
{ {
return m_Modifiers[m] == static_cast<int>(ScreenConfig::Modifier::DefaultMod) ? m : m_Modifiers[m]; return m_Modifiers[m] == static_cast<int>(ScreenConfig::Modifier::DefaultMod) ? m : m_Modifiers[m];
} }
const QList<int> &modifiers() const [[nodiscard]] const QList<int> &modifiers() const
{ {
return m_Modifiers; return m_Modifiers;
} }
bool switchCorner(int c) const [[nodiscard]] bool switchCorner(int c) const
{ {
return m_SwitchCorners[c]; return m_SwitchCorners[c];
} }
const QList<bool> &switchCorners() const [[nodiscard]] const QList<bool> &switchCorners() const
{ {
return m_SwitchCorners; return m_SwitchCorners;
} }
int switchCornerSize() const [[nodiscard]] int switchCornerSize() const
{ {
return m_SwitchCornerSize; return m_SwitchCornerSize;
} }
bool fix(Fix f) const [[nodiscard]] bool fix(Fix f) const
{ {
return m_Fixes[static_cast<int>(f)]; return m_Fixes[static_cast<int>(f)];
} }
const QList<bool> &fixes() const [[nodiscard]] const QList<bool> &fixes() const
{ {
return m_Fixes; return m_Fixes;
} }
void loadSettings(QSettingsProxy &settings); void loadSettings(QSettingsProxy &settings);
void saveSettings(QSettingsProxy &settings) const; void saveSettings(QSettingsProxy &settings) const;
QString screensSection() const; [[nodiscard]] QString screensSection() const;
QString aliasesSection() const; [[nodiscard]] QString aliasesSection() const;
bool swapped() const [[nodiscard]] bool swapped() const
{ {
return m_Swapped; return m_Swapped;
} }
QString &name()
{
return m_Name;
}
void setName(const QString &name) void setName(const QString &name)
{ {
m_Name = name; m_Name = name;
} }
bool isServer() const [[nodiscard]] bool isServer() const
{ {
return m_isServer; return m_isServer;
} }