smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SYNERGY-677 Common settings should always be saved. (#6936)

Browse source 
* SYNERGY-677 Application loses settings

* SYNERGY-677 Update ChangeLog

* SYNERGY-677 Code smells fix.

* SYNERGY-677 Don't save settings into memory if the file is not writable.

* SYNERGY-677 Update ChangeLog

* SYNERGY-677 Common settings should be saved in any case.

* SYNERGY-677 Update ChangeLog
This commit is contained in:
SerhiiGadzhilov 2021-02-05 20:32:26 +03:00 committed by GitHub
parent 8455aa3651
commit 801e796b93
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ChangeLog
View file

@ -10,7 +10,7 @@ Bug fixes:
- #6921 Handling pre-main window creation status notifications - #6921 Handling pre-main window creation status notifications
- #6922 macOS CI build - #6922 macOS CI build
- #6927 Text copied and pasted between Windows and Mac OS converts to japanese - #6927 Text copied and pasted between Windows and Mac OS converts to japanese
- #6935 Application loses settings - #6936 Application loses settings
Enhancements: Enhancements:
- #6912 Removes UI for Screen Saver Sync and Files Drag and Drop - #6912 Removes UI for Screen Saver Sync and Files Drag and Drop

5
src/gui/src/AppConfig.cpp
View file

@ -263,9 +263,10 @@ void AppConfig::loadSettings()
void AppConfig::saveSettings() void AppConfig::saveSettings()
{ {
setCommonSetting(kWizardLastRun, kWizardVersion);
setCommonSetting(kLoadSystemSettings, m_LoadFromSystemScope);
if (isWritable()) { if (isWritable()) {
setCommonSetting(kWizardLastRun, kWizardVersion);
setCommonSetting(kLoadSystemSettings, m_LoadFromSystemScope);
setSetting(kScreenName, m_ScreenName); setSetting(kScreenName, m_ScreenName);
setSetting(kPort, m_Port); setSetting(kPort, m_Port);
setSetting(kInterfaceSetting, m_Interface); setSetting(kInterfaceSetting, m_Interface);