SYNERGY-677 Application loses settings. Don't save settings into memory if the file is not writable. (#6935)

* SYNERGY-677 Application loses settings

* SYNERGY-677 Update ChangeLog

* SYNERGY-677 Code smells fix.

* SYNERGY-677 Don't save settings into memory if the file is not writable.

* SYNERGY-677 Update ChangeLog
This commit is contained in:
SerhiiGadzhilov 2021-02-05 18:14:52 +03:00 committed by GitHub
parent ab3fb6e149
commit 8455aa3651
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 33 additions and 31 deletions

View file

@ -10,7 +10,7 @@ Bug fixes:
- #6921 Handling pre-main window creation status notifications
- #6922 macOS CI build
- #6927 Text copied and pasted between Windows and Mac OS converts to japanese
- #6933 Application loses settings
- #6935 Application loses settings
Enhancements:
- #6912 Removes UI for Screen Saver Sync and Files Drag and Drop

View file

@ -263,6 +263,7 @@ void AppConfig::loadSettings()
void AppConfig::saveSettings()
{
if (isWritable()) {
setCommonSetting(kWizardLastRun, kWizardVersion);
setCommonSetting(kLoadSystemSettings, m_LoadFromSystemScope);
setSetting(kScreenName, m_ScreenName);
@ -293,6 +294,7 @@ void AppConfig::saveSettings()
setSetting(kUseInternalConfig, m_UseInternalConfig);
setSetting(kGroupClientCheck, m_ClientGroupChecked);
setSetting(kServerHostname, m_ServerHostname);
}
m_unsavedChanges = false;
}