From 903401796e8f8b47c4d2240e5d5b12c4ed5ed96c Mon Sep 17 00:00:00 2001
From: sithlord48 <sithlord48@gmail.com>
Date: Fri, 2 May 2025 07:35:54 -0400
Subject: [PATCH] refactor: Remove use of DESKFLOW_RESET_ALL and all users to
 pass --reset switch to deskflow-gui instead

---
 src/apps/deskflow-gui/deskflow-gui.cpp | 7 +++----
 src/lib/gui/Diagnostic.cpp             | 5 +++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/apps/deskflow-gui/deskflow-gui.cpp b/src/apps/deskflow-gui/deskflow-gui.cpp
index 73edeb161..0dbb6a7c4 100644
--- a/src/apps/deskflow-gui/deskflow-gui.cpp
+++ b/src/apps/deskflow-gui/deskflow-gui.cpp
@@ -55,13 +55,13 @@ int main(int argc, char *argv[])
   // Add Command Line Options
   auto helpOption = QCommandLineOption("help", "Display Help on the command line");
   auto versionOption = QCommandLineOption("version", "Display version information");
-  auto noResetOption = QCommandLineOption("no-reset", "Prevent settings reset if DESKFLOW_RESET_ALL is set");
+  auto resetOption = QCommandLineOption("reset", "Reset all settings");
 
   QCommandLineParser parser;
   parser.setSingleDashWordOptionMode(QCommandLineParser::ParseAsLongOptions);
   parser.addOption(helpOption);
   parser.addOption(versionOption);
-  parser.addOption(noResetOption);
+  parser.addOption(resetOption);
   parser.parse(QCoreApplication::arguments());
 
   const auto header = QStringLiteral("%1: %2\n").arg(kAppName, kDisplayVersion);
@@ -132,8 +132,7 @@ int main(int argc, char *argv[])
 #endif
 
   // --no-reset
-  const auto resetEnvVar = QVariant(qEnvironmentVariable("DESKFLOW_RESET_ALL")).toBool();
-  if (resetEnvVar && !parser.isSet(noResetOption)) {
+  if (parser.isSet(resetOption)) {
     diagnostic::clearSettings(false);
   }
 
diff --git a/src/lib/gui/Diagnostic.cpp b/src/lib/gui/Diagnostic.cpp
index 5ae553275..10dc05e19 100644
--- a/src/lib/gui/Diagnostic.cpp
+++ b/src/lib/gui/Diagnostic.cpp
@@ -19,8 +19,9 @@ void restart()
   QString program = QCoreApplication::applicationFilePath();
   QStringList arguments = QCoreApplication::arguments();
 
-  // prevent infinite reset loop when env var set.
-  arguments << "--no-reset";
+  // look for and remove --reset option if found
+  if (int resetIndex = arguments.indexOf("--reset"); resetIndex != -1)
+    arguments.remove(resetIndex);
 
   qInfo("launching new process: %s", qPrintable(program));
   QProcess::startDetached(program, arguments);