smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: remove unused gui/CommandProcess

Browse source
This commit is contained in:
sithlord48 2026-01-23 21:35:49 -05:00 committed by Nick Bolton
parent 86c8c66b6e
commit 973cc76927
6 changed files with 0 additions and 136 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lib/gui/CMakeLists.txt
View file

@ -50,8 +50,6 @@ add_library(${target} STATIC
config/ServerConfig.h
core/ClientConnection.cpp
core/ClientConnection.h
core/CommandProcess.cpp
core/CommandProcess.h
core/CoreProcess.cpp
core/CoreProcess.h
core/NetworkMonitor.cpp

49
src/lib/gui/core/CommandProcess.cpp
View file

@ -1,49 +0,0 @@
/*
* Deskflow -- mouse and keyboard sharing utility
* SPDX-FileCopyrightText: (C) 2014 Symless Ltd.
* SPDX-License-Identifier: GPL-2.0-only WITH LicenseRef-OpenSSL-Exception
*/
#include "CommandProcess.h"
#include <QProcess>
CommandProcess::CommandProcess(QString command, QStringList arguments, QString input)
: m_Command(command),
m_Arguments(arguments),
m_Input(input)
{
// do nothing
}
QString CommandProcess::run()
{
QProcess process;
process.setReadChannel(QProcess::StandardOutput);
process.start(m_Command, m_Arguments);
bool success = process.waitForStarted();
QString output;
QString error;
if (success) {
if (!m_Input.isEmpty()) {
process.write(qPrintable(m_Input));
}
if (process.waitForFinished()) {
output = process.readAllStandardOutput().trimmed();
error = process.readAllStandardError().trimmed();
}
}
if (int code = process.exitCode(); !success || code != 0) {
qFatal(
"command failed: %s %s\ncode: %d\nerror: %s", qUtf8Printable(m_Command), qUtf8Printable(m_Arguments.join(" ")),
code, error.isEmpty() ? "none" : qUtf8Printable(error)
);
}
Q_EMIT finished();
return output;
}

29
src/lib/gui/core/CommandProcess.h
View file

@ -1,29 +0,0 @@
/*
* Deskflow -- mouse and keyboard sharing utility
* SPDX-FileCopyrightText: (C) 2014 Symless Ltd.
* SPDX-License-Identifier: GPL-2.0-only WITH LicenseRef-OpenSSL-Exception
*/
#pragma once
#include <QObject>
#include <QStringList>
class CommandProcess : public QObject
{
Q_OBJECT
public:
CommandProcess(QString cmd, QStringList arguments, QString input = "");
Q_SIGNALS:
void finished();
public Q_SLOTS:
QString run();
private:
QString m_Command;
QStringList m_Arguments;
QString m_Input;
};

7
src/unittests/gui/core/CMakeLists.txt
View file

@ -1,13 +1,6 @@
# SPDX-FileCopyrightText: (C) 2025 Deskflow Developers
# SPDX-License-Identifier: MIT
create_test(
NAME CommandProcessTests
DEPENDS gui
SOURCE CommandProcessTests.cpp
WORKING_DIRECTORY "${CMAKE_BINARY_DIR}/src/lib/gui"
)
create_test(
NAME ClientConnectionTests
DEPENDS gui

33
src/unittests/gui/core/CommandProcessTests.cpp
View file

@ -1,33 +0,0 @@
/*
* Deskflow -- mouse and keyboard sharing utility
* SPDX-FileCopyrightText: (C) 2025 Chris Rizzitello <sithlord48@gmail.com>
* SPDX-FileCopyrightText: (C) 2024 Symless Ltd.
* SPDX-License-Identifier: GPL-2.0-only WITH LicenseRef-OpenSSL-Exception
*/
#include "CommandProcessTests.h"
#include "gui/core/CommandProcess.h"
void CommandProcessTests::runCommand()
{
// it seems that on windows, you can sometimes just call echo (this worked
// with windows 2022), but on windows 10 you can't call echo directly.
#if defined(Q_OS_WIN)
const QString command = "cmd";
const QStringList arguments = {"/C", "echo Hello, World!"};
const QString input = "";
#elif defined(Q_OS_UNIX)
const QString command = "echo";
const QStringList arguments = {"Hello, World!"};
const QString input = "";
#endif // Q_OS_WIN
CommandProcess commandProcess(command, arguments, input);
const QString actual = commandProcess.run();
QCOMPARE(actual.toStdString(), "Hello, World!");
}
QTEST_MAIN(CommandProcessTests)

16
src/unittests/gui/core/CommandProcessTests.h
View file

@ -1,16 +0,0 @@
/*
* Deskflow -- mouse and keyboard sharing utility
* SPDX-FileCopyrightText: (C) 2025 Chris Rizzitello <sithlord48@gmail.com>
* SPDX-License-Identifier: GPL-2.0-only WITH LicenseRef-OpenSSL-Exception
*/
#include <QTest>
class CommandProcessTests : public QObject
{
Q_OBJECT
private Q_SLOTS:
// Test are run in order top to bottom
// void initTestCase();
void runCommand();
};