smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(daemon): reject remote config file paths to prevent NTLM hash leakage

Browse source
This commit is contained in:
Nick Bolton 2026-04-24 16:05:04 +01:00 committed by Chris Rizzitello
parent 69339b5bcc
commit 99912b9bc6
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/apps/deskflow-daemon/DaemonApp.cpp
View file

@ -62,6 +62,14 @@ void DaemonApp::applyWatchdogCommand() const
return; return;
} }
// QFileInfo::exists on a UNC path triggers SMB auth from this SYSTEM-context
// process, leaking the machine NTLM hash to whoever controls the remote host.
// Any local user can reach this via the IPC pipe, so reject remote paths up front.
if (m_configFile.startsWith(QStringLiteral("\\\\")) || m_configFile.startsWith(QStringLiteral("//"))) {
LOG_ERR("cannot apply watchdog command: remote config file paths are not allowed: %s", qPrintable(m_configFile));
return;
}
if (!QFileInfo::exists(m_configFile)) { if (!QFileInfo::exists(m_configFile)) {
LOG_ERR("cannot apply watchdog command: config file does not exist: %s", qPrintable(m_configFile)); LOG_ERR("cannot apply watchdog command: config file does not exist: %s", qPrintable(m_configFile));
return; return;