chore: clean up macos code smell missed by sonarscan

src/lib/platform/OSXClipboard.h

@@ -25,13 +25,13 @@ public:
   static bool isOwnedByDeskflow();
 
   // IClipboard overrides
-  virtual bool empty();
+  bool empty() override;
-  virtual void add(EFormat, const std::string &data);
+  void add(EFormat, const std::string &data) override;
-  virtual bool open(Time) const;
+  bool open(Time) const override;
-  virtual void close() const;
+  void close() const override;
-  virtual Time getTime() const;
+  Time getTime() const override;
-  virtual bool has(EFormat) const;
+  bool has(EFormat) const override;
-  virtual std::string get(EFormat) const;
+  std::string get(EFormat) const override;
 
   bool synchronize();
 

src/lib/platform/OSXClipboardAnyBitmapConverter.cpp

@@ -8,16 +8,6 @@
 #include "platform/OSXClipboardAnyBitmapConverter.h"
 #include <algorithm>
 
-OSXClipboardAnyBitmapConverter::OSXClipboardAnyBitmapConverter()
-{
-  // do nothing
-}
-
-OSXClipboardAnyBitmapConverter::~OSXClipboardAnyBitmapConverter()
-{
-  // do nothing
-}
-
 IClipboard::EFormat OSXClipboardAnyBitmapConverter::getFormat() const
 {
   return IClipboard::kBitmap;

src/lib/platform/OSXClipboardAnyBitmapConverter.h

@@ -13,14 +13,14 @@
 class OSXClipboardAnyBitmapConverter : public IOSXClipboardConverter
 {
 public:
-  OSXClipboardAnyBitmapConverter();
+  OSXClipboardAnyBitmapConverter() = default;
-  virtual ~OSXClipboardAnyBitmapConverter();
+  ~OSXClipboardAnyBitmapConverter() override = default;
 
   // IOSXClipboardConverter overrides
-  virtual IClipboard::EFormat getFormat() const;
+  IClipboard::EFormat getFormat() const override;
-  virtual CFStringRef getOSXFormat() const = 0;
+  CFStringRef getOSXFormat() const override = 0;
-  virtual std::string fromIClipboard(const std::string &) const;
+  std::string fromIClipboard(const std::string &) const override;
-  virtual std::string toIClipboard(const std::string &) const;
+  std::string toIClipboard(const std::string &) const override;
 
 protected:
   //! Convert from IClipboard format

src/lib/platform/OSXClipboardAnyTextConverter.cpp

@@ -13,16 +13,6 @@
 // OSXClipboardAnyTextConverter
 //
 
-OSXClipboardAnyTextConverter::OSXClipboardAnyTextConverter()
-{
-  // do nothing
-}
-
-OSXClipboardAnyTextConverter::~OSXClipboardAnyTextConverter()
-{
-  // do nothing
-}
-
 IClipboard::EFormat OSXClipboardAnyTextConverter::getFormat() const
 {
   return IClipboard::kText;

src/lib/platform/OSXClipboardAnyTextConverter.h

@@ -13,14 +13,14 @@
 class OSXClipboardAnyTextConverter : public IOSXClipboardConverter
 {
 public:
-  OSXClipboardAnyTextConverter();
+  OSXClipboardAnyTextConverter() = default;
-  virtual ~OSXClipboardAnyTextConverter();
+  ~OSXClipboardAnyTextConverter() override = default;
 
   // IOSXClipboardConverter overrides
-  virtual IClipboard::EFormat getFormat() const;
+  IClipboard::EFormat getFormat() const override;
-  virtual CFStringRef getOSXFormat() const = 0;
+  std::string fromIClipboard(const std::string &) const override;
-  virtual std::string fromIClipboard(const std::string &) const;
+  std::string toIClipboard(const std::string &) const override;
-  virtual std::string toIClipboard(const std::string &) const;
+  CFStringRef getOSXFormat() const override = 0;
 
 protected:
   //! Convert from IClipboard format

src/lib/platform/OSXClipboardBMPConverter.cpp

@@ -48,16 +48,6 @@ static void toLE(uint8_t *&dst, uint32_t src)
   dst += 4;
 }
 
-OSXClipboardBMPConverter::OSXClipboardBMPConverter()
-{
-  // do nothing
-}
-
-OSXClipboardBMPConverter::~OSXClipboardBMPConverter()
-{
-  // do nothing
-}
-
 IClipboard::EFormat OSXClipboardBMPConverter::getFormat() const
 {
   return IClipboard::kBitmap;

src/lib/platform/OSXClipboardBMPConverter.h

@@ -13,17 +13,16 @@
 class OSXClipboardBMPConverter : public IOSXClipboardConverter
 {
 public:
-  OSXClipboardBMPConverter();
+  OSXClipboardBMPConverter() = default;
-  virtual ~OSXClipboardBMPConverter();
+  ~OSXClipboardBMPConverter() override = default;
 
   // IMSWindowsClipboardConverter overrides
-  virtual IClipboard::EFormat getFormat() const;
+  IClipboard::EFormat getFormat() const override;
-
+  CFStringRef getOSXFormat() const override;
-  virtual CFStringRef getOSXFormat() const;
 
   // OSXClipboardAnyBMPConverter overrides
-  virtual std::string fromIClipboard(const std::string &) const;
+  std::string fromIClipboard(const std::string &) const override;
-  virtual std::string toIClipboard(const std::string &) const;
+  std::string toIClipboard(const std::string &) const override;
 
   // generic encoding converter
   static std::string convertString(const std::string &data, CFStringEncoding fromEncoding, CFStringEncoding toEncoding);

src/lib/platform/OSXClipboardHTMLConverter.cpp

@@ -9,16 +9,6 @@
 
 #include "base/Unicode.h"
 
-OSXClipboardHTMLConverter::OSXClipboardHTMLConverter()
-{
-  // do nothing
-}
-
-OSXClipboardHTMLConverter::~OSXClipboardHTMLConverter()
-{
-  // do nothing
-}
-
 IClipboard::EFormat OSXClipboardHTMLConverter::getFormat() const
 {
   return IClipboard::kHTML;

src/lib/platform/OSXClipboardHTMLConverter.h

@@ -13,18 +13,17 @@
 class OSXClipboardHTMLConverter : public OSXClipboardAnyTextConverter
 {
 public:
-  OSXClipboardHTMLConverter();
+  OSXClipboardHTMLConverter() = default;
-  virtual ~OSXClipboardHTMLConverter();
+  ~OSXClipboardHTMLConverter() override = default;
 
   // IMSWindowsClipboardConverter overrides
-  virtual IClipboard::EFormat getFormat() const;
+  IClipboard::EFormat getFormat() const override;
-
+  CFStringRef getOSXFormat() const override;
-  virtual CFStringRef getOSXFormat() const;
 
 protected:
   // OSXClipboardAnyTextConverter overrides
-  virtual std::string doFromIClipboard(const std::string &) const;
+  std::string doFromIClipboard(const std::string &) const override;
-  virtual std::string doToIClipboard(const std::string &) const;
+  std::string doToIClipboard(const std::string &) const override;
 
   // generic encoding converter
   static std::string convertString(const std::string &data, CFStringEncoding fromEncoding, CFStringEncoding toEncoding);

src/lib/platform/OSXClipboardTextConverter.cpp

@@ -13,16 +13,6 @@
 // OSXClipboardTextConverter
 //
 
-OSXClipboardTextConverter::OSXClipboardTextConverter()
-{
-  // do nothing
-}
-
-OSXClipboardTextConverter::~OSXClipboardTextConverter()
-{
-  // do nothing
-}
-
 CFStringRef OSXClipboardTextConverter::getOSXFormat() const
 {
   return CFSTR("public.plain-text");

src/lib/platform/OSXClipboardTextConverter.h

@@ -13,16 +13,16 @@
 class OSXClipboardTextConverter : public OSXClipboardAnyTextConverter
 {
 public:
-  OSXClipboardTextConverter();
+  OSXClipboardTextConverter() = default;
-  virtual ~OSXClipboardTextConverter();
+  ~OSXClipboardTextConverter() override = default;
 
   // IOSXClipboardAnyTextConverter overrides
-  virtual CFStringRef getOSXFormat() const;
+  CFStringRef getOSXFormat() const override;
 
 protected:
   // OSXClipboardAnyTextConverter overrides
-  virtual std::string doFromIClipboard(const std::string &) const;
+  std::string doFromIClipboard(const std::string &) const override;
-  virtual std::string doToIClipboard(const std::string &) const;
+  std::string doToIClipboard(const std::string &) const override;
 
   // generic encoding converter
   static std::string convertString(const std::string &data, CFStringEncoding fromEncoding, CFStringEncoding toEncoding);

src/lib/platform/OSXClipboardUTF16Converter.cpp

@@ -13,16 +13,6 @@
 // OSXClipboardUTF16Converter
 //
 
-OSXClipboardUTF16Converter::OSXClipboardUTF16Converter()
-{
-  // do nothing
-}
-
-OSXClipboardUTF16Converter::~OSXClipboardUTF16Converter()
-{
-  // do nothing
-}
-
 CFStringRef OSXClipboardUTF16Converter::getOSXFormat() const
 {
   return CFSTR("public.utf16-plain-text");

src/lib/platform/OSXClipboardUTF16Converter.h

@@ -13,14 +13,14 @@
 class OSXClipboardUTF16Converter : public OSXClipboardAnyTextConverter
 {
 public:
-  OSXClipboardUTF16Converter();
+  OSXClipboardUTF16Converter() = default;
-  virtual ~OSXClipboardUTF16Converter();
+  ~OSXClipboardUTF16Converter() override = default;
 
   // IOSXClipboardAnyTextConverter overrides
-  virtual CFStringRef getOSXFormat() const;
+  CFStringRef getOSXFormat() const override;
 
 protected:
   // OSXClipboardAnyTextConverter overrides
-  virtual std::string doFromIClipboard(const std::string &) const;
+  std::string doFromIClipboard(const std::string &) const override;
-  virtual std::string doToIClipboard(const std::string &) const;
+  std::string doToIClipboard(const std::string &) const override;
 };

src/lib/platform/OSXClipboardUTF8Converter.h

@@ -12,9 +12,12 @@
 class OSXClipboardUTF8Converter : public OSXClipboardAnyTextConverter
 {
 public:
-  virtual CFStringRef getOSXFormat() const;
+  OSXClipboardUTF8Converter() = default;
+  ~OSXClipboardUTF8Converter() override = default;
+
+  CFStringRef getOSXFormat() const override;
 
 private:
-  virtual std::string doFromIClipboard(const std::string &) const;
+  std::string doFromIClipboard(const std::string &) const override;
-  virtual std::string doToIClipboard(const std::string &) const;
+  std::string doToIClipboard(const std::string &) const override;
 };

src/lib/platform/OSXEventQueueBuffer.cpp

@@ -29,11 +29,6 @@ OSXEventQueueBuffer::OSXEventQueueBuffer(IEventQueue *events) : m_eventQueue(eve
   // Initialization is now managed using modern constructs
 }
 
-OSXEventQueueBuffer::~OSXEventQueueBuffer()
-{
-  // No explicit clean-up needed as GCD and STL handle resource management
-}
-
 void OSXEventQueueBuffer::init()
 {
   // No initialization needed for GCD-based implementation

src/lib/platform/OSXEventQueueBuffer.h

@@ -22,16 +22,16 @@ class OSXEventQueueBuffer : public IEventQueueBuffer
 {
 public:
   OSXEventQueueBuffer(IEventQueue *eventQueue);
-  virtual ~OSXEventQueueBuffer();
+  ~OSXEventQueueBuffer() override = default;
 
   // IEventQueueBuffer overrides
-  virtual void init() override;
+  void init() override;
-  virtual void waitForEvent(double timeout) override;
+  void waitForEvent(double timeout) override;
-  virtual Type getEvent(Event &event, uint32_t &dataID) override;
+  Type getEvent(Event &event, uint32_t &dataID) override;
-  virtual bool addEvent(uint32_t dataID) override;
+  bool addEvent(uint32_t dataID) override;
-  virtual bool isEmpty() const override;
+  bool isEmpty() const override;
-  virtual EventQueueTimer *newTimer(double duration, bool oneShot) const override;
+  EventQueueTimer *newTimer(double duration, bool oneShot) const override;
-  virtual void deleteTimer(EventQueueTimer *timer) const override;
+  void deleteTimer(EventQueueTimer *timer) const override;
 
 private:
   IEventQueue *m_eventQueue;

src/lib/platform/OSXKeyState.cpp

@@ -193,10 +193,6 @@ OSXKeyState::OSXKeyState(
   init();
 }
 
-OSXKeyState::~OSXKeyState()
-{
-}
-
 void OSXKeyState::init()
 {
   m_deadKeyState = 0;

src/lib/platform/OSXKeyState.h

@@ -29,7 +29,7 @@ public:
 
   OSXKeyState(IEventQueue *events, std::vector<std::string> layouts, bool isLangSyncEnabled);
   OSXKeyState(IEventQueue *events, deskflow::KeyMap &keyMap, std::vector<std::string> layouts, bool isLangSyncEnabled);
-  virtual ~OSXKeyState();
+  ~OSXKeyState() override = default;
 
   //! @name modifiers
   //@{
@@ -79,18 +79,18 @@ public:
   //@}
 
   // IKeyState overrides
-  virtual bool fakeCtrlAltDel();
+  bool fakeCtrlAltDel() override;
-  virtual bool fakeMediaKey(KeyID id);
+  bool fakeMediaKey(KeyID id) override;
-  virtual KeyModifierMask pollActiveModifiers() const;
+  KeyModifierMask pollActiveModifiers() const override;
-  virtual int32_t pollActiveGroup() const;
+  int32_t pollActiveGroup() const override;
-  virtual void pollPressedKeys(KeyButtonSet &pressedKeys) const;
+  void pollPressedKeys(KeyButtonSet &pressedKeys) const override;
 
   CGEventFlags getModifierStateAsOSXFlags() const;
 
 protected:
   // KeyState overrides
-  virtual void getKeyMap(deskflow::KeyMap &keyMap);
+  void getKeyMap(deskflow::KeyMap &keyMap) override;
-  virtual void fakeKey(const Keystroke &keystroke);
+  void fakeKey(const Keystroke &keystroke) override;
 
 private:
   class KeyResource;

src/lib/platform/OSXPowerManager.cpp

@@ -8,10 +8,6 @@
 #include "OSXPowerManager.h"
 #include "base/Log.h"
 
-OSXPowerManager::OSXPowerManager()
-{
-}
-
 OSXPowerManager::~OSXPowerManager()
 {
   enableSleep();

src/lib/platform/OSXPowerManager.h

@@ -12,7 +12,7 @@
 class OSXPowerManager
 {
 public:
-  OSXPowerManager();
+  OSXPowerManager() = default;
   ~OSXPowerManager();
 
   /**

src/lib/platform/OSXScreenSaver.h

@@ -18,14 +18,14 @@ class OSXScreenSaver : public IScreenSaver
 {
 public:
   OSXScreenSaver(IEventQueue *events, void *eventTarget);
-  virtual ~OSXScreenSaver();
+  ~OSXScreenSaver();
 
   // IScreenSaver overrides
-  virtual void enable();
+  void enable() override;
-  virtual void disable();
+  void disable() override;
-  virtual void activate();
+  void activate() override;
-  virtual void deactivate();
+  void deactivate() override;
-  virtual bool isActive() const;
+  bool isActive() const override;
 
 private:
   void processLaunched(ProcessSerialNumber psn);

src/lib/platform/OSXUchrKeyResource.h

@@ -19,12 +19,12 @@ public:
   OSXUchrKeyResource(const void *, uint32_t keyboardType);
 
   // KeyResource overrides
-  virtual bool isValid() const;
+  bool isValid() const override;
-  virtual uint32_t getNumModifierCombinations() const;
+  uint32_t getNumModifierCombinations() const override;
-  virtual uint32_t getNumTables() const;
+  uint32_t getNumTables() const override;
-  virtual uint32_t getNumButtons() const;
+  uint32_t getNumButtons() const override;
-  virtual uint32_t getTableForModifier(uint32_t mask) const;
+  uint32_t getTableForModifier(uint32_t mask) const override;
-  virtual KeyID getKey(uint32_t table, uint32_t button) const;
+  KeyID getKey(uint32_t table, uint32_t button) const override;
 
 private:
   using KeySequence = std::vector<KeyID>;