Merge branch 'master' into SYNERGY-1017-Secure-input-detection-on-mac

# Conflicts:
#	ChangeLog
#	src/gui/src/OSXHelpers.h

.github/workflows/job-test-linux-ubuntu.yml

@@ -17,6 +17,7 @@ jobs:
         include:
           - distro: ubuntu20.04
           - distro: ubuntu19.10
+          - distro: ubuntu21.04
 #          - distro: ubuntu18.04 #Need to install git 2.18+
 #          - distro: ubuntu16.04 #Need to install git 2.18+
 

ChangeLog

@@ -8,10 +8,12 @@ Bug fixes:
 - #7001 Add option to prevent computer from going to sleep
 - #7029 | #7033 Wrong encoding for text copied between linux and windows
 - #7015 Fix Windows service not starting up after sleep
+- #7036 Fix tray icon not changing theme on Big Sur
 
 Enhancements:
 - #6998 Remove functionality related to the screen saver synchronisation
 - #7026 Update the way we package OpenSSL for Windows build
+- #7037 Add Ubuntu 21.04 build
 - #7030 Add user nofication for secure input on Mac
 ===========
 

azure-pipelines.yml

@@ -6,7 +6,7 @@ jobs:
 
   - job: Linux
     pool:
-      vmImage: 'ubuntu-16.04'
+      vmImage: 'ubuntu-latest'
 
     strategy:
       matrix:
@@ -27,6 +27,10 @@ jobs:
           image: symless/synergy-core:ubuntu20.04
           packager: deb
           name: ubuntu20
+        ubuntu2104:
+          image: symless/synergy-core:ubuntu21.04
+          packager: deb
+          name: ubuntu21
         debian9:
           image: symless/synergy-core:debian9
           packager: deb

src/gui/src/MainWindow.cpp

@@ -379,10 +379,19 @@ void MainWindow::setIcon(qSynergyState state) const
     QIcon icon;
 
 #ifdef Q_OS_MAC
-    if (isOSXUseDarkIcons())
+    switch(getOSXIconsTheme()) {
-        icon.addFile(synergyDarkIconFiles[state]);
+        case IconsTheme::ICONS_DARK:
-    else
+            icon.addFile(synergyDarkIconFiles[state]);
-        icon.addFile(synergyLightIconFiles[state]);
+            break;
+        case IconsTheme::ICONS_LIGHT:
+            icon.addFile(synergyLightIconFiles[state]);
+            break;
+        case IconsTheme::ICONS_TEMPLATE:
+        default:
+            icon.addFile(synergyDarkIconFiles[state]);
+            icon.setIsMask(true);
+            break;
+    }
 #else
     icon.addFile(synergyDefaultIconFiles[state]);
 #endif

src/gui/src/OSXHelpers.h

@@ -21,10 +21,16 @@
 
 #include <string>
 
+enum class IconsTheme {
+    ICONS_DARK,
+    ICONS_LIGHT,
+    ICONS_TEMPLATE
+};
+
 bool isOSXSecureInputEnabled();
 int getOSXSecureInputEventPID();
 std::string getOSXProcessName(int pid);
 bool isOSXInterfaceStyleDark();
-bool isOSXUseDarkIcons();
+IconsTheme getOSXIconsTheme();
 
 #endif

src/gui/src/OSXHelpers.mm

@@ -101,13 +101,12 @@ isOSXInterfaceStyleDark()
    return (style && [style isKindOfClass:[NSString class]] && NSOrderedSame == [style caseInsensitiveCompare:@"dark"]);
 }
 
-bool
+IconsTheme
-isOSXUseDarkIcons()
+getOSXIconsTheme()
 {
-   if (@available(macOS 11, *)) {
+   if (@available(macOS 11, *))
-      return true;
+      return IconsTheme::ICONS_TEMPLATE;
-   }
+   else if(isOSXInterfaceStyleDark())
-   else {
+      return IconsTheme::ICONS_DARK;
-      return isOSXInterfaceStyleDark();
+   return IconsTheme::ICONS_LIGHT;
-   }
 }