From c4704649ea74401bffcc404fa97292d00b3eb966 Mon Sep 17 00:00:00 2001
From: sithlord48 <sithlord48@gmail.com>
Date: Mon, 12 May 2025 09:31:19 -0400
Subject: [PATCH] refactor: make sure settings dialog pushes all options to the
 top

---
 src/lib/gui/dialogs/SettingsDialog.cpp |  3 --
 src/lib/gui/dialogs/SettingsDialog.ui  | 39 ++++++++++++++++++++------
 2 files changed, 31 insertions(+), 11 deletions(-)

diff --git a/src/lib/gui/dialogs/SettingsDialog.cpp b/src/lib/gui/dialogs/SettingsDialog.cpp
index 3b625b873..982250cf6 100644
--- a/src/lib/gui/dialogs/SettingsDialog.cpp
+++ b/src/lib/gui/dialogs/SettingsDialog.cpp
@@ -269,9 +269,6 @@ void SettingsDialog::updateControls()
     ui->cbElevateDaemon->setEnabled(writable && serviceChecked);
   } else if (ui->groupService->isVisibleTo(ui->tabAdvanced)) {
     ui->groupService->setVisible(false);
-    const int bottomMargin = ui->tabAdvanced->layout()->contentsMargins().bottom() +
-                             (ui->tabAdvanced->layout()->spacing() * 2) + ui->groupService->height();
-    ui->tabAdvanced->layout()->setContentsMargins(9, 9, 9, bottomMargin);
   }
 
   ui->cbLanguageSync->setEnabled(writable && isClientMode());
diff --git a/src/lib/gui/dialogs/SettingsDialog.ui b/src/lib/gui/dialogs/SettingsDialog.ui
index 1eecc4b1b..fbe627f27 100644
--- a/src/lib/gui/dialogs/SettingsDialog.ui
+++ b/src/lib/gui/dialogs/SettingsDialog.ui
@@ -6,8 +6,8 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>550</width>
-    <height>612</height>
+    <width>549</width>
+    <height>611</height>
    </rect>
   </property>
   <property name="windowTitle">
@@ -284,6 +284,19 @@
             </property>
            </widget>
           </item>
+          <item>
+           <spacer name="verticalSpacer_2">
+            <property name="orientation">
+             <enum>Qt::Orientation::Vertical</enum>
+            </property>
+            <property name="sizeHint" stdset="0">
+             <size>
+              <width>20</width>
+              <height>0</height>
+             </size>
+            </property>
+           </spacer>
+          </item>
          </layout>
         </widget>
        </item>
@@ -303,6 +316,9 @@
        <property name="spacing">
         <number>15</number>
        </property>
+       <property name="topMargin">
+        <number>9</number>
+       </property>
        <item>
         <widget class="QGroupBox" name="groupNetworking">
          <property name="sizePolicy">
@@ -382,12 +398,6 @@
           <string>Logs</string>
          </property>
          <layout class="QGridLayout" name="_3">
-          <property name="topMargin">
-           <number>15</number>
-          </property>
-          <property name="bottomMargin">
-           <number>15</number>
-          </property>
           <property name="verticalSpacing">
            <number>7</number>
           </property>
@@ -573,6 +583,19 @@
          </layout>
         </widget>
        </item>
+       <item>
+        <spacer name="verticalSpacer">
+         <property name="orientation">
+          <enum>Qt::Orientation::Vertical</enum>
+         </property>
+         <property name="sizeHint" stdset="0">
+          <size>
+           <width>20</width>
+           <height>0</height>
+          </size>
+         </property>
+        </spacer>
+       </item>
       </layout>
      </widget>
     </widget>