chore: cleansmells in ArchDaemon

src/lib/arch/ArchDaemonNone.cpp

@@ -21,7 +21,7 @@ void ArchDaemonNone::uninstallDaemon(const char *)
   // do nothing
 }
 
-int ArchDaemonNone::daemonize(const char *name, DaemonFunc func)
+int ArchDaemonNone::daemonize(const char *name, DaemonFunc const &func)
 {
   // simply forward the call to func.  obviously, this doesn't
   // do any daemonizing.

src/lib/arch/ArchDaemonNone.h

@@ -29,7 +29,7 @@ public:
       const char *name, const char *description, const char *pathname, const char *commandLine, const char *dependencies
   ) override;
   void uninstallDaemon(const char *name) override;
-  int daemonize(const char *name, DaemonFunc func) override;
+  int daemonize(const char *name, DaemonFunc const &func) override;
   bool canInstallDaemon(const char *name) override;
   bool isDaemonInstalled(const char *name) override;
   void installDaemon() override;

src/lib/arch/IArchDaemon.h

@@ -88,7 +88,7 @@ public:
     \c ArchMiscWindows::daemonFailed() to indicate startup failure.
   </ul>
   */
-  virtual int daemonize(const char *name, DaemonFunc func) = 0;
+  virtual int daemonize(const char *name, DaemonFunc const &func) = 0;
 
   //! Check if user has permission to install the daemon
   /*!

src/lib/arch/unix/ArchDaemonUnix.cpp

@@ -44,7 +44,7 @@ bool alreadyDaemonized()
 
 #endif
 
-int ArchDaemonUnix::daemonize(const char *name, DaemonFunc func)
+int ArchDaemonUnix::daemonize(const char *name, DaemonFunc const &func)
 {
 #ifdef __APPLE__
   if (alreadyDaemonized())

src/lib/arch/unix/ArchDaemonUnix.h

@@ -20,5 +20,5 @@ public:
   ~ArchDaemonUnix() override = default;
 
   // IArchDaemon overrides
-  int daemonize(const char *name, DaemonFunc func) override;
+  int daemonize(const char *name, DaemonFunc const &func) override;
 };

src/lib/arch/win32/ArchDaemonWindows.cpp

@@ -187,7 +187,7 @@ void ArchDaemonWindows::uninstallDaemon(const char *name)
   }
 }
 
-int ArchDaemonWindows::daemonize(const char *name, DaemonFunc func)
+int ArchDaemonWindows::daemonize(const char *name, DaemonFunc const &func)
 {
   assert(name != nullptr);
   assert(func != nullptr);

src/lib/arch/win32/ArchDaemonWindows.h

@@ -74,7 +74,7 @@ public:
   void uninstallDaemon(const char *name) override;
   void installDaemon() override;
   void uninstallDaemon() override;
-  int daemonize(const char *name, DaemonFunc func) override;
+  int daemonize(const char *name, DaemonFunc const &func) override;
   bool canInstallDaemon(const char *name) override;
   bool isDaemonInstalled(const char *name) override;
   std::string commandLine() const