smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Remove unnecessary log line endings and trimming

Browse source
This commit is contained in:
Nick Bolton 2025-04-07 10:43:46 +01:00
parent 84ae597d69
commit d740574bd4
2 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/lib/gui/Logger.cpp
View file

@ -32,10 +32,8 @@ QString printLine(FILE *out, const QString &type, const QString &message, const
auto logLine = QString("[%1] %2: %3").arg(datetime, type, message); auto logLine = QString("[%1] %2: %3").arg(datetime, type, message);
QTextStream stream(&logLine); QTextStream stream(&logLine);
stream << Qt::endl;
if (!fileLine.isEmpty()) { if (!fileLine.isEmpty()) {
stream << "\t" + fileLine << Qt::endl; stream << "\n\t" + fileLine;
} }
auto logLineBytes = logLine.toUtf8(); auto logLineBytes = logLine.toUtf8();

5
src/lib/gui/MainWindow.cpp
View file

@ -729,9 +729,8 @@ void MainWindow::handleLogLine(const QString &line)
int maxScroll = verticalScroll->maximum(); int maxScroll = verticalScroll->maximum();
const auto scrollAtBottom = qAbs(currentScroll - maxScroll) <= kScrollBottomThreshold; const auto scrollAtBottom = qAbs(currentScroll - maxScroll) <= kScrollBottomThreshold;
// only trim end instead of the whole line to prevent tab-indented debug // Never trim the log line; doing so would hide underlying bugs where newlines and space is added unintentionally.
// filenames from losing their indentation. ui->textLog->appendPlainText(line);
ui->textLog->appendPlainText(line.trimmed());
if (scrollAtBottom) { if (scrollAtBottom) {
verticalScroll->setValue(verticalScroll->maximum()); verticalScroll->setValue(verticalScroll->maximum());