smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: Simplify CoreProcess::QuoteArgs, use QString::Simplify and simplify logic in the loop

Browse source
This commit is contained in:
sithlord48 2025-10-05 08:48:52 -04:00 committed by Chris Rizzitello
parent bb1e2ecc78
commit e3f940c70a
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/lib/gui/core/CoreProcess.cpp
View file

@ -79,20 +79,21 @@ QString processStateToString(CoreProcess::ProcessState state)
*/
QString CoreProcess::makeQuotedArgs(const QString &app, const QStringList &args)
{
QStringList command;
command << app;
command << args;
QStringList command = {app};
command.append(args);
static const auto quote = QStringLiteral("\"");
static const auto space = QStringLiteral(" ");
QStringList quoted;
for (const auto &arg : std::as_const(command)) {
if (arg.contains(' ')) {
quoted << QString("\"%1\"").arg(arg);
} else {
quoted << arg;
for (const auto &item : std::as_const(command)) {
auto temp = item.simplified();
if (const auto wrapped = (temp.startsWith(quote) && temp.endsWith(quote)); temp.contains(space) && !wrapped) {
temp = QStringLiteral("%1%2%1").arg(quote, temp);
}
quoted.append(temp);
}
return quoted.join(" ");
return quoted.join(space);
}
/**