refactor: make NetworkMonitor::validAddresses static

This commit is contained in:
sithlord48 2026-02-23 21:07:10 -05:00 committed by Nick Bolton
parent 37728cc7a3
commit f69bd5601c
4 changed files with 6 additions and 6 deletions

View file

@ -395,7 +395,7 @@ void MainWindow::startCore()
{ {
// Save current IP state when server starts // Save current IP state when server starts
if (m_coreProcess.mode() == CoreMode::Server && Settings::value(Settings::Core::Interface).toString().isEmpty()) { if (m_coreProcess.mode() == CoreMode::Server && Settings::value(Settings::Core::Interface).toString().isEmpty()) {
m_serverStartIPs = m_networkMonitor->validAddresses(); m_serverStartIPs = NetworkMonitor::validAddresses();
m_serverStartSuggestedIP = m_serverStartIPs.isEmpty() ? "" : m_serverStartIPs.first(); m_serverStartSuggestedIP = m_serverStartIPs.isEmpty() ? "" : m_serverStartIPs.first();
} }
@ -585,7 +585,7 @@ void MainWindow::updateSecurityIcon(bool visible)
void MainWindow::updateNetworkInfo() void MainWindow::updateNetworkInfo()
{ {
updateIpLabel(m_networkMonitor->validAddresses()); updateIpLabel(NetworkMonitor::validAddresses());
} }
void MainWindow::serverConnectionConfigureClient(const QString &clientName) void MainWindow::serverConnectionConfigureClient(const QString &clientName)

View file

@ -52,7 +52,7 @@ void NetworkMonitor::stopMonitoring()
m_isMonitoring = false; m_isMonitoring = false;
} }
QStringList NetworkMonitor::validAddresses() const QStringList NetworkMonitor::validAddresses()
{ {
QList<QHostAddress> physicalIP4; QList<QHostAddress> physicalIP4;
QList<QHostAddress> physicalIP6; QList<QHostAddress> physicalIP6;

View file

@ -50,7 +50,7 @@ public:
* @brief Get list of all available IP addresses (excluding local and link-local addresses) * @brief Get list of all available IP addresses (excluding local and link-local addresses)
* @return IP address list * @return IP address list
*/ */
QStringList validAddresses() const; static QStringList validAddresses();
/** /**
* @brief Check if a network interface is virtual * @brief Check if a network interface is virtual

View file

@ -55,8 +55,8 @@ SettingsDialog::SettingsDialog(QWidget *parent, const IServerConfig &serverConfi
ui->tabWidget->setCurrentIndex(0); ui->tabWidget->setCurrentIndex(0);
// Populate the list of IP addresses // Populate the list of IP addresses
NetworkMonitor networkMonitor(this); const auto validAddresses = NetworkMonitor::validAddresses();
for (const auto &address : networkMonitor.validAddresses()) { for (const auto &address : validAddresses) {
QString ipString = address; QString ipString = address;
if (ui->comboInterface->findText(ipString) == -1) { if (ui->comboInterface->findText(ipString) == -1) {
ui->comboInterface->addItem(ipString, ipString); ui->comboInterface->addItem(ipString, ipString);