From f9b93210ed364e4a16ff8abd88facde71176aa8b Mon Sep 17 00:00:00 2001 From: Nick Bolton Date: Mon, 29 Jul 2024 23:46:49 +0100 Subject: [PATCH] Add TODO for S1-1767 (lock order reversal) --- src/lib/arch/unix/ArchMultithreadPosix.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/arch/unix/ArchMultithreadPosix.cpp b/src/lib/arch/unix/ArchMultithreadPosix.cpp index c000a42e7..2ae0cad15 100644 --- a/src/lib/arch/unix/ArchMultithreadPosix.cpp +++ b/src/lib/arch/unix/ArchMultithreadPosix.cpp @@ -287,6 +287,8 @@ void ArchMultithreadPosix::lockMutex(ArchMutex mutex) { } void ArchMultithreadPosix::unlockMutex(ArchMutex mutex) { + // TODO: S1-1767, we should use raii c++17 mutex instead of archaeic pthread + // to solve possible lock order reversal. int status = pthread_mutex_unlock(&mutex->m_mutex); switch (status) {