From fe29194b64277c425af13bcf67bc1d24e6d30c95 Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Tue, 4 Aug 2026 11:23:29 -0400 Subject: [PATCH] refactor: remove report issue link from menu users should find it via help --- src/apps/res/deskflow.qrc | 6 ------ .../deskflow-dark/actions/16/tools-report-bug.svg | 7 ------- .../deskflow-dark/actions/22/tools-report-bug.svg | 7 ------- .../deskflow-dark/actions/24/tools-report-bug.svg | 8 -------- .../deskflow-light/actions/16/tools-report-bug.svg | 13 ------------- .../deskflow-light/actions/22/tools-report-bug.svg | 14 -------------- .../deskflow-light/actions/24/tools-report-bug.svg | 12 ------------ src/lib/gui/MainWindow.cpp | 12 ------------ src/lib/gui/MainWindow.h | 2 -- translations/deskflow_es.ts | 4 ---- translations/deskflow_it.ts | 4 ---- translations/deskflow_ja.ts | 4 ---- translations/deskflow_ko.ts | 4 ---- translations/deskflow_ru.ts | 4 ---- translations/deskflow_zh_CN.ts | 4 ---- 15 files changed, 105 deletions(-) delete mode 100644 src/apps/res/icons/deskflow-dark/actions/16/tools-report-bug.svg delete mode 100644 src/apps/res/icons/deskflow-dark/actions/22/tools-report-bug.svg delete mode 100644 src/apps/res/icons/deskflow-dark/actions/24/tools-report-bug.svg delete mode 100644 src/apps/res/icons/deskflow-light/actions/16/tools-report-bug.svg delete mode 100644 src/apps/res/icons/deskflow-light/actions/22/tools-report-bug.svg delete mode 100644 src/apps/res/icons/deskflow-light/actions/24/tools-report-bug.svg diff --git a/src/apps/res/deskflow.qrc b/src/apps/res/deskflow.qrc index 1e108cc55..59d488047 100644 --- a/src/apps/res/deskflow.qrc +++ b/src/apps/res/deskflow.qrc @@ -13,7 +13,6 @@ icons/deskflow-dark/actions/16/process-stop.svg icons/deskflow-dark/actions/16/system-run.svg icons/deskflow-dark/actions/16/system-search.svg - icons/deskflow-dark/actions/16/tools-report-bug.svg icons/deskflow-dark/actions/16/view-close.svg icons/deskflow-dark/actions/16/view-refresh.svg icons/deskflow-dark/actions/16/window-minimize-pip.svg @@ -33,7 +32,6 @@ icons/deskflow-dark/actions/22/question.svg icons/deskflow-dark/actions/22/system-run.svg icons/deskflow-dark/actions/22/system-search.svg - icons/deskflow-dark/actions/22/tools-report-bug.svg icons/deskflow-dark/actions/22/view-close.svg icons/deskflow-dark/actions/22/view-refresh.svg icons/deskflow-dark/actions/22/window-minimize-pip.svg @@ -54,7 +52,6 @@ icons/deskflow-dark/actions/24/question.svg icons/deskflow-dark/actions/24/system-run.svg icons/deskflow-dark/actions/24/system-search.svg - icons/deskflow-dark/actions/24/tools-report-bug.svg icons/deskflow-dark/actions/24/view-close.svg icons/deskflow-dark/actions/24/view-refresh.svg icons/deskflow-dark/actions/24/window-minimize-pip.svg @@ -99,7 +96,6 @@ icons/deskflow-light/actions/16/process-stop.svg icons/deskflow-light/actions/16/system-run.svg icons/deskflow-light/actions/16/system-search.svg - icons/deskflow-light/actions/16/tools-report-bug.svg icons/deskflow-light/actions/16/view-close.svg icons/deskflow-light/actions/16/view-refresh.svg icons/deskflow-light/actions/16/window-minimize-pip.svg @@ -120,7 +116,6 @@ icons/deskflow-light/actions/22/question.svg icons/deskflow-light/actions/22/system-run.svg icons/deskflow-light/actions/22/system-search.svg - icons/deskflow-light/actions/22/tools-report-bug.svg icons/deskflow-light/actions/22/view-close.svg icons/deskflow-light/actions/22/view-refresh.svg icons/deskflow-light/actions/22/window-minimize-pip.svg @@ -141,7 +136,6 @@ icons/deskflow-light/actions/24/question.svg icons/deskflow-light/actions/24/system-run.svg icons/deskflow-light/actions/24/system-search.svg - icons/deskflow-light/actions/24/tools-report-bug.svg icons/deskflow-light/actions/24/view-close.svg icons/deskflow-light/actions/24/view-refresh.svg icons/deskflow-light/actions/24/window-minimize-pip.svg diff --git a/src/apps/res/icons/deskflow-dark/actions/16/tools-report-bug.svg b/src/apps/res/icons/deskflow-dark/actions/16/tools-report-bug.svg deleted file mode 100644 index 1a3dc89fc..000000000 --- a/src/apps/res/icons/deskflow-dark/actions/16/tools-report-bug.svg +++ /dev/null @@ -1,7 +0,0 @@ - - - - - - - diff --git a/src/apps/res/icons/deskflow-dark/actions/22/tools-report-bug.svg b/src/apps/res/icons/deskflow-dark/actions/22/tools-report-bug.svg deleted file mode 100644 index d0249a177..000000000 --- a/src/apps/res/icons/deskflow-dark/actions/22/tools-report-bug.svg +++ /dev/null @@ -1,7 +0,0 @@ - - - - - - - diff --git a/src/apps/res/icons/deskflow-dark/actions/24/tools-report-bug.svg b/src/apps/res/icons/deskflow-dark/actions/24/tools-report-bug.svg deleted file mode 100644 index 5a700d527..000000000 --- a/src/apps/res/icons/deskflow-dark/actions/24/tools-report-bug.svg +++ /dev/null @@ -1,8 +0,0 @@ - - - - - - - - diff --git a/src/apps/res/icons/deskflow-light/actions/16/tools-report-bug.svg b/src/apps/res/icons/deskflow-light/actions/16/tools-report-bug.svg deleted file mode 100644 index 4f41ad6b8..000000000 --- a/src/apps/res/icons/deskflow-light/actions/16/tools-report-bug.svg +++ /dev/null @@ -1,13 +0,0 @@ - - - - - - diff --git a/src/apps/res/icons/deskflow-light/actions/22/tools-report-bug.svg b/src/apps/res/icons/deskflow-light/actions/22/tools-report-bug.svg deleted file mode 100644 index 113a02f80..000000000 --- a/src/apps/res/icons/deskflow-light/actions/22/tools-report-bug.svg +++ /dev/null @@ -1,14 +0,0 @@ - - - - - - diff --git a/src/apps/res/icons/deskflow-light/actions/24/tools-report-bug.svg b/src/apps/res/icons/deskflow-light/actions/24/tools-report-bug.svg deleted file mode 100644 index 840ef2ab3..000000000 --- a/src/apps/res/icons/deskflow-light/actions/24/tools-report-bug.svg +++ /dev/null @@ -1,12 +0,0 @@ - - - - - - - - diff --git a/src/lib/gui/MainWindow.cpp b/src/lib/gui/MainWindow.cpp index fbe64780e..4c83f21d8 100644 --- a/src/lib/gui/MainWindow.cpp +++ b/src/lib/gui/MainWindow.cpp @@ -71,7 +71,6 @@ MainWindow::MainWindow() m_menuHelp{new QMenu(this)}, m_actionAbout{new QAction(this)}, m_actionClearSettings{new QAction(this)}, - m_actionReportBug{new QAction(this)}, m_actionMinimize{new QAction(this)}, m_actionQuit{new QAction(this)}, m_actionTrayQuit{new QAction(this)}, @@ -123,9 +122,6 @@ MainWindow::MainWindow() m_actionStopCore->setIcon(QIcon::fromTheme(QIcon::ThemeIcon::ProcessStop)); m_actionStopCore->setMenuRole(QAction::NoRole); - m_actionReportBug->setIcon(QIcon::fromTheme(QStringLiteral("tools-report-bug"))); - m_actionReportBug->setMenuRole(QAction::NoRole); - m_actionShowHelp->setIcon(QIcon::fromTheme(QStringLiteral("question"))); m_actionShowHelp->setMenuRole(QAction::NoRole); @@ -264,7 +260,6 @@ void MainWindow::connectSlots() connect(m_actionAbout, &QAction::triggered, this, &MainWindow::openAboutDialog); connect(m_actionClearSettings, &QAction::triggered, this, &MainWindow::clearSettings); - connect(m_actionReportBug, &QAction::triggered, this, &MainWindow::openHelpUrl); connect(m_actionMinimize, &QAction::triggered, this, &MainWindow::hide); connect(m_actionQuit, &QAction::triggered, this, &MainWindow::close); @@ -472,11 +467,6 @@ void MainWindow::openAboutDialog() about.exec(); } -void MainWindow::openHelpUrl() const -{ - QDesktopServices::openUrl(QUrl(kUrlHelp)); -} - void MainWindow::openGetNewVersionUrl() const { QDesktopServices::openUrl(QUrl(kUrlDownload)); @@ -685,7 +675,6 @@ void MainWindow::createMenuBar() m_menuHelp->addAction(m_actionAbout); m_menuHelp->addAction(m_actionShowHelp); - m_menuHelp->addAction(m_actionReportBug); m_menuHelp->addSeparator(); m_menuHelp->addAction(m_actionClearSettings); @@ -1072,7 +1061,6 @@ void MainWindow::updateText() m_menuHelp->setTitle(tr("&Help")); m_actionClearSettings->setText(tr("Clear settings")); - m_actionReportBug->setText(tr("Report a Bug")); m_actionMinimize->setText(tr("&Minimize to tray")); m_actionQuit->setText(tr("&Quit")); m_actionTrayQuit->setText(tr("&Quit")); diff --git a/src/lib/gui/MainWindow.h b/src/lib/gui/MainWindow.h index 506fd35a1..c8b1ea8d4 100644 --- a/src/lib/gui/MainWindow.h +++ b/src/lib/gui/MainWindow.h @@ -96,7 +96,6 @@ private: void clearSettings(); void openAboutDialog(); - void openHelpUrl() const; void openGetNewVersionUrl() const; void openSettings(); void startCore(); @@ -195,7 +194,6 @@ private: // Window Actions QAction *m_actionAbout = nullptr; QAction *m_actionClearSettings = nullptr; - QAction *m_actionReportBug = nullptr; QAction *m_actionMinimize = nullptr; QAction *m_actionQuit = nullptr; QAction *m_actionTrayQuit = nullptr; diff --git a/translations/deskflow_es.ts b/translations/deskflow_es.ts index 078974783..44fa647ff 100644 --- a/translations/deskflow_es.ts +++ b/translations/deskflow_es.ts @@ -384,10 +384,6 @@ Do you want to connect to the server? Clear settings Borrar configuración - - Report a Bug - Informar un error - &Minimize to tray &Minimizar a la bandeja diff --git a/translations/deskflow_it.ts b/translations/deskflow_it.ts index 141454c53..f224fe1b2 100644 --- a/translations/deskflow_it.ts +++ b/translations/deskflow_it.ts @@ -372,10 +372,6 @@ Vuoi connetterti al server? Clear settings Cancella impostazioni - - Report a Bug - Segnala un Bug - &Minimize to tray &Minimizza a icona diff --git a/translations/deskflow_ja.ts b/translations/deskflow_ja.ts index 5203a65f7..093d30e8e 100644 --- a/translations/deskflow_ja.ts +++ b/translations/deskflow_ja.ts @@ -486,10 +486,6 @@ A bound IP is now invalid, you may need to restart the server. Clear settings 設定を消去 - - Report a Bug - バグレポート - &Minimize to tray トレイに最小化(&M) diff --git a/translations/deskflow_ko.ts b/translations/deskflow_ko.ts index 1319918f0..ce2c0116f 100644 --- a/translations/deskflow_ko.ts +++ b/translations/deskflow_ko.ts @@ -486,10 +486,6 @@ A bound IP is now invalid, you may need to restart the server. Clear settings 설정 초기화 - - Report a Bug - 버그 신고 - &Minimize to tray 트레이로 최소화(&M) diff --git a/translations/deskflow_ru.ts b/translations/deskflow_ru.ts index 8773dea82..678dd0171 100644 --- a/translations/deskflow_ru.ts +++ b/translations/deskflow_ru.ts @@ -486,10 +486,6 @@ A bound IP is now invalid, you may need to restart the server. Clear settings Сбросить настройки - - Report a Bug - Сообщить об ошибке - &Minimize to tray &Свернуть в трей diff --git a/translations/deskflow_zh_CN.ts b/translations/deskflow_zh_CN.ts index 074eef431..d4ad6eb36 100644 --- a/translations/deskflow_zh_CN.ts +++ b/translations/deskflow_zh_CN.ts @@ -486,10 +486,6 @@ A bound IP is now invalid, you may need to restart the server. Clear settings 清除设置 - - Report a Bug - 报告 Bug - &Minimize to tray 最小化到托盘(&M)