- Use `PIPE_NOWAIT` to skip empty stderr output on process output reading from Windows daemon watchdog
- Use `CreateProcess` result to determine when to call `CloseHandle` in Windows daemon watchdog
- Trim output from active desktop process in Windows daemon watchdog
- Improve error logging in Windows daemon watchdog
The options argument was missing so the argument data wasn't the right
one and the method cb_disabled was actually called on a GVariant*
instead on a PortalInputCapture*
This change may help us turn up some everyday problems in the field that get missed due to not using debug log level.
This could also make the log a bit noisier, so at a later date we may need to downgrade anything that is not actually a failure/warning.
On Windows monitor the clipboard using a Clipboard format listener instead
of the legacy clipboard viewer chain, which was unreliable as it required
other programs to maintain the clipboard chain properly and couldn't
recover it any window in the clipboard viewer chain stopped responding
to messages.
Monitor the clipboard sequence number to not process the clipboard more
than once.
* Bump CI
* Use 2 core arm runner
* Update ChangeLog
* Fixed filename `deskflowc.exe.manifest`
* Remove .vscode/settings.json file
* Restore test values to make tests work (test values should not contain app name)
* Fixed syntax error in Windows watchdog
* Add `sonar-project.properties` file
* Change default core count
* Add default package prefix
* Default product name in CMake
* Tweak ChangeLog
* Use Deskflow Name
* Remove business-oriented options from issue templates
* Remove business-oriented workflow
* Bump version to 3.0.0 (to avoid confusion with previously used version numbers 1.x & 2.x)
* Update readme to reflect new project name and goals
* Found some more "synergy" to rename
* Rename `synlib` to `app`
* Rename `syntool` to `deskflow-legacy`
* Rename `synwinhk` to `dfwhook`
* Rename dirs from synergy to deskflow
* Rename more "Synergy" files
* Rename app bundle ID
* Fixed copyright typo
* Rename only title in serial key dialog (to be moved downstream later)
* Preserve original serial key window for moving downstream
* Restore dialogs ready for moving downstream
* Rename `QDeskflowApplication` to `DeskflowApplication` (the Q is confusing)
* Restore Volker's original project name
* Fixed mimetype
* Fixed weird grammar
* Fixed (more) weird grammar
* Broken link, restoring (but we should move all links out of source)
* Broken link, restoring (but we should move all links out of source)
* Add write permission to valgrind-analysis.yml
* Restore AUR conflicts
* Apply Clang format
* Update ChangeLog
* Back out version change
---------
Co-authored-by: Nick Bolton <nick@symless.com>
* Add warnings for libei and libportal
* Add warning about experimental Wayland support
* Update ChangeLog
* Move GUI res files to root res dir
* Fixed crazy qrc shenanigans
* Move Wayland warning logic, add tests, improve core retry
* Also install py modules with pip since meson can be in venv
* Throw error when no libei
* Add warnings when no libportal
* Allow failure then success to show related to Wayland (for switching modes)
* Fixed formatting
* Fixed includes
* Simplify warning message
* Add log hint
* Show warning when error already shown
* Only check for Wayland if X or libei
* Add error message when quitting dur to remote desktop error
* Improve consistency of portal log lines
* Add experimental BSD job to CI
* Remove container
* cd into ` synergy/synergy/`
* Change unix to bsd
* Use only run param and not prepare
* Install python3 on FreeBSD
* Add missing command to prepare param
* Add all the Unix-like BSD-derived
* Use latest python3 for NetBSD and DragonFly BSD
* Use env for cmd and correct prepare commands
* Add deps config for unix-like
* Install Python deps on Unix-like
* Return matching entry in `get_unix_like_os`
* Add cmake dep for cmakelang py module
* Back out Unix-like support in `install_deps.py` (Python is tricky on BSD)
* Back out BSD from config
* Create install_deps.sh script for BSD-derived
* Use .sh script instead of .py for BSD-derived
* Add other case and fixed syntax
* Use /usr/bin/env
* Use more available sh
* Restore debian command
* Fixed syntax error
* Remove prepare args
* Remove space
* Use which instead of command
* Add libX11 dep
* Add other BSD-derivatives
* Set CMAKE_REQUIRED_INCLUDES
* Fixed bad separator for CMAKE_REQUIRED_INCLUDES
* Add debug lines
* Set CMAKE_REQUIRED_LIBRARIES to lib names
* use CMAKE_REQUIRED_QUIET
* Set CMAKE_REQUIRED_FLAGS for BSD
* Message for BSD packaging
* Make PKG_CONFIG_FOUND optional
* Move debug to all OS
* Remove solaris for now, too many missing packages
* Add missing override to XWindowsScreen.h
* Add PC_GLIB_INCLUDE_DIRS
* Fixed glib include
* Make libnotify optional
* Set CMAKE_LIBRARY_PATH
* Only run tests if toml++ available
* Also run integ tests
* Remove DragonFly (C++ version too old)
* Fixed NetBSD command
* Aww sucks. Well, I tried. Patches welcome
* Update ChangeLog
* Fixed README for OpenBSD, NetBSD, DragonFly BSD, Solaris
* Add missing case for SunOS
* Drop redundant virtual specifiers
* Print libs on FreeBSD
* Restore link_directories
* Beef up to ubuntu-24.04-16-core-x64, export QT_QPA_PLATFORM, improve comment
* Remove debug line
* Simplify debug text
* Restore ubuntu-latest
* Fixed really stupid typo
* Beef up with ubuntu-22.04-16-core-x64
* Revert "Beef up with ubuntu-22.04-16-core-x64"
This reverts commit 3de5773ef6c6eea99b93d3ee8448b0b95dc00dde.
* Add missing name
* Make .sh file primary deps file
* Tweaked deps instruction label
* Add libei and libportal
* Port libei and libportal code by Peter Hutterer and Olivier Fourdan
* Add Peter Hutterer and Olivier Fourdan to important devs list
* Improve error handling for libei and libportal builds
* Checkout libportal tags/0.7.1
* Hack out the gi-docgen clone
* Remove new submodules in favor of using ExternalProject_Add
* Remove submodule dirs
* Use ExternalProject_Add instead of submodules
* Fixed namespace
* Hack to work around type libportal causing type conflicts
* Add log helper functions
* Use original log functions
* Switch to FetchContent, use libportal a1530a9 (unreleased) and use camelCase member names for consistency
* Restore a few events (much more work required)
* Add TODOs for supporting multiple lib versions
* Revert "Switch to FetchContent, use libportal a1530a9 (unreleased) and use camelCase member names for consistency"
This reverts commit 610cebb5b6a08282eee68f4424fcdbe9eaab4bf9.
* Simplify cmake config by removing builds for libei and libportal (will do this in `install_deps.py` instead)
* Remove submodules
* Remove .gitmodules
* Use meson to build subprojects
* Update copyright with Peter Hutterer's guidance
* Use meson for installing deps
* Fixed typo in tag name
* Remove submodules
* Remove old submodules
* Fixed libei name
* Defaults for pugixml and gtest depending on whether source exists in subprojects
* Ignore some subproject dirs
* Make deps OS-specific
* Move python deps to pyproject
* Only compile and install on Linux with Meson
* Revert "Move python deps to pyproject"
This reverts commit 92c8a287b8376a4d166058c85f1d6081f6fdb423.
* Add ninja to brewfile
* Add python3-attr
* Restore original coverage config
* Add ninja for meson
* Include meson in same try-except
* Fixed ninja dep name
* Move libs to correct oS
* Fixed include for wintoast
* Disable docs for libportal
* More options for libei and libportal
* Fixed option for libei
* Use ninja directly to install
* Revert "Use ninja directly to install"
This reverts commit c926d78ba483406a55acd10fb157c39e13f90b71.
* Meson install verbose
* Prints stdout/stderr
* Remove `from None`
* Remove submodules that somehow crept back in?!
* Prepend sudo if exists
* Add libei deps for all distros
* Fixed Fedora package name
* Add more deps for other distros
* Add more libs (including pugixml)
* Fix lib name
* Drop -u from pacman
* Add vala to rhel
* Make libportal optional
* Make portal link optional
* Remove example code
* Always use system pugixml
* Disable interactive apt through install_deps.py
* Revert "Disable interactive apt through install_deps.py"
This reverts commit 5bbc8fd689182447c79b81db16c961b98361a292.
* Set DEBIAN_FRONTEND in workflows
* Set DEBIAN_FRONTEND in CodeQL workflow
* Add gtest dep
* Add bundled libei dep
* Add libei dep to Arch
* Use `googletest` on openSUSE
* Add gmock dep
* Remove gtest dep from openSUSE
* Add libei on Fedora
* Bundle libei for older Linux distros
* Disable libei dep for RPM
* Also bundle symlink to .so
* Use ${CMAKE_INSTALL_LIBDIR}
* Rename libei to fix openSUSE
* List installed files
* Add libei-devel to openSUSE
* Add googletest-devel to openSUSE
* Remove manual deps (probably resolved automatically)
* Remove googletest from openSUSE (doesn't provide google mock)
* Only add Portal* if libportal found
* WIP - Partial work on using old events system :'(
* Add deps install commands for subprojects
* Solved more compile issues related to events system, threads, etc
* Fixed bad config for adding x, ei, portal sources
* Remove redundant deps
* Remove (another) redundant dep
* Fixed pacman command
* Add Ubuntu and Linux Mint libei deps
* Fixed Ubuntu and Linux Mint libei deps aliases
* Only iterate subprojects if not None
* Add rhel, rocky, and alma for libei
* Make rhel-like deps same as fedora again
* Build libportal on rhel-like
* Re-enable meson rhel-like for libportal
* Remove dbus-python
* Make libportal optional (for rhel-like)
* Handle ei event queue results
* Re-introduce libportal
* Print libei and libportal versions
* Add ei/portal args and client screen
* Switch --use args to --no
* Don't build libei/libportal on older distros as it's pointless
* Make libei and libportal optional
* Add Debian 13 runner
* Make some packages optional
* Remove subprojects
* Improve comment
* Add comment for libportal
* Improve comment
* Add Debian 13 runner
* Make optional... optional
* Change continuation stripper to remove newline and continuation char
* Make command strip more uniform
* Fixed help var syntax
* Fixed libei linking
* Ensure `kHelpNoWayland` is always defined
* Improve help message
* Fixed Debian 13 runner name
* Include sstream and use const var
* Update ChangeLog
* Remove Wayland block
* Return new timer
* Make tray icon logging verbose
* Fixed arg parser for wayland args
* Fixed init of EI screen
* Fixed lint issues
* Update README to indicate Wayland support in GNOME 46
* Add missing word
* Fixed comment positions
* Automate CI env
* Tone down debug log messages
* Add missing comma
* Remove redundant log line
* Load .env from app dir
* Use `OutputDebugStringA` on Windows
* Improved string manipulation in logger and better use of OutputDebugStringA
* Use noquote for path
* Apply TLS setting after activation
* Restart after activation
* Move skip debug message to correct place
* Only print settings path on create, not shown
* Merge common and global libs
* Reduce code duplication around constants, version, etc
* Simplify sprintf code
* Use snprintf
* Add error test menu
* Coverage for dotenv
* Coverage for Logger
* Add missing include
* Add init when no Git SHA
* Update ChangeLog
* Add spellings
* Set debugging on for release build
* Remove unused variable
* Remove bad comment
* Fixed copyright date
* Remove import
* Move URL const back to GUI
* Remove dead code and duplication
* Fixed/ignored lint warnings
* Move integ test to corredt place and re-enable tests
* Depend on `poll.h` (removes support for non-POSIX systems)
* Only build tests for each arch
* Move back to unit tests (poll is mocked)
* Better error message for valgrind not found
* Simplify dependency injection for BSD sockets poll test
* Improve test readability for BSD net poll
* Split out 2-in-1 test for `isAnyAddr`
* Stub out sleep function
* Improve coverage for pollSocket
* Use gmock ON_CALL instead of manual mock
* Remove unused function signature
* Use conventional deps struct instead of std functional
* Add test for socket data FD set to -1
* Add assertation for adding unblock pipe
* Use older style array alloc
* Less precision around `getNetworkDataForThread` value
* Use `ssize_t` for `ignore`
* Remove unused var
* Update ChangeLog
* Rename `LicenseManager` to `License`
* Rename `LicenseManager` to `License`
* Move License class to gui lib
* Rename license related classes
* Refactor serial key parsing
* Don't fail fast on containers
* Move licensed product name from config to code
* Fixed formatting
* Update code coverage generator and fixed args
* WIP: Converting license to chrono
* WIP: Fixed compile errors, tests failing
* Fixed all serial key and license tests
* Disable verbose logging
* Add missing </p>
* Add missing include
* Revert code coverage config
* Handle parse errors
* Move more classes into the new gui lib and improve license/serial object ownership
* WIP: Fixing signal/slots in MainWindow
* Fixed slot for about to quit
* Rename manual slots to solve auto-connection warnings
* Fixed logging issue
* By default, don't close to tray
* Add .env support and furthe refactor license code, also fixed some copyright dates
* Remove test code
* Fixed memory error in .env parser and refactor more licensing display code
* Fixed color inconsistencies
* Fixed link colors and made log view expand
* Disable server components rather than hiding
* Reset years of blind UI layout fiddling
* Fixed clean Qt task
* Only show notice when time limited
* Fixed main window layout
* Show connected clients
* Set 15 spacing
* Auto connect on start
* More intentional screen size
* Fixed tests related to license
* Tests for expiry notifications
* Reorg tests and remove death test
* Update gtest
* Tests for dotenv parser
* Test command process
* What the heck is that doing there?
* Merge constants headers
* Fixed magic includes
* Remove helper function
* Remove comment
* Remove extern decl
* Update ChangeLog
* Add missing atom ctor init
* Init members with `None`
* Use in-class init and delcare getter inside if init
* Temp revert of changes ahead of unit test repair
* Move IPC header to shared, restore X clipboard test, simplify test cmake, new X clipboard unit test
* Suppress sonar for undefs
* Remove base dir include
* Revert "Temp revert of changes ahead of unit test repair"
This reverts commit 8f84b6ea5d5828f1be1362de3809279bcacb8cc8.
* Use new accessor
* Use default dtor
* Beef up to 32 core
* Use enum class
* Make IPC protocol headers const at all levels
* Use enum class and const char for better type safety
* Use unique_ptr for m_clipboard
* Use `-j` instead of `-j8` to utilize full parallelism
* Increase thread count for sonar-scanner
* Use 32 threads
* Use in-class init for IpcClientProxy members
* Use const instead of #define
* Remove ctor member inits
* Use unique_ptr on win
* Implement temp bin dir for windows with more robust post-build copy
* Fixed missing iostream
* Add warning about copy errors
* Only run clean-gcda on Linux
* Use in-class init for IPC mutex
* Do no-op on Windows
* Hide clean-gcda task
* Move flakey test to integtests
* Delete dead code
* Test
* Temp disable post_config_all
* Disable post config step
* Revert "Disable post config step"
This reverts commit 2f956a7714ba9bedacd4b39d4ae00940c3d565d6.
* Revert "Temp disable post_config_all"
This reverts commit b44ed72e44f838bfe1309f6e9672d2f1c6f21b75.
* Restore -j8
* Simplify error handling
* Use const for test port
* Remove python check
* Update changelog
* Fixed order
* Fixed bad issue number
* Fixed bin copy source path
* Remove redundant except
* Turn off alignment of params
* Apply Clang format
* Change AlignAfterOpenBracket to AlwaysBreak and add extra bin pack settings
* Restore default bin packing
* Apply format
* Test: allocLockCursorToScreenInfo_withState_setsState
* Merge remote-tracking branch 'origin/master' into S1-1717-sonarcloud-issues
* Remove header wrappers for gmock/gtest
* Convenience wrapper script for tests
* Use `std::copy` instead of `strcpy`
* Use `std::ranges::copy` instead of `stdcpy`
* Delete dead code
* Add guitests VS Code config and test wrapper
* Revert "Delete dead code"
This reverts commit aa40f5cd35a22b4b69acfd1876aceea053088060.
* Build guitests with CMake
* Run all tests
* Don't use --gtest_filter for Qt tests
* Undo skip for GUI tests
* Coverage for `IpcClient::sendCommand`
* Remove provider and proxy
* Use lamda for StreamProvider to reduce boilerplate
* Restore version checker tests
* Remove activation souces
* Tasks for current/all tests
* Change command for tasks
* Mock QNetworkAccessManager
* Create core app to satisfy Qt assertations
* Use `std::copy` instead of `std::ranges::copy`
* Remove integtests
* Merge guitests into unittests
* Use std::string::length
* Remove include (resolves to root)
* Fix memory leaks
* Disable sigsegv tests
* Fixed formatting
* Remove guitests from CI
* New MainWindowTests
* Passing test for MainWindowTests
* Use alternative to strlen in MainWindow::checkSecureSocket
* Passing test for Log::print
* Fixed dtor call order
* Fixed var name typo
* Use proxy instead of `#define protected public`
* Add args test for log
* Add license ctor
* Fixed log test for release
* Add error log test
* Init qt with -platform offscreen
* Back-out initQt function
* Use QT_QPA_PLATFORM
* Try QT_QPA_PLATFORM=offscreen
* Use more readable env node
* Set QT_QPA_PLATFORM in CI and CodeQL
* Remove env not needed
* Modernize Log::print
* Calculate the length of the format string fmt during the initial scan loop
* More direct and efficient alterative to `strlen`
* Fixed major maint issues in AppConfig
* New clang and cmake rules
* Set `max_pargs_hwrap` to 4
* Undo clang format for now
* Fix missing `Setting::`
* Fixed missing `m_S` on Windows
* Re-add accidental dep resolution (fix later)
* Fixed missing buffer position increment
* Turn on errors
* Fixed tests and improve error message
* Fixed segfault on log refactor
* Extract log time to function
* Copyright date
* Update ChangeLog
* Use Qt 6
* Fixed some Qt6 deps
* Fixed minor compile issues for Qt6
* Drop Debian 11 support (no Qt6 lib)
* Move Debian to top
* Delete expensive to maintain code that yeilds low UX gain
* Unpack all values
* Use %lld instead of %u
* Minor UI improvements
* Add deps for Fedora, OpenSUSE, and Arch
* Fixed CMake lint issue
* Use package name from build.opensuse.org
* Used `zypper search` to find correct package names
* Lint script with CLang format
* Use `-i` for `clang-format` and add more logging for lint scripts
* Apply LLVM CLang formatting
* Fixed comment
* Update ChangeLog
* Fixed bad return code logic
* Improve output for linters
* Fixed re-used var in clang lint
* Fixed include order for tests and use `#if 0` instead of commenting out code
* Use full Clang format dump
* Dump Ubuntu Clang format
* Dump Clang format from Debian
* Dumped from: clang-format version 18.1.8
* Revert "Dumped from: clang-format version 18.1.8"
This reverts commit b9bbda2995bb0b4b65baf14afebb0361ec64e644.
* Remove BasedOnStyle
* Restore base Clang format file
* Use clang-format from pip
* Apply Clang format 18 style
* Add clang_format deps
* Fixed include order issues and *some* accidental includes
* Reorganize CMake Packaging module
* Match if statements to function order
* Cleanup root, res, and doc dirs
* Move deps to requirements.txt file
* Reorganize and format CMake files
* Rename changelog lint
* Add reccomended extension
* Workflow to lint CMake files
* Move CMake lint to script
* Try lighter dep
* Use venv
* Add --format arg
* Format all CMake files
* Convert bash script to Python
* Set CMake line ending format
* Restore formatting
* Add pyyaml dep
* Remove unused arg
* Rename config file
* Remove comment
* Repair copyrights (broken by defualt cmake-format)
* Restore 3rd party copyright
* Break up libs config into smaller macros
* Better macro name
* Load config after venv
* Make intentional noop clearer
* Only use upload step if required (make skip clearer)
* Use CPack for deb and rpm packaging
* Add upload step for Linux
* Remove cpack dep, doesn't exist
* Roll back presets version
* Fixed distro like match
* Update ChangeLog
* Legacy checkout for some distros
* All distros support v4
* Trying out newer Linux distros
* Install Git on Docker images
* Install without actions (not available before checkout)
* Delete useless action
* Install Python
* Support for Arch and OpenSUSE
* Add Arch and OpenSUSE to deps
* Name steps
* Full OpenSUSE names
* Mark Git dir safe
* Add pkgconf
* Legacy CMake for Debian 11
* Add OpenSSL to OpenSUSE
* Drop OpenSUSE Leap (no C++20 support)
* Skip packaging for Arch and OpenSUSE (for now)
* Shorten Arch/OpenSUSE names
* Clearer step name
* SImpler bootstrap
* Shell not needed
* Update apt
* Don't check return code
* Simplify python deps commands
* Add STGZ/.sh package type
* Prevent input prompt
* Only config git safe dir when needed
* Try cache v4
* Safe dir for Ubuntu
* Safe dir for Arch
* All Docker images seem to need safe dir config
* Refactor env var getters
* Make Ubuntu build extra packages
* Condense bootstep to single step
* Fixed var name
* Fixed bootstrap logic
* Simplify logic for upload condition (Windows and macOS)
* Make package/upload condition easier to understand
* Add Manjaro
* Generic names for Linux .tar.gz and .sh packages
* Add Manjaro deps
* Swap macOS matrix entries
* Add Red Hat UBI
* Remove RHEL subscription manager
* Throw on unsupported package distro
* Conditionally install pip and venv
* Remove extra pip arg
* Add config for RHEL
* Install EPEL for RHEL
* Back-out RHEL as EPEL requires subscription
* Restore Python deps logic
* Fixed bug: Packacking run twice
* Testing arm32v7 and arm64v8
* Revert "Testing arm32v7 and arm64v8"
This reverts commit cb3caf188d2b79ed083a62fc091de295f9889f3d.
* Re-add icon and shortcut file for Linux to package
* Support OpenSUSE RPM build
* Check return code
* Add `rpm-build` for OpenSUSE
* Reorg packages
* Remove busybox-which
* Add --non-interactive
* Move --non-interactive to correct position
* Experiment with makepkg
* Check and print package commands
* Make distro version optional
* Use 8 cores to build
* Default to distro name only
* Fixed bad PKGBUILD filename
* Use 4-part version for Arch
* Remove comma from conflicts
* Use .tar.gz from cwd
* Generate checksum for Arch
* Fixed file extension
* Use shell to print output
* Don't use shell
* Gaurd against bad cmd_utils.run
* Fixed bad import
* Use list command
* Fixed unable to run list commands
* Use source file name
* Simplify PKGBUILD to use make install
* Change install prefix
* Use DESTDIR
* Copy .desktop and .png to build dir
* Restore original `install(FILES...`
* Improving comments
* Fixed: makepkg runs from `src` by default
* Move error after command print
* Remove shell arg
* Package as a user instead of root (makepkg can't run as root)
* Fixed codesign runs in shell
* Allow list commands in shell on windows
* Don't use sudo on arch
* Install sudo on Arch
* Fixed typo
* Fix ownership of build directory for package user
* Improve example .env
* Change to depend on libstdc++6
* Add TODO
* Fixed Fedora version
* Remove libstdc++ deps (names vary between distros)
* Roll back to Fedora 40 and 39
* Improve comment
* Remove unneccesary default
* Convenience script to install daemon
* Use -p when re-launching with runas to keep window open
* Align new script with PEP 8
* Add more args for flexibility
* Add task to reinstall Windows daemon
* Fixed mistake in continue message
* Close task window after running script
* Reset error state before calling Process32Next
* Update CL
* Increase Windows CI timeout
* Bump timeout again due to choco
* Create tasks.json
* Delete gui.pro
* Swallow any exceptions from stopDesktop
* Upgrade to C++20
* Update ChangeLog
* Remove old versions of Ubuntu
* Ignore VS Code workspace
* Restore original CodeQL job name
* Add problem matcher and suppress warnings from within old CMake lib
* Bump CMake min version to 3.5
* Remove useless cmake_minimum_required
* HACK: temp comment out failing code
* Bump Qt to 5.12.6
* Delete tasks.json
* Create CMakePresets.json
* Fixed Qt link error: The input line is too long.
* Fixed invalid call to map erase
* Fixed incorrect use of RegCreateKeyEx
* Add VS Code tasks.json for cmake build
* Store `desktop` in char buf before using it
* Generate compile_commands.json
* Restore indentation
* Revert "Restore indentation"
This reverts commit d9f495460f337c37e8a01d8853b317e949ea085a.
* Restore original indentation (for now)
* Create extensions.json
* Change error to debug2 and add additional info
* Update ChangeLog
* Improved wording in ChangeLog for 1.14.7
* Apply markdown formatting to ChangeLog
* Fixed merge gone wrong
* Fixed further merge mistake
* Fixed order of new ChangeLog lines
---------
Co-authored-by: Nick Bolton <nick@symless.com>
* Made log lines consistent
* Change log level for process list
* Only show advanced proc info at DEBUG2
* Fixed some more log lines
* Update AppUtilWindows.cpp
* SYNERGY1-1497 Fix problem with memory leak
* SYNERGY1-1497 Fix memory leak for TLS
* Update ChangeLog
* SYNERGY-1-1497 Update ChangeLog and Copyright info
* After getting a dead key from ToUnicodeEx, add an additional VK_SPACE
to the keyboard state so we reset the dead key flag and subsequent
calls with modifiers, like shift, return the right result (-1) instead
of 1.
This happened because without reseting the dead key status
the new one was attempted to be composed with the old one, which failed
and the end result was a single unicode codepoint not marked as a dead
key.
This opens the door to potentially use the returned unicode from the
second call as the key character instead of maintaining the
getDeadKey function.
* Update ChangeLog
Co-authored-by: Pedro Navarro <pnavarro@netflix.com>
Co-authored-by: Serhii Hadzhilov <serhii-external@symless.com>
Co-authored-by: Serhii Hadzhilov <71632867+SerhiiGadzhilov@users.noreply.github.com>
text/plain;charset=utf-8 clipboard format.
This results in double lines when pasting text copied from Linux to
Windows because the Windows client converts line endings and expects
only LF.
Co-authored-by: Pedro Navarro <pnavarro@netflix.com>
* SYNERGY-1454 MacOS part
* SYNERGY-1454 Windows part
* SYNERGY-1454 Linux part
* SYNERGY-1454 Fix comments
* SYNERGY-1454 Move common code to parent class. MacOS
* SYNERGY-1454 Move common code to parent class. Linux
* SYNERGY-1454 Move common code to parent class. Windows
* SYNERGY-1454 ChangeLog and code smell fix
* SYNERGY-1454 Add a new checkbox into the setting dialog
* SYNERGY-1454 Save the new option
* SYNERGY-1454 Pass the new option to client
* SYNERGY-1454 Parse the new param on client side
* SYNERGY-1454 Invert scroll direction for macOS
* SYNERGY-1454 Scroll direction on Windows
* SYNERGY-1454 Remove unused code
* SYNERGY-1454 Scroll direction for Linux
* SYNERGY-1454 Simplify scroll direction for Mac
* SYNERGY-1454 Simplify scroll direction for Linux
* SYNERGY-1454 Simplify scroll direction for Windows
* SYNERGY-1454 ChangeLog
* SYNERGY-1454 Fix code smell
* SYNERGY-1434 Lower case for the first char of the option
* SYNERGY-1454 Fix indentations
Co-authored-by: Serhii Hadzhilov <gadzhilov.sergey@gmail.com>
Co-authored-by: Serhii Hadzhilov <serhii@symless.com>
* SYNERGY-1397 MacOS function keys
* SYNERGY-1397 Update ChangeLog and version number
* SYNERGY-1397 Remove extra comment
* SYNERGY-1397 Remove assertions
* SYNERGY-1397 Change log level to warning
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix checkbox spelling
* SYNERGY-907 Client tray language switcher reverts to EN
*Update changelog
* SYNERGY-907 Client tray language switcher reverts to EN
*Temporary disable language sync logic
* SYNERGY-907 client tray language switcher reverts to en
*Update changelog
* Synergy 907 client tray language switcher reverts to en
*Fix sonar
* Synergy 907 client tray language switcher reverts to en
*Fix sonar
* Synergy 907 client tray language switcher reverts to en
*Fix chnagelog
* SYNERGY-907 Client tray language switcher reverts to EN
*Add prototype of keyboard layout names transfer(Windows part)
* SYNERGY-907 Client tray language switcher reverts to EN
*Add keyboard layout determination(Mac part)
* SYNERGY-907 Client tray language switcher reverts to EN
*Add language check on client side
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix Windows build
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Add logs
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Add protocol update
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Add server side of language sync
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Remove unused variables
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*AFix mac language determination
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Clean up logs
* SYNERGY-907 Client tray language switcher reverts to EN
*Replace logs with messagebox on Windows
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Add mac messagebox, revert protocol changes
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Fix minor language bugs
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Update chagelog
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Minor fixes
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Fix Linux build
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Fix sonar code smells
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Fix Linux build
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Add Linux language determination
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Fix sonar codesmells
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Fix sonar codesmells
* SYNERGY-907-Client-tray-language-switcher-reverts-to-EN
*Replace custom xml parser with tinyxml2
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix PR comments
* SYNERGY-907 Client tray language switcher reverts to EN
*Update changelog
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix unix build
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix unix build
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix sonar code smells
* SYNERGY-907 Client tray language switcher reverts to EN
*Update changelog
* SYNERGY-907 Client tray language switcher reverts to EN
*Replace tinuxml with pugixml
* SYNERGY-907 Client tray language switcher reverts to EN
*Add pugixml as a git submodule
* SYNERGY-907 Client tray language switcher reverts to EN
*Add missed files
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix sonar code smells
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix comments from PR
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix sonar code smell
* SYNERGY-907 Client tray language switcher reverts to EN
*add tests for x11 files parser
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix include for unix build
* SYNERGY-907 Client tray language switcher reverts to EN
*Add test coverage for new logic
* SYNERGY-907 Client tray language switcher reverts to EN
*Add test coverage for new logic
* SYNERGY-907 Client tray language switcher reverts to EN
*Add code coverage
*Fix code smells
* SYNERGY-907 Client tray language switcher reverts to EN
*Return missed file
* SYNERGY-907 Client tray language switcher reverts to EN
*Improve code coverage of x11Layouts parser
* SYNERGY-907 Client tray language switcher reverts to EN
*Add client args code coverage
* SYNERGY-907 Client tray language switcher reverts to EN
*Return runtime language sync
* SYNERGY-907 Client tray language switcher reverts to EN
*Return windows current keyboard layout determination
* SYNERGY-907 Client tray language switcher reverts to EN
*Return Linux language determination
* SYNERGY-907 Client tray language switcher reverts to EN
*Remove debug code
* SYNERGY-907 Client tray language switcher reverts to EN
*Move back Carbon current language determination
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix language change for existed languages on iOS and Linux
* SYNERGY-907 Client tray language switcher reverts to EN
*Return protocol missed parameter
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix macOS language change
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix language sync (when it is disabled)
* SYNERGY-907 Client tray language switcher reverts to EN
*Add correct language choosing
*Fix code coverage tests
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix windows build and tests
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix macOS build and tests
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix language change for first letter in keystroke
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix macOS build
* SYNERGY-907 Client tray language switcher reverts to EN
*Partially fix Sonar codesmells
* SYNERGY-907 Client tray language switcher reverts to EN
*Partially fix Sonar codesmells
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix build
* SYNERGY-907 Client tray language switcher reverts to EN
*Added logging for language change process
*Fixed language change process for Windows
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix double layout change in key repeat event
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix determination of current language on windows
*Removed legacy code of restoring language when leaving screen
*Fix double group change on Linux
* SYNERGY-907 Client tray language switcher reverts to EN
*Temp fix for language change on Linux
* SYNERGY-907 Client tray language switcher reverts to EN
*Add XSync to normalize Linux language polling and setting
*Remove setxkbmap using
* SYNERGY-907 Client tray language switcher reverts to EN
*Add keyboard layout changing on Linux with DBus
* SYNERGY-907 Client tray language switcher reverts to EN
*Add comments to new language change function
*Logical fix
* SYNERGY-907 Client tray language switcher reverts to EN
*Remove input attaching
* SYNERGY-907 Client tray language switcher reverts to EN
*Fix language change on macOS
* SYNERGY-907 Fix review issues
* SYNERGY-907 Fix review comment for Windows
* SYNERGY-907 Removed debug trace
Co-authored-by: Andrii Batyiev <andrii-external@symless.com>
Co-authored-by: user <user@users-Mac-mini.local>
Co-authored-by: Serhii Hadzhilov <serhii-external@symless.com>
* SYNERGY-1089 There is no notification if user moves pointer between clients
* SYNERGY-1089 There is no notification if user moves pointer between 2 clients
* Update ChangeLog
* SYNERGY-1050 Synergy1. Floating issue. User is not able to paste to client in some cases
*Fix copy paste logic, when OS reported about clipboard update too late
* SYNERGY-1050 Synergy1. Floating issue. User is not able to paste to client in some cases
Update changelog
Co-authored-by: Andrii Batyiev <andrii-external@symless.com>
Co-authored-by: SerhiiGadzhilov <71632867+SerhiiGadzhilov@users.noreply.github.com>
* SYNERGY-988 - Normalize scrolling direction on Mac
* SYNERGY-988 - Scroll direction check on Windows
* SYNERGY-988 - Add check for registry key presence
* SYNERGY-988 - Normalize scrolling directino on Linux
* SYNERGY-988 - Detach scroll direction check on Windows
* SYNERGY-988 - Update changelog
* SYNERGY-988 - Resolve code smells
* SYNERGY-988 - Normalize scroll direction for Linux servers
* SYNERGY-988 - Removed unnecessary INFO level logs
Co-authored-by: SerhiiGadzhilov <71632867+SerhiiGadzhilov@users.noreply.github.com>
* Support "Kana" and "Eisu" keys on Japanese Apple Pro Keyboard (JIS)
* Update ChangeLog
Co-authored-by: Serhii Hadzhilov <serhii-external@symless.com>
Co-authored-by: SerhiiGadzhilov <71632867+SerhiiGadzhilov@users.noreply.github.com>
* Disable thread execution state changes preventing the system from going to sleep
* Update changelog
* Added option to the GUI
* Only set system to be in use
* Remove leftover code affecting display and system power off
* Add option parsing to the correct place
* Update changelog
* Remove prevent sleep option from struct initializer, replace NULL with nullptr in relevant places
* Remove duplicated code
* Prevent sleep on Mac clients
* SYNERGY-856 - Return language sync option
* Disable thread execution state changes preventing the system from going to sleep
* Update changelog
* Remove leftover code affecting display and system power off
Co-authored-by: SerhiiGadzhilov <71632867+SerhiiGadzhilov@users.noreply.github.com>
* (WIP)-all issues corrected, tests started
* first test passing
alternative solution for SonarCloud check
fixed for to while translation
added changelog item
adding tests and fixes
more tests; avoid compiling BSD Tests on Windows
attempting a BSD compile patch
more tests
borrowing symbol detection from another test
more ambitious testing
changed the order of assertions for better info
more tests
fixed clear errors before executing
expanding transformation to use string comparison
including terminator on translation count
a different flag for testing MS Windows
differente Windows flag
more tests
fixing platform encoding match
Windows compiler difference on #ifdef
Google Test macro usage fix
test added
added keymap test
test and initialisation fixed
ms cl issue with named init
test for keymap
exercising keystate
more configuration exercises
one more test for config
added Unicode test
an IPv6 test
more portable networking code
using our own platform switching code
avoiding strcpy
* Fixed typo in Changelog.
* +appropriate memory handling
* one more test for coverage
* a tad more coverage
* expanded test on Config
Co-authored-by: Max <maxmommersteeg@hotmail.com>
Co-authored-by: SerhiiGadzhilov <71632867+SerhiiGadzhilov@users.noreply.github.com>
Capture all process information as they are created to properly kill off handles when process are stopped, also added in a kill everything when the program cleans up all synergy(s|c) processes
QLength() may return 0 even if there are events pending because they
need to be read from the display socket in order to become visible. We
must use XPending() which will poll the socket if QLength() == 0.
XWindowsScreen::saveShape() using XRRSizes / XRRRotations to
calculate screen dimensions when XRandR and a rotated screen
was detected. This is wrong. The screen dimensions in the
display properties already reflect rotation.
Moreover, on servers supporting XRandR >= 1.2, the XRRSizes()
and XRRRotations calls from XRandR 1.1 will return the
properties of the "primary output" in XRandR 1.2 terms rather than
the properties of the entire screen.
Virtual key table is mapped for all IMEs not just active IME.
And this causes the wrong modifier key to be pressed. For example, if you use Korean and Japanese IMEs, pressing the Hangul key makes alt key pressed. So when I press just 'a', client interprets that as 'alt-a'.
OSXScreen was not adding mouse movement deltas to mouse events while
dragging. Some 3D applications rely on these deltas to implement
dragging. Adding the mouse deltas to the mouse event fixes dragging in
these applications. Ex: Unity3d
These are the only valid ones:
[~]>for i in `seq 0 1 11`; do echo Testing $i; xte "mouseclick $i"; done
Testing 0
X Error of failed request: BadValue (integer parameter out of range for operation)
Major opcode of failed request: 132 (XTEST)
Minor opcode of failed request: 2 (X_XTestFakeInput)
Value in failed request: 0x0
Serial number of failed request: 12
Current serial number in output stream: 15
Testing 1
Testing 2
Testing 3
Testing 4
Testing 5
Testing 6
Testing 7
Testing 8
Testing 9
Testing 10
Testing 11
X Error of failed request: BadValue (integer parameter out of range for operation)
Major opcode of failed request: 132 (XTEST)
Minor opcode of failed request: 2 (X_XTestFakeInput)
Value in failed request: 0xb
Serial number of failed request: 12
And there are mice out there where buttons 11+ can be pressed accidentally,
terminating the synergy client and often leaving the system in a bad state.
As reported in #451, with the Mac server, sleeping and resuming (on the
server) causes the mouse speed to double on the client upon resume.
Fix by removing the CFRunLoopSource from the run loop on screen disable
before releasing it. CFRunLoopAddSource in enable() retains the
CFRunLoopSource, so even though the source is released in disable(), the
run loop still has a copy. When the server comes out of sleep and the
screen is enable()'d, another event tap and run loop source are created
and added to the run loop, so the callback is now being called twice for
every mouse movement, and so on for every additional time the server
sleeps.
This is a better approach than the fix in 267f3ac41f, because although
that fixes the issue by disabling the event tap before the event tap and
run loop source are released, a memory leak still occurs since they are
retained by the run loop.
Additional references on the behavior of CFRunLoopAddSource:
https://developer.apple.com/library/mac/documentation/CoreFoundation/Reference/CFRunLoopRef/index.html#//apple_ref/c/func/CFRunLoopAddSourcehttp://www.cocoabuilder.com/archive/cocoa/242438-trouble-with-event-taps.html
When it is restarted, and screen saver is active, the clipboard no longer works
correctly.
The desk swap detection routine just below does not work properly when the
desktop goes from screensaver back to normal. If it did, probably this
workaround would not be needed.
* ArchMultithreadPosix::waitCondVar() returns every 100ms, so retry until we
hit timeout.
* Stopwatch constructor should be called with "false" (not "true") to make sure
Stopwatch is actually running when instantiated.
Revert "Moved note into either warning or info #4745"
This reverts
commit d3a4ce1f11.
Revert "Changed note to notify #4745"
This reverts commit
5006adedfe.
Conflicts:
src/test/unittests/ipc/IpcLogOutputterTests.cpp
Shortened transmission log #4858
Revert "Added code to throw an error if the plugin can't be deleted or
written to #4696"
This reverts commit
5696497bc0.
