Commit graph

288 commits

Author SHA1 Message Date
sithlord48
037fee0e59 refactor: remove archConsole use its only implemented method directly in logOutputters 2025-05-19 21:48:27 +01:00
sithlord48
e9ccd513f7 chore: clean up windows code smells missed by sonarscan 2025-05-03 21:13:09 +01:00
sithlord48
d483dc38bd chore: unix/XArchUnix, use default for constructor and deconstructor, explicit constructor with no except deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
56dd5492b4 chore: unix/ArchTimeUnix, use default for constructor and deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
67c7ba6dae chore: unix/ArchStringUnix, use default for constructor and deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
1138e3b1fb chore: unix/ArchLogUnix, use default for constructor / deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
6523911e4d chore: unix/ArchSleepUnix, use default for constructor and deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
a52552b821 chore: unix/ArchDaemonUnix, use default for constructor and deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
bd2188beb1 chore: unix/ArchConsoleUnix, use default for constructor and deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
edc0c0d7a0 chore: XArch, use default for constructors / deconstrucor
use noexecpt for virtual deconstctor
use explicit for constructors
2025-05-02 12:12:17 +01:00
sithlord48
95586c88fd chore: ArchDaemonNone, use deault for empty deconstructor
use default for empty constructor
add comment for empty overrides from base class
2025-05-02 12:12:17 +01:00
sithlord48
d7174a3a2f chore: ArchConsoleStd, use default for empty deconstructor
use default for empty constructor
add comment to empty impl on base methods
2025-05-02 12:12:17 +01:00
sithlord48
2289ed5845 chore: Arch use default for empty deconstructor
use explicit for constuctors
2025-05-02 12:12:17 +01:00
sithlord48
6c7bdf3e07 chore: ArchNetworkBSD, Use auto where possible 2025-04-28 13:50:43 +01:00
sithlord48
1df01d3cf1 chore: ArchMuitiThreadPosix, Use auto where possible 2025-04-28 13:50:43 +01:00
sithlord48
63d65bb47b chore: use nullptr where possible in place of NULL 2025-04-28 13:08:40 +01:00
sithlord48
41fda741b3 chore: Use override for override methods 2025-04-28 11:27:33 +01:00
sithlord48
31e95ad2dc refactor: remove unused lib/arch/mulitbyte.h 2025-03-25 08:39:05 +00:00
sithlord48
8b5a61f07f refactor: remove ArchFile, move only use of getInstallDir to MSWindowsWatchdog 2025-03-25 08:39:05 +00:00
sithlord48
516f803eb4 refactor: remove ArchFile::getbasePath for QFileInfo::fileName 2025-03-25 08:39:05 +00:00
sithlord48
c1a7b836ce refactor: remove unused ArchMiscWindows::processDialog 2025-03-24 12:16:39 +00:00
sithlord48
9530b9c6ba refactor: remove unused ArchMiscWindows::s_dialog, ArchMiscWindows::cleanup 2025-03-24 12:16:39 +00:00
sithlord48
9df2a2c28d refactor: remove unused ArchMiscWindows::removeDialog 2025-03-24 12:16:39 +00:00
sithlord48
133545d03f refactor: remove unused ArchMiscWindows::addDialog 2025-03-24 12:16:39 +00:00
sithlord48
75e852d95f refactor: remove unused ArchMiscWindows::readValueBinary 2025-03-24 12:16:39 +00:00
sithlord48
9c44653fff refactor: remove unused ArchMiscWindows::setValueBinary 2025-03-24 12:16:39 +00:00
sithlord48
2adee7c460 refactor: remove unused ArchMiscWindows::deleteKeyTree 2025-03-24 12:16:39 +00:00
sithlord48
6f6e9cddb7 refactor: remove unused ArchMiscWindows::deleteValue 2025-03-24 12:16:39 +00:00
sithlord48
fdd9b1bb6d refactor: remove unused ArchMiscWindows::getIcons 2025-03-24 12:16:39 +00:00
sithlord48
b2ff6aa938 refactor: remove unused ArchMiscWindows::setIcons 2025-03-24 12:16:39 +00:00
sithlord48
5e4188b2fe refactor: remove unused ArchMiscWindows::hasValue 2025-03-24 12:16:39 +00:00
sithlord48
45b6ff19e7 chore: remove StdExcept and include stdexcept directly where needed
remove _NOEXCEPT define and just use throw()
2025-03-21 11:42:32 +00:00
sithlord48
42b16efdb9 chore: remove StdList and include list directly where needed 2025-03-21 11:42:32 +00:00
sithlord48
40c10766f3 chore: rename lib/common/stdlist.h => lib/common/StdList.h 2025-03-20 13:06:45 +00:00
sithlord48
4a16804d27 chore: rename lib/common/stdexcept.h => lib/common/StdExcept.h 2025-03-20 13:06:45 +00:00
sithlord48
3c86d9dc83 chore: rename lib/common/constants.h.in => lib/common/Constants.h.in 2025-03-20 13:06:45 +00:00
sithlord48
099262d8ce chore: rename lib/common/common.h => lib/common/Common.h 2025-03-20 13:06:45 +00:00
sithlord48
b1b8720781 refactor: remove unused ARCH::concatPath 2025-03-19 20:01:01 +00:00
sithlord48
8609cbc20a refactor: remove unused ARCH::getUserDirectory 2025-03-19 20:01:01 +00:00
sithlord48
7fe862b715 refactor: remove unused ARCH::getSystemDirectory 2025-03-19 20:01:01 +00:00
sithlord48
377272e917 refactor: remove unused arch profileDir 2025-03-19 20:01:01 +00:00
sithlord48
6444e2c208 chore: remove unused ARCH::getLogDirectory 2025-03-19 20:01:01 +00:00
sithlord48
b3ce7c41d3 chore: remove unused ARCH::setPluginDirectory Arch::getPluginDirectory 2025-03-19 20:01:01 +00:00
sithlord48
73de5e964e chore: remove unused archsystem classes 2025-03-17 16:59:43 +00:00
sithlord48
27451d3425 refactor: move Screensaver inhibate call for xwindows from arch to platform 2025-03-17 16:59:43 +00:00
sithlord48
c1af4c3b71 fix: windows looking in deskflow/deskflow for items
fixes #8371
2025-03-17 13:47:28 +00:00
Nick Bolton
16517ca541 refactor(daemon): More helpful and less noisy logging 2025-03-14 14:19:46 +00:00
Nick Bolton
7da8c54924 refactor(daemon): Use functional type for daemonize func 2025-03-14 14:19:46 +00:00
Nick Bolton
3683db0db9 feat(daemon): Print warning when not elevated 2025-03-14 14:19:46 +00:00
sithlord48
ef315183f3 chore: rm unused ARCH:getPlatform 2025-03-13 12:25:25 +00:00
sithlord48
b73aceee7d chore: remove unused Arch::isWOW64 method 2025-03-13 12:25:25 +00:00
sithlord48
3b811a1bd0 chore: remove unused Arch::getOsName 2025-03-13 12:25:25 +00:00
Nick Bolton
39e7f60c5a build: Get minor MSVC version from host registry 2025-03-12 08:04:16 -04:00
Nick Bolton
57d1e42eca feat: Check MSVC redist version in WiX installer 2025-03-12 08:04:16 -04:00
Nick Bolton
cd45164e40 chore: Clean up unused definitions and includes in ArchMiscWindows 2025-03-11 16:38:12 +00:00
Nick Bolton
0ed583a7fe refactor: Bootstrap logging for Windows runtime check 2025-03-11 16:38:12 +00:00
Nick Bolton
751c869435 feat: Use EnumProcessModules to search loaded modules) 2025-03-11 16:38:12 +00:00
Nick Bolton
4cfeadf0be fix: Remove redundant check in runtime DLL condition
For some reason `&& hModule` was added to the end of the condition, which totally breaks the logic for when the DLL is not found.
2025-03-11 16:38:12 +00:00
Nick Bolton
402baf3bde docs: Add doc comments for ArchMiscWindows 2025-03-11 16:38:12 +00:00
Nick Bolton
d199130b43 chore: Replace local include with standard library include for set 2025-03-11 16:38:12 +00:00
sithlord48
6e8952c8a0 chore: update formating for clang-format 20.1.0 2025-03-11 10:57:51 -04:00
Nick Bolton
f2063f9e05 fix: Allow compiling on VS2019 for contributors with old IDEs 2025-03-07 09:26:43 -05:00
sithlord48
a78d1acc71 chore: remove unset variable in arch lib linking 2025-03-06 19:17:53 +00:00
sithlord48
3a4bf35e22 refactor: Remove unneeed find_packate calls for Qt Components. Qt is found by Libaraies.cmake and accesable to all items in the src folder 2025-03-06 19:17:53 +00:00
Nick Bolton
495331108b fix: Guard MSVC runtime version depending on compiler version 2025-03-06 10:45:57 -05:00
Nick Bolton
2485e993a4 chore: Improve bin RC and service description for Windows daemon 2025-03-04 13:36:47 +00:00
Nick Bolton
b64942e3a3 fix: Delete HKEY_LOCAL_MACHINE\SOFTWARE\Deskflow when clearing settings 2025-03-03 15:05:09 -05:00
Nick Bolton
a99d408be1 chore: Improve logging related to Windows daemon start/stop/install/uninstall 2025-02-28 17:58:16 +00:00
Nick Bolton
19c41e2ac5 fix: Improve Windows daemon stop speed by using non-blocking pipes and shorter sleep times 2025-02-28 17:58:16 +00:00
Nick Bolton
53038760de refactor: Use core mode for daemon install on Windows 2025-02-28 17:58:16 +00:00
Nick Bolton
c9a360a144 fix: Restore active desktop name check in Windows daemon
- Use `PIPE_NOWAIT` to skip empty stderr output on process output reading from Windows daemon watchdog
- Use `CreateProcess` result to determine when to call `CloseHandle` in Windows daemon watchdog
- Trim output from active desktop process in Windows daemon watchdog
- Improve error logging in Windows daemon watchdog
2025-02-19 18:23:10 +00:00
sithlord48
55772e1133 chore: remove unused ARCH::vsnprintf 2025-01-29 21:07:31 +00:00
sithlord48
1085df54ed refactor: Reuse compliance
build files and documentation: MIT
  images / sources: GPL-2.0-only
  breeze icons: LGPL-2.0-only
  Microsoft MSM file, vc redist license
2025-01-27 17:05:47 -05:00
sithlord48
2040df435f fix: #8107: Remove legacy tray code 2025-01-23 19:16:29 +00:00
sithlord48
793f40e582 chore: remove basic_types.h 2025-01-14 20:30:45 +00:00
sithlord48
96092df4fc refactor: replace UInt32 with uint32_t 2025-01-14 20:30:45 +00:00
sithlord48
6c95daf0a1 chore: remove stdstring.h use include <string> instead 2025-01-08 00:11:34 +00:00
sithlord48
3991e0c1a1 refactor: use std::string in place of String
basedon: https://github.com/debauchee/barrier/pull/709
2025-01-08 00:11:34 +00:00
sithlord48
2349ce7f52 chore: replace simple cases of typedef with using 2024-12-04 10:40:58 -05:00
sithlord48
37acc3b2fc chore: IArchTaskBarReciver subclasses Icon pointer should not be a const 2024-12-04 10:40:58 -05:00
sithlord48
6498fe5a6b refactor: use Qt Required Version rm configure_qt macro for its one use 2024-12-04 10:05:34 -05:00
sithlord48
403830ceea build: rm DESKFLOW_APP_NAME define
Unify Server APP USER_CONFIG_NAME and SYSTEM_CONFIG_NAME
 Some unix users may need to move their config to deskflow.conf from .deskflow.conf
2024-11-15 12:20:17 +00:00
sithlord48
da4b85b3fb build(lib/arch): Explicit Sources 2024-10-24 15:11:03 -04:00
sithlord48
90d27a174d refactor: do not include full modules in qt files 2024-10-21 14:30:02 +01:00
sithlord48
9b9ecb0d05 chore: Adjust Clang-format linter rules
120 Column Lines
 Block Indent for Bracket Align
 Custom Line Break Rules
 No Single Line Functions
2024-10-17 21:38:29 +01:00
Nick Bolton
636e3eab96 feat: Respect XDG_CONFIG_HOME in server/client 2024-10-14 17:43:30 +01:00
Nick Bolton
9c4f6e6d0b chore: Change TLS dir to same as Qt config 2024-10-14 17:43:30 +01:00
sithlord48
932ca44d75 build: use pragma once not ifndef def pattern for headers 2024-10-08 06:52:41 -04:00
Nick Bolton
6bb1bcad8c chore!: Relocate commercial code downstream 2024-10-01 14:39:05 +01:00
Chris Rizzitello
ed1217e9cc
Use Deskflow Name (#7519)
* Use Deskflow Name

* Remove business-oriented options from issue templates

* Remove business-oriented workflow

* Bump version to 3.0.0 (to avoid confusion with previously used version numbers 1.x & 2.x)

* Update readme to reflect new project name and goals

* Found some more "synergy" to rename

* Rename `synlib` to `app`

* Rename `syntool` to `deskflow-legacy`

* Rename `synwinhk` to `dfwhook`

* Rename dirs from synergy to deskflow

* Rename more "Synergy" files

* Rename app bundle ID

* Fixed copyright typo

* Rename only title in serial key dialog (to be moved downstream later)

* Preserve original serial key window for moving downstream

* Restore dialogs ready for moving downstream

* Rename `QDeskflowApplication` to `DeskflowApplication` (the Q is confusing)

* Restore Volker's original project name

* Fixed mimetype

* Fixed weird grammar

* Fixed (more) weird grammar

* Broken link, restoring (but we should move all links out of source)

* Broken link, restoring (but we should move all links out of source)

* Add write permission to valgrind-analysis.yml

* Restore AUR conflicts

* Apply Clang format

* Update ChangeLog

* Back out version change

---------

Co-authored-by: Nick Bolton <nick@symless.com>
2024-09-17 20:00:25 +01:00
Nick Bolton
321418fcf8
Improve handling of Qt-related warnings and errors (#7431)
* Load .env from app dir

* Use `OutputDebugStringA` on Windows

* Improved string manipulation in logger and better use of OutputDebugStringA

* Use noquote for path

* Apply TLS setting after activation

* Restart after activation

* Move skip debug message to correct place

* Only print settings path on create, not shown

* Merge common and global libs

* Reduce code duplication around constants, version, etc

* Simplify sprintf code

* Use snprintf

* Add error test menu

* Coverage for dotenv

* Coverage for Logger

* Add missing include

* Add init when no Git SHA

* Update ChangeLog

* Add spellings

* Set debugging on for release build

* Remove unused variable

* Remove bad comment

* Fixed copyright date

* Remove import

* Move URL const back to GUI

* Remove dead code and duplication

* Fixed/ignored lint warnings
2024-08-09 14:03:48 +01:00
Nick Bolton
f1f7266a81
Fixed warnings and enable errors as warnings (#7426)
* Fixed warnings on WIndows and enable errors as warnings

* Fixed string array pointer hack

* Ignore warnings in macOS .mm files

* Add missing overrides

* Clang format

* Update ChangeLog

* Safer string manipulation

* Coverage for change year code

* Oops, bad override

* Fixed horrible Windows
2024-08-07 18:11:29 +01:00
Nick Bolton
157fe818d8
Refactor local/global save/load and show dev thanks message (#7423)
* WIP: Show dev thanks message

* Improve error messages and guard license code

* Print core command

* Allow license tests when licensing disabled by default

* Don't check invalid serial key

* Fixed typo

* Add error checking

* Use shared ptr instead of static deps

* Actually save and load the setting

* Add dev thanks vars to CI

* Show thanks message after connected

* Refactor hack-job of local/global save/load to remove coupling and use Qt events system

* Simplify config loading

* Overloads for optionals

* Fixed global config scope not loaded

* Save message state before showing to avoid multiple messages

* Update ChangeLog

* Fixed lint warnings

* Make function const

* Reduce verbosity

* Remove dead code, show version on start, tidy up lint warnings

* Make product name code safer

* Connect on enter press

* Only show server specific wording when on server

* Add emit commands

* Log info and error

* Remove deaad code

* Remove test member

* Disable start context menu action unless usable

* Show more relvant connect message

* Fixed close to tray not applied, and simplified restart core logic

* Remove redundant include
2024-08-03 01:17:29 +01:00
Nick Bolton
9eeb1cb7ee
Introduce 'Advanced' tab to Preferences window (#7419)
* Add QML and QtQuick deps

* Keep only Qt declarative

* Fixed delcarative package name

* Use `qt6-qtdeclarative` on OpenSUSE

* Fixed warnings

* Introduce tabs for settings and make some settings easier to understand

* Further reorganization of settings UI

* Revert config.yml

* Show Qt version in config

* Remove custom font

* Improve wording of elevate privs

* Fixed window sizes and default tabs

* Save main window size and position

* Fixed slot warning

* Fixed hacky use of validators

* Make activation cancel more intuitive

* Save window state in dtor and add try-catch to prevent exceptions propagating

* Fixed consistency of fatal messages

* Improve color conssitency and add tooltip

* Clean up styles and weird layout

* Move config files to new gui lib

* Core interface integ tests

* Rename `Config` to `ConfigScopes`

* Add 'Schoeneman' to cspell

* Fixed incorrect `Config` (should be `ConfigScopes`)

* Fixed typo

* Missed a spot

* Delete accidentally re-added file

* Fixed formatting

* Add short opt

* Coverage for `AppConfig`

* Update ChangeLog

* Remove redundant includes

* Fixed date

* Remove rogue include
2024-08-01 01:13:01 +01:00
Nick Bolton
f9b93210ed Add TODO for S1-1767 (lock order reversal) 2024-07-29 23:46:49 +01:00
Nick Bolton
c9e11a6fdc
Assert arg value num > 0 for BSD socket poll unblock pipe (#7415)
* Move integ test to corredt place and re-enable tests

* Depend on `poll.h` (removes support for non-POSIX systems)

* Only build tests for each arch

* Move back to unit tests (poll is mocked)

* Better error message for valgrind not found

* Simplify dependency injection for BSD sockets poll test

* Improve test readability for BSD net poll

* Split out 2-in-1 test for `isAnyAddr`

* Stub out sleep function

* Improve coverage for pollSocket

* Use gmock ON_CALL instead of manual mock

* Remove unused function signature

* Use conventional deps struct instead of std functional

* Add test for socket data FD set to -1

* Add assertation for adding unblock pipe

* Use older style array alloc

* Less precision around `getNetworkDataForThread` value

* Use `ssize_t` for `ignore`

* Remove unused var

* Update ChangeLog

* Assert `n > 0`

* Add `num > 0` to top assert

* Update ChangeLog

* Only run assert test in debug
2024-07-29 21:51:01 +01:00
Nick Bolton
b02077550c
Expand BSD sockets poll tests and remove legacy-poll code (#7414)
* Move integ test to corredt place and re-enable tests

* Depend on `poll.h` (removes support for non-POSIX systems)

* Only build tests for each arch

* Move back to unit tests (poll is mocked)

* Better error message for valgrind not found

* Simplify dependency injection for BSD sockets poll test

* Improve test readability for BSD net poll

* Split out 2-in-1 test for `isAnyAddr`

* Stub out sleep function

* Improve coverage for pollSocket

* Use gmock ON_CALL instead of manual mock

* Remove unused function signature

* Use conventional deps struct instead of std functional

* Add test for socket data FD set to -1

* Add assertation for adding unblock pipe

* Use older style array alloc

* Less precision around `getNetworkDataForThread` value

* Use `ssize_t` for `ignore`

* Remove unused var

* Update ChangeLog
2024-07-29 18:04:17 +01:00
Nick Bolton
6399feb324
Solve low hanging reliability and maintainability issues (#7403)
* Add missing atom ctor init

* Init members with `None`

* Use in-class init and delcare getter inside if init

* Temp revert of changes ahead of unit test repair

* Move IPC header to shared, restore X clipboard test, simplify test cmake, new X clipboard unit test

* Suppress sonar for undefs

* Remove base dir include

* Revert "Temp revert of changes ahead of unit test repair"

This reverts commit 8f84b6ea5d5828f1be1362de3809279bcacb8cc8.

* Use new accessor

* Use default dtor

* Beef up to 32 core

* Use enum class

* Make IPC protocol headers const at all levels

* Use enum class and const char for better type safety

* Use unique_ptr for m_clipboard

* Use `-j` instead of `-j8` to utilize full parallelism

* Increase thread count for sonar-scanner

* Use 32 threads

* Use in-class init for IpcClientProxy members

* Use const instead of #define

* Remove ctor member inits

* Use unique_ptr on win

* Implement temp bin dir for windows with more robust post-build copy

* Fixed missing iostream

* Add warning about copy errors

* Only run clean-gcda on Linux

* Use in-class init for IPC mutex

* Do no-op on Windows

* Hide clean-gcda task

* Move flakey test to integtests

* Delete dead code

* Test

* Temp disable post_config_all

* Disable post config step

* Revert "Disable post config step"

This reverts commit 2f956a7714ba9bedacd4b39d4ae00940c3d565d6.

* Revert "Temp disable post_config_all"

This reverts commit b44ed72e44f838bfe1309f6e9672d2f1c6f21b75.

* Restore -j8

* Simplify error handling

* Use const for test port

* Remove python check

* Update changelog

* Fixed order

* Fixed bad issue number

* Fixed bin copy source path

* Remove redundant except
2024-07-18 08:04:39 +01:00
Nick Bolton
e435953af7
Make Clang param and arg alignment more readable (#7387)
* Turn off alignment of params

* Apply Clang format

* Change AlignAfterOpenBracket to AlwaysBreak and add extra bin pack settings

* Restore default bin packing

* Apply format
2024-07-16 14:36:44 +01:00
Nick Bolton
6e82f64ec8
Upgrade from Qt5 to Qt6 for more modern UI (#7373)
* Use Qt 6

* Fixed some Qt6 deps

* Fixed minor compile issues for Qt6

* Drop Debian 11 support (no Qt6 lib)

* Move Debian to top

* Delete expensive to maintain code that yeilds low UX gain

* Unpack all values

* Use %lld instead of %u

* Minor UI improvements

* Add deps for Fedora, OpenSUSE, and Arch

* Fixed CMake lint issue

* Use package name from build.opensuse.org

* Used `zypper search` to find correct package names
2024-07-08 15:37:51 +01:00