Commit graph

324 commits

Author SHA1 Message Date
sithlord48
f2a54f4af0 buid: replace NIH SYSAPI_WIN32 with Q_OS_WIN 2026-03-06 08:57:31 -05:00
sithlord48
fce1a37e97 build: remove SYSAPI_UNIX define 2026-03-06 08:57:31 -05:00
Gittensor Miner
a5b2a4fab9 Fix: Add exception handling to setValue functions
Replace TODO comments with proper exception handling in ArchMiscWindows::setValue methods.
When a nullptr registry key is passed, the functions now throw std::invalid_argument
instead of silently returning, improving error handling and making bugs easier to detect.

Removed assert statements as they are redundant with the exception handling.

This addresses the TODO comments in lines 163 and 173.
2026-01-23 12:38:32 +00:00
Nick Bolton
3a242e7fc1 refactor: use windowsErrorToString instead of obsolete winsockErrorToString 2026-01-22 13:46:43 +00:00
sithlord48
aca274e9ee refactor: add (C) to copyright header where missing 2026-01-18 15:38:59 +00:00
gayanMatch
35ee17f959 fix: macOS server crash when client disconnects abruptly 2026-01-12 10:49:02 +00:00
sithlord48
0c368f402b refactor: use ArchDaemonWindows::runDeamon directly
remove now unused ArchMiscWindows::runDaemon
2026-01-06 12:05:23 +00:00
sithlord48
0e04364d17 refactor: use ArchDaemonWindows::daemonFailed directly
remove now unused ArchMiscWindows::daemonFailed
update copyright year
2026-01-06 12:05:23 +00:00
sithlord48
3ff06b7d9a refactor: use ArchDaemonWindows::getDaemonQuitMessage directly
remove now unused ArchMiscWindows::getDaemonQuitMessage
2026-01-06 12:05:23 +00:00
sithlord48
c7da833f07 refactor: use ArchDaemonWindows::daemonRunning directly
removes:
  unused DAEMON_RUNNING define in App.h
  unused ArchMiscWindows::daemonRunning
update copyright years
2026-01-06 12:05:23 +00:00
sithlord48
c4fd8699f9 chore: ArchNetworkBsd Remove unneeded includes 2025-11-07 15:54:19 -05:00
sithlord48
50240c1fc3 refactor: Arch do not include common/Common.h use config.h where neeed as a result 2025-11-03 13:31:28 +00:00
Peter Hutterer
90d6fc6f08 refactor: Assume inet_atom on unix
ported ed2d44c346\#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
2025-11-03 13:31:28 +00:00
sithlord48
6ff8b053af refactor: fail without posix sigwait, remove from Config.h.in
based on 998a9d1735
2025-11-03 13:31:28 +00:00
sithlord48
61f3113d61 chore: remove unused Arch::setInstance 2025-10-27 15:36:40 +00:00
sithlord48
bf6986bcba chore: remove unused Arch::Arch(Arch *arch) 2025-10-27 15:36:40 +00:00
sithlord48
023e8dc78e chore: remove unused ARCH->showLog 2025-10-27 15:36:40 +00:00
sithlord48
e108afdb80 chore: remove Cpp file for ArchDaemonNone 2025-10-17 09:41:56 +01:00
sithlord48
4be0dd3d9d chore: remove unneeded ArchDaemonUnix subclass 2025-10-17 09:41:56 +01:00
sithlord48
dbc3229b40 refactor: ArchNetworkBSD, set addr to nullprt after delete to avoid returning invalid pointer 2025-10-17 09:07:21 +01:00
Nick Bolton
f64d430f96 fix: Remove assertion for unused name parameter in daemonize function 2025-10-13 07:23:59 -04:00
sithlord48
04b3f5c769 chore: remove unused name parameter from ARCH->daemonize 2025-10-09 13:30:41 +01:00
sithlord48
8ea2671e65 refactor: cleanup daemonApp args 2025-10-07 13:01:47 +01:00
Nick Bolton
c234f2fc66 fix: Do not reuse listen sockets on Windows 2025-09-25 14:00:48 +01:00
Nick Bolton
5ea8d0326a fix: Use QString for Windows error functions
Was returning only first char of error message (mild-mojibake)
2025-09-12 13:17:50 +01:00
sithlord48
9883fb988a refactor: remove Arch::hostname, use QSysInfo::machineHostName directly in the only place its used 2025-09-11 14:53:20 +01:00
sithlord48
38a74d7d0f refactor: Arch::getHostName(), use QSysInfo::machineHostname in place of system specific impl 2025-09-11 11:18:12 +01:00
sithlord48
c4c2f7f37f feat: begin to use QStrings for strings
feat: get windows building with the UNICODE forced by using Qt
refactor: remove ARCHString use QString to convert to / from utf8
build: (arch) link to common
build: (base) link to arch
build: (io) Link to common
build: (client) link to common
build: (server) link to common
fix: Append to log file instead of creating a new one each log line
refactor: Trim cipher description for neater log output
fix: Update log messages to use wide string format for Unicode support
fix: Correct event creation to use wide string for Unicode compatibility
refactor: Use QStringDecoder for UTF-8 handling on Windows Daemon child process
fix: Use correct wide type for Win32 consts
2025-09-10 18:15:19 +01:00
Nick Bolton
ad383ad9d4 chore: Remove unused daemon installation and uninstallation methods 2025-09-10 11:32:02 +00:00
Jonathan Wakely
f98f8b10d1 refactor: Construct std::string outside critical section
There's no need to hold the mutex while constructing a `std::string`
from the `char` string.

Also use `inet_ntop` instead of the potentially thread-unsafe
`inet_ntoa` that might use a static buffer for the result.

This makes the `INet` case match the `INet6` case below.
2025-09-04 16:56:46 +01:00
Jonathan Wakely
b788d63044 refactor: Give internal linkage to global mutex
The `static` keyword was removed by #8674 but I think it should be
restored so that this global can't clash with anything else called
`::s_mutex` elsewhere in the executable.
2025-09-04 16:56:46 +01:00
sithlord48
bcb6c368b1 refactor: remove unneeded common/Common includes 2025-08-18 11:45:21 +01:00
sithlord48
4eec183598 refactor: remove IInterface class, that only adds a virtual construcor 2025-08-18 11:45:21 +01:00
sithlord48
02fb9915bf refactor: Arch, only define init override on windows, where its ambiguious 2025-08-11 12:32:50 -04:00
sithlord48
85d89f9846 refactor: XArch Classes => Arch Exception Classes 2025-08-11 17:14:45 +01:00
sithlord48
2a84ef0ebf refactor: update log calls to LOG_... fixes #8819 2025-08-06 16:18:38 +01:00
sithlord48
77bdde5434 refactor: Elevel => LogLevel enum class, use proper names for items in the class 2025-07-11 03:06:24 -07:00
sithlord48
3472ff6ce5 chore: ArchNetworkBSD, use std::ignore in place of unused int 2025-07-11 03:06:24 -07:00
sithlord48
865365b2fa chore: add noreturn to more methods 2025-07-07 17:53:56 +01:00
sithlord48
0474e10b03 chore: Arch::time explictly convert to double on return 2025-07-03 03:24:16 +00:00
sithlord48
2421a8b725 refactor: Make throwError and throwNameError members of IArchNetwork
make throwError and throwNameError noreturn
          remove unused extra private section in IArchNetwork subclasses
2025-07-03 03:24:16 +00:00
sithlord48
8f6f014bcd refactor: IArchNetwork turn anonymous enum into PollEventMask struct with set of static values 2025-07-03 03:24:16 +00:00
sithlord48
47d44db497 refactor: make EStreamType enum Class StreamType, and conform members to naming conventions 2025-07-03 03:24:16 +00:00
sithlord48
879283f46f refactor: Make IArchNetwork::EAddressFamily enum class IArchNetwork::AddressFamily
confirm AddressFamily items to naming convention
2025-07-03 03:24:16 +00:00
sithlord48
cbbfd495e3 refactor: make ESignal an enum Class IArchMultiThread::ThreadSignal, conform ThreadSignal items to naming conventions 2025-07-03 03:24:16 +00:00
sithlord48
0321b2d36e chore: ArchNetworkBSD:Deps use make_shared now that we dont build on ubuntu 22 anymore 2025-06-20 09:39:26 +01:00
sithlord48
f4a49749c7 chore: remove todo in places where its done or just a note 2025-06-20 09:39:26 +01:00
sithlord48
a80e255bb0 refactor: Add a few missing overrides
make ~XThreadExit() override
 make ~ArchString() overide
 make ~ArchNetworkBDS() overide
2025-06-20 09:39:26 +01:00
sithlord48
c15214aee7 refactor: use std::scoped_lock inplace of std::lock_guard 2025-06-17 10:23:42 +01:00
sithlord48
5fd4d93f7f refactor: replace ARCH->sleep(...) calls with Arch::sleep(...) 2025-06-17 10:23:42 +01:00