deskflow/src/test/unittests/synergy/GenericArgsParsingTests.cpp
Nick Bolton 50d29edd05
Solve SonarCloud security hotspots and bugs (#7383)
* Test: allocLockCursorToScreenInfo_withState_setsState

* Merge remote-tracking branch 'origin/master' into S1-1717-sonarcloud-issues

* Remove header wrappers for gmock/gtest

* Convenience wrapper script for tests

* Use `std::copy` instead of `strcpy`

* Use `std::ranges::copy` instead of `stdcpy`

* Delete dead code

* Add guitests VS Code config and test wrapper

* Revert "Delete dead code"

This reverts commit aa40f5cd35a22b4b69acfd1876aceea053088060.

* Build guitests with CMake

* Run all tests

* Don't use --gtest_filter for Qt tests

* Undo skip for GUI tests

* Coverage for `IpcClient::sendCommand`

* Remove provider and proxy

* Use lamda for StreamProvider to reduce boilerplate

* Restore version checker tests

* Remove activation souces

* Tasks for current/all tests

* Change command for tasks

* Mock QNetworkAccessManager

* Create core app to satisfy Qt assertations

* Use `std::copy` instead of `std::ranges::copy`

* Remove integtests

* Merge guitests into unittests

* Use std::string::length

* Remove include (resolves to root)

* Fix memory leaks

* Disable sigsegv tests

* Fixed formatting

* Remove guitests from CI

* New MainWindowTests

* Passing test for MainWindowTests

* Use alternative to strlen in MainWindow::checkSecureSocket

* Passing test for Log::print

* Fixed dtor call order

* Fixed var name typo

* Use proxy instead of `#define protected public`

* Add args test for log

* Add license ctor

* Fixed log test for release

* Add error log test

* Init qt with -platform offscreen

* Back-out initQt function

* Use QT_QPA_PLATFORM

* Try QT_QPA_PLATFORM=offscreen

* Use more readable env node

* Set QT_QPA_PLATFORM in CI and CodeQL

* Remove env not needed

* Modernize Log::print

* Calculate the length of the format string fmt during the initial scan loop

* More direct and efficient alterative to `strlen`

* Fixed major maint issues in AppConfig

* New clang and cmake rules

* Set `max_pargs_hwrap` to 4

* Undo clang format for now

* Fix missing `Setting::`

* Fixed missing `m_S` on Windows

* Re-add accidental dep resolution (fix later)

* Fixed missing buffer position increment

* Turn on errors

* Fixed tests and improve error message

* Fixed segfault on log refactor

* Extract log time to function

* Copyright date

* Update ChangeLog
2024-07-16 08:30:35 +00:00

245 lines
6.4 KiB
C++

/*
* synergy -- mouse and keyboard sharing utility
* Copyright (C) 2014-2016 Symless Ltd.
*
* This package is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* found in the file LICENSE that should have accompanied this file.
*
* This package is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "synergy/ArgParser.h"
#include "synergy/ArgsBase.h"
#include "test/mock/synergy/MockApp.h"
#include <gtest/gtest.h>
using namespace synergy;
using ::testing::_;
using ::testing::Invoke;
using ::testing::NiceMock;
bool g_helpShowed = false;
bool g_versionShowed = false;
void showMockHelp() { g_helpShowed = true; }
void showMockVersion() { g_versionShowed = true; }
class GenericArgsParsingTests : public ::testing::Test {
public:
void SetUp() {
m_argParser = new ArgParser(nullptr);
m_argParser->setArgsBase(argsBase);
}
void TearDown() { delete m_argParser; }
static lib::synergy::ArgsBase argsBase;
ArgParser *m_argParser = nullptr;
};
lib::synergy::ArgsBase GenericArgsParsingTests::argsBase;
TEST_F(GenericArgsParsingTests, parseGenericArgs_logLevelCmd_setLogLevel) {
int i = 1;
const int argc = 3;
const char *kLogLevelCmd[argc] = {"stub", "--debug", "DEBUG"};
m_argParser->parseGenericArgs(argc, kLogLevelCmd, i);
String logFilter(argsBase.m_logFilter);
EXPECT_EQ("DEBUG", logFilter);
EXPECT_EQ(2, i);
}
TEST_F(GenericArgsParsingTests, parseGenericArgs_logFileCmd_saveLogFilename) {
int i = 1;
const int argc = 3;
const char *kLogFileCmd[argc] = {"stub", "--log", "mock_filename"};
m_argParser->parseGenericArgs(argc, kLogFileCmd, i);
String logFile(argsBase.m_logFile);
EXPECT_EQ("mock_filename", logFile);
EXPECT_EQ(2, i);
}
TEST_F(GenericArgsParsingTests,
parseGenericArgs_logFileCmdWithSpace_saveLogFilename) {
int i = 1;
const int argc = 3;
const char *kLogFileCmdWithSpace[argc] = {"stub", "--log", "mo ck_filename"};
m_argParser->parseGenericArgs(argc, kLogFileCmdWithSpace, i);
String logFile(argsBase.m_logFile);
EXPECT_EQ("mo ck_filename", logFile);
EXPECT_EQ(2, i);
}
TEST_F(GenericArgsParsingTests, parseGenericArgs_noDeamonCmd_daemonFalse) {
int i = 1;
const int argc = 2;
const char *kNoDeamonCmd[argc] = {"stub", "-f"};
m_argParser->parseGenericArgs(argc, kNoDeamonCmd, i);
EXPECT_FALSE(argsBase.m_daemon);
EXPECT_EQ(1, i);
}
TEST_F(GenericArgsParsingTests, parseGenericArgs_deamonCmd_daemonTrue) {
int i = 1;
const int argc = 2;
const char *kDeamonCmd[argc] = {"stub", "--daemon"};
m_argParser->parseGenericArgs(argc, kDeamonCmd, i);
EXPECT_EQ(true, argsBase.m_daemon);
EXPECT_EQ(1, i);
}
TEST_F(GenericArgsParsingTests, parseGenericArgs_nameCmd_saveName) {
int i = 1;
const int argc = 3;
const char *kNameCmd[argc] = {"stub", "--name", "mock"};
m_argParser->parseGenericArgs(argc, kNameCmd, i);
EXPECT_EQ("mock", argsBase.m_name);
EXPECT_EQ(2, i);
}
TEST_F(GenericArgsParsingTests, parseGenericArgs_noRestartCmd_restartFalse) {
int i = 1;
const int argc = 2;
const char *kNoRestartCmd[argc] = {"stub", "--no-restart"};
m_argParser->parseGenericArgs(argc, kNoRestartCmd, i);
EXPECT_FALSE(argsBase.m_restartable);
EXPECT_EQ(1, i);
}
TEST_F(GenericArgsParsingTests, parseGenericArgs_restartCmd_restartTrue) {
int i = 1;
const int argc = 2;
const char *kRestartCmd[argc] = {"stub", "--restart"};
m_argParser->parseGenericArgs(argc, kRestartCmd, i);
EXPECT_EQ(true, argsBase.m_restartable);
EXPECT_EQ(1, i);
}
TEST_F(GenericArgsParsingTests, parseGenericArgs_backendCmd_rejected) {
int i = 1;
const int argc = 2;
const char *kBackendCmd[argc] = {"stub", "-z"};
EXPECT_FALSE(m_argParser->parseGenericArgs(argc, kBackendCmd, i));
}
TEST_F(GenericArgsParsingTests, parseGenericArgs_noHookCmd_noHookTrue) {
int i = 1;
const int argc = 2;
const char *kNoHookCmd[argc] = {"stub", "--no-hooks"};
m_argParser->parseGenericArgs(argc, kNoHookCmd, i);
EXPECT_EQ(true, argsBase.m_noHooks);
EXPECT_EQ(1, i);
}
TEST_F(GenericArgsParsingTests, parseGenericArgs_helpCmd_showHelp) {
g_helpShowed = false;
int i = 1;
const int argc = 2;
const char *kHelpCmd[argc] = {"stub", "--help"};
NiceMock<MockApp> app;
ArgParser argParser(&app);
argParser.setArgsBase(argsBase);
ON_CALL(app, help()).WillByDefault(Invoke(showMockHelp));
argParser.parseGenericArgs(argc, kHelpCmd, i);
EXPECT_EQ(true, g_helpShowed);
EXPECT_EQ(1, i);
}
TEST_F(GenericArgsParsingTests, parseGenericArgs_versionCmd_showVersion) {
g_versionShowed = false;
int i = 1;
const int argc = 2;
const char *kVersionCmd[argc] = {"stub", "--version"};
NiceMock<MockApp> app;
ArgParser argParser(&app);
argParser.setArgsBase(argsBase);
ON_CALL(app, version()).WillByDefault(Invoke(showMockVersion));
argParser.parseGenericArgs(argc, kVersionCmd, i);
EXPECT_EQ(true, g_versionShowed);
EXPECT_EQ(1, i);
}
TEST_F(GenericArgsParsingTests, parseGenericArgs_noTrayCmd_disableTrayTrue) {
int i = 1;
const int argc = 2;
const char *kNoTrayCmd[argc] = {"stub", "--no-tray"};
m_argParser->parseGenericArgs(argc, kNoTrayCmd, i);
EXPECT_EQ(true, argsBase.m_disableTray);
EXPECT_EQ(1, i);
}
TEST_F(GenericArgsParsingTests, parseGenericArgs_ipcCmd_enableIpcTrue) {
int i = 1;
const int argc = 2;
const char *kIpcCmd[argc] = {"stub", "--ipc"};
m_argParser->parseGenericArgs(argc, kIpcCmd, i);
EXPECT_EQ(true, argsBase.m_enableIpc);
EXPECT_EQ(1, i);
}
#ifndef WINAPI_XWINDOWS
TEST_F(GenericArgsParsingTests,
parseGenericArgs_dragDropCmdOnNonLinux_enableDragDropTrue) {
int i = 1;
const int argc = 2;
const char *kDragDropCmd[argc] = {"stub", "--enable-drag-drop"};
m_argParser->parseGenericArgs(argc, kDragDropCmd, i);
EXPECT_EQ(true, argsBase.m_enableDragDrop);
EXPECT_EQ(1, i);
}
#endif
#ifdef WINAPI_XWINDOWS
TEST_F(GenericArgsParsingTests,
parseGenericArgs_dragDropCmdOnLinux_enableDragDropFalse) {
int i = 1;
const int argc = 2;
const char *kDragDropCmd[argc] = {"stub", "--enable-drag-drop"};
m_argParser->parseGenericArgs(argc, kDragDropCmd, i);
EXPECT_FALSE(argsBase.m_enableDragDrop);
EXPECT_EQ(1, i);
}
#endif