smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: Handle empty response from update server

Browse source
This commit is contained in:
Nick Bolton 2025-01-16 17:47:55 +00:00
parent 31e95ad2dc
commit 378fdae140
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/apps/deskflow-gui/VersionChecker.cpp
View file

@ -48,11 +48,17 @@ void VersionChecker::replyFinished(QNetworkReply *reply)
reply->deleteLater(); reply->deleteLater();
qDebug("version check response: %s", qPrintable(newestVersion)); qDebug("version check response: %s", qPrintable(newestVersion));
if (!newestVersion.isEmpty() && compareVersions(kVersion, newestVersion) > 0) { if (newestVersion.isEmpty()) {
qDebug("update found"); qWarning() << "version check is response is empty";
return;
}
if (compareVersions(kVersion, newestVersion) > 0) {
qWarning().noquote() //
<< QStringLiteral("current version %1 out of date, update available: %2").arg(kVersion, newestVersion);
Q_EMIT updateFound(newestVersion); Q_EMIT updateFound(newestVersion);
} else { } else {
qDebug("no updates found"); qDebug().noquote() << QStringLiteral("current version %1 is upto date").arg(kVersion);
} }
} }