Commit graph

6218 commits

Author SHA1 Message Date
sithlord48
66a022a012 fix: Adjust log level for unconfigured client as we react to this in the gui 2025-09-10 14:31:13 +01:00
Nick Bolton
19eefd65c1 fix: Prevent log visibility toggle when window is hidden 2025-09-10 11:51:37 +00:00
Nick Bolton
ad383ad9d4 chore: Remove unused daemon installation and uninstallation methods 2025-09-10 11:32:02 +00:00
sithlord48
539ddcaf48 refactor: ScreenConfigDialog, make sure to populate the screen model with the server config after its been made 2025-09-09 15:59:07 +00:00
sithlord48
b30f8d253c refactor: XWindowsKeyState remove name for unused KeyId in remapKeyModifiers 2025-09-05 11:52:17 +01:00
sithlord48
c477d0fcc6 refactor: XWindowsKeyState::init remove unused display var 2025-09-05 11:52:17 +01:00
sithlord48
bc63961e7e refactor: EIEventQueueBuffer remove unused screen from constructor 2025-09-05 11:52:17 +01:00
sithlord48
30ce0bdf45 refactor: SecureSocket, remove names for unused parameters for socket service accept and serviceConnect 2025-09-05 11:52:17 +01:00
sithlord48
dd66dd21bb refactor: IDataSocket, add maybe_unused for constructors event pointer 2025-09-05 11:52:17 +01:00
sithlord48
27075a0260 refactor: StreamBuffer::write use emplace when adding m_chunks 2025-09-05 11:52:17 +01:00
sithlord48
6cfd89af8c refacor: ServerConfigDialog::toggleClipboard use static access to ServerConfig::defaultClipboardSharingSize 2025-09-05 11:52:17 +01:00
sithlord48
8e99700657 refactor: ServerConfigDialog mark that deselected maybe_unused when calling the selectionChanged for our lists 2025-09-05 11:52:17 +01:00
sithlord48
e21c4cdd4d refactor: CoreProcess::addGenericArgs remove unused processMode var 2025-09-05 11:52:17 +01:00
sithlord48
88efc14bc2 refactor: ServerConfig, use static access to switchCornerNames() 2025-09-05 11:52:17 +01:00
sithlord48
a9d518fbc8 refactor: X11LayoutParser:appendVectorUniq, capture elem by ref in our lambda 2025-09-05 11:52:17 +01:00
sithlord48
43b1014700 refactor: X11LayoutParser::getAllLanguageData , do not shadow variables from outer for loop with the inner one (i.e use differnt nanes for each var) 2025-09-05 11:52:17 +01:00
sithlord48
2e722bdfeb refactor: Server::handleToggleScreenEvent remove name of the incomming event var to indicate its not used in the method 2025-09-05 11:52:17 +01:00
sithlord48
aedbffa809 refactor: server/Config use empty() to check if args are empty 2025-09-05 11:52:17 +01:00
sithlord48
dc0db9d192 refactor: LogWidget remove unused Q_SIGNALS delclaration 2025-09-05 11:52:17 +01:00
sithlord48
9f3e724218 refactor: ScreenSettingsDialog::removeAlias make const 2025-09-05 11:52:17 +01:00
Jonathan Wakely
f98f8b10d1 refactor: Construct std::string outside critical section
There's no need to hold the mutex while constructing a `std::string`
from the `char` string.

Also use `inet_ntop` instead of the potentially thread-unsafe
`inet_ntoa` that might use a static buffer for the result.

This makes the `INet` case match the `INet6` case below.
2025-09-04 16:56:46 +01:00
Jonathan Wakely
b788d63044 refactor: Give internal linkage to global mutex
The `static` keyword was removed by #8674 but I think it should be
restored so that this global can't clash with anything else called
`::s_mutex` elsewhere in the executable.
2025-09-04 16:56:46 +01:00
sithlord48
d5936a9e08 refactor: ScreenSettingsDialog, do not use auto connect slots 2025-09-03 10:38:59 +01:00
sithlord48
81c53d3690 refactor: ScreenSettingsDialog, conform to naming conventions 2025-09-03 10:38:59 +01:00
sithlord48
89003082d7 refactor: continue to improve the screen settings dialog ui 2025-09-03 10:38:59 +01:00
Tomaz Canabrava
fe1a48fa28 refactor: Rework Computer Settings
Removed almost half of the lines, and still made it
more pretty.
2025-09-03 10:38:59 +01:00
Tomaz Canabrava
c4b2f91424 refactor: Move ServerConfig to the config folder 2025-09-03 10:38:59 +01:00
Tomaz Canabrava
f16c13fa54 refactor: ScreenSettingsDialog, Constify validator variables 2025-09-03 10:38:59 +01:00
sithlord48
43ce3c50e5 refactor: move log to dockwidget simplifying resize code 2025-09-01 18:12:41 +01:00
sithlord48
204a6b5a44 refactor: New LogWidget to handle log output in the mainwindow 2025-09-01 18:12:41 +01:00
sithlord48
a6dc455477 fix: Settings reset on windows, create new profile dir when not in native mode
fixes: #8916
2025-09-01 17:22:15 +01:00
sithlord48
138ede0536 refactor: use If in place of switch that looks for single case 2025-09-01 16:57:39 +01:00
sithlord48
eae089d3ec chore: ServerConfigDialog, conform to naming standards for members 2025-09-01 16:57:39 +01:00
sithlord48
340df69ca2 refactor: ServerConfigDialog, set members in alphbetical order, correct initlization order 2025-09-01 16:57:39 +01:00
sithlord48
507c98adff refactor: EIKeyState::fakeKey use if in place of a switch that cares only about a single case 2025-09-01 16:57:39 +01:00
sithlord48
0501f2892d chore: Messages::showClientError remove unneeded capture from lambda 2025-09-01 16:57:39 +01:00
Kris
104d2facdb feat: add switchToNextScreen hotkey to cycle through computers 2025-09-01 11:39:52 -04:00
Kris
398c9726f3 fix: fixes the mouse label issue 2025-09-01 11:39:52 -04:00
sithlord48
eb2f885983 chore: conform CoreProcess to naming standards 2025-09-01 16:18:02 +01:00
Nick Bolton
4a16931c5d refactor: Remove QProcessProxy and simplify CoreProcess
Making a proxy class for QProcess to make GTest work is an excellent example of over-abstraction making simple things hard to do. I just wanted to call a function on QProcess and had to jump through hoops to do it.

Bye bye QProcessProxy! We can do much better with QTest.
2025-09-01 16:18:02 +01:00
Nick Bolton
78b83c5639 fix: Use correct log function for process exit status in onProcessFinished 2025-09-01 08:05:07 -04:00
sithlord48
9cf25c4caf feat: Allow suppression of generic client connection dialog
fixes 8907
2025-09-01 10:57:59 +01:00
sithlord48
f0e02724ee refactor: CoreProcess::onProcessFinished add using for ProcessState enum 2025-09-01 10:04:52 +01:00
sithlord48
60e71aad38 fix: missing IPC messages
fixes #8905
2025-09-01 10:04:52 +01:00
sithlord48
d1897efa8b chore: LogTests, Fix codeQL issue with args in the printTestWithArgs test 2025-08-30 10:07:41 +01:00
sithlord48
490dac5048 refactor: LogTests use private log member 2025-08-30 10:07:41 +01:00
sithlord48
549133e619 refactor: LogTests, read buffer capture before release 2025-08-28 08:20:14 +01:00
sithlord48
323d011476 chore: remove unused include for ArchString 2025-08-28 08:20:14 +01:00
sithlord48
4e8a67925f refactor: Add Tooltip to log levels and show a label with info about debug level affecting performance
fixes: #8889
2025-08-28 00:45:40 +01:00
sithlord48
cba3881f41 refactor: Move all messages that are checked for by GUI in the log to new IPC Level so the gui can work with any filter level 2025-08-28 00:45:40 +01:00