Commit graph

365 commits

Author SHA1 Message Date
Nick Bolton
739cdc1752 chore: Improve logging for DESKFLOW_MOUSE_ADJUSTMENT env var
We plan to move this elsewhere, but in the meantime, the DEBUG1 logging was too noisy. Also fixed some code style that was bugging me.
2025-08-05 14:41:50 -04:00
sithlord48
4f9b042f5a refactor: explicit constructor for PlatformScreen, FileTail, FunctionJob, FunctionEventJob, ServerConfig, ScreenSettingsDialog, KeySequenceWidget, NetworkAddress, AddClientDialog, ConfigReadContext, LockCursorToScreenAction, RestartServer And KeyboardBroadcastAction 2025-08-04 13:46:27 +01:00
Christian Schmidt
1236fa4cab fix: server: initialize the m_protocol member with a default value
It is likely random whether the server works or not without
a manually configured protocol option, which is neither documented
nor enforced to be set.
With a random uninitialized value in m_protocol, this can happen:
[2025-08-03T12:39:57] NOTE: accepted client connection
[2025-08-03T12:39:57] FATAL: a runtime error occurred: XInvalidProtocol

Reports of "it works with debug enabled" are likely due to having
parts of the memory space the server object is allocated into being
cleared, and thus having a 0 (Synergy) startup value.
2025-08-04 12:47:13 +01:00
sithlord48
e69be64773 refactor: remove redundant != operators c++20 std will generate the !=operator as long as the class has an ==operator 2025-08-01 13:03:51 -04:00
sithlord48
d120cc853d refactor: InputFilter, user std::ranges::partial_sort in == operator 2025-08-01 13:03:51 -04:00
sithlord48
f73d098b1f refactor: Unify ENetworkProtocol and ServerProtocol into new enum Class NetworkProtocol in new file base/NetworkProtocol.h 2025-07-31 13:41:29 +01:00
sithlord48
9673943556 refactor: OptionTypes, Remove corner related enums and uses static items for corner masks instead 2025-07-31 13:41:29 +01:00
sithlord48
7fd9070a80 refactor: InputFilter::EFilterStatus => InputFilter::FilterStatus enum class 2025-07-11 03:06:24 -07:00
sithlord48
3ececbcfd9 refactor: Event anon enum => EventFlags struct 2025-07-11 03:06:24 -07:00
sithlord48
36e985d8ab chore: add missing default for switches 2025-07-07 17:53:56 +01:00
sithlord48
245fa815d2 refactor: Server::onMouseMousePrimary, use std array for horizontal and vertical direction array 2025-07-07 17:53:56 +01:00
sithlord48
f12f312dab refactor: ProtocolTypes EDirection => enum class Direction 2025-07-07 17:53:56 +01:00
sithlord48
dded2e3711 refactor: ProtocolTypes EDirectionMask => enum class DirectionMask 2025-07-07 17:53:56 +01:00
sithlord48
bc9f47c957 refactor: ProtocolTypes EDataReceived => enum class ProtocolTypes::TransferState 2025-07-07 17:53:56 +01:00
sithlord48
ede27975d7 chore: clean up remaing sonar warnings to use in class intializers where possible 2025-07-07 17:53:56 +01:00
sithlord48
ab4fbd1c85 refactor: use using enum EventTypes when possible to reduce verbosity 2025-07-03 03:24:16 +00:00
laz-001
26cc85e878 add protocol developer documentation 2025-06-25 15:42:16 +01:00
sithlord48
b29c5b1bb2 refactor: use contains to find if an item is in a container 2025-06-20 09:39:26 +01:00
sithlord48
aacf922319 refactor: remove names for unused handle function args 2025-06-20 09:39:26 +01:00
sithlord48
90a651b409 refactor: server use std::unique_ptr for socketFactory
based on ff7f23e79d
2025-06-19 19:13:24 +01:00
sithlord48
66e201c8ef chore: remove handle* methods that are a single oneline forward and use the line directly 2025-06-18 13:17:16 +01:00
sithlord48
3a35b183d3 refactor: use std::function for Event callback
based on 6d347337c3
2025-06-18 13:17:16 +01:00
Povilas Kanapickas
6fbb60a3c2 chore: remove unused StopWatch Includes 2025-06-14 08:22:55 +01:00
Povilas Kanapickas
0b4a2e0e5b chore: use std::unique_ptr for IDataSocket
port-of input-leap/836e08b0642ad158ecedc44e59a3bd3c61b56141
ported-by sithlord48
2025-05-28 09:54:04 +01:00
sithlord48
3eb3969a01 chore: use final for overrides and remove virtual for non base classes 2025-05-28 09:42:08 +01:00
sithlord48
e6a374369b chore: use const for more local ref and pointer vars 2025-05-28 09:42:08 +01:00
sithlord48
a4f1a382d3 chore: use ranged for in ClientListener::cleanupClientSockets 2025-05-23 10:19:11 -07:00
sithlord48
647201cd37 refactor: server/Config to the variable initializer and condition part of the for loop when checking for a valid screen name 2025-05-23 10:19:11 -07:00
sithlord48
475b895755 chore: initialize class vars using the order class define, initilizer list, constructor 2025-05-23 10:19:11 -07:00
sithlord48
a33574e1bd chore: use more ranged for loops 2025-05-22 20:46:41 +01:00
sithlord48
5a90b51e97 chore: use string_view in place of string where possible 2025-05-22 20:46:41 +01:00
sithlord48
fe12972e83 chore: use const pointer / ref where possible 2025-05-22 20:46:41 +01:00
sithlord48
04805d9a7e chore: mark explicit methods 2025-05-22 20:46:41 +01:00
sithlord48
3cf0fb89ef chore: add comment to empty methods 2025-05-20 16:20:07 +01:00
sithlord48
52b0c1f061 chore: use auto or (const auto) where possible 2025-05-20 16:20:07 +01:00
sithlord48
c224cd4661 chore: declare const methods recommened by sonar 2025-05-20 16:20:07 +01:00
sithlord48
635962618f chore: define only one variable per line 2025-05-20 16:20:07 +01:00
sithlord48
0ff72441e6 chore: use c++17 style if,switch init-initilizer where possible
chore: correct spelling of "colon" in NetworkAddresses variables
chore: correct some multi line defines near needed init-initilizers
2025-05-20 16:20:07 +01:00
sithlord48
bdffda9a2f chore: replace typedef with using 2025-05-20 16:20:07 +01:00
sithlord48
8f53b88bb6 chore: remove unused tests
Remove Unused Mocks
Remove remaing uses of TEST_ENV and its guarded items
2025-05-08 15:26:44 +01:00
sithlord48
38dc845c72 refactor: port serverConfigTests to QtTests
remove TEST_ENV items from server/Config
2025-05-08 15:26:44 +01:00
sithlord48
b56a282a9c refactor: port ServerTests to QtTests
remove TEST_ENV items from Server
2025-05-08 15:26:44 +01:00
sithlord48
5365e34f08 feat: remove drag and drop support, its broken on all platforms 2025-05-08 09:47:41 -04:00
sithlord48
55a7fa3266 Port simplified EventTypes from 8b23570379 2025-05-05 17:17:01 -04:00
sithlord48
d643e4b189 chore: PrimaryClient, use default for deconstructors / constructors 2025-05-02 12:12:17 +01:00
sithlord48
c8734755c5 chore: InputFilter, use default for deconstructors / constructors 2025-05-02 12:12:17 +01:00
sithlord48
edea3b0df1 chore: server/Config use default for deconstructors 2025-05-02 12:12:17 +01:00
sithlord48
f4264d71a1 chore: ClientProxy1_6 use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
6ffd0eb471 chore: ClientProxy1_4 use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
7619928d56 chore: ClientProxy1_3 use override where possible 2025-05-02 12:12:17 +01:00
sithlord48
d70c7fe720 chore: ClientProxy1_2 use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
b26ca77ff1 chore: ClientProxy1_1 use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
68db2c3484 chore: BaseClientProxy use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
b3f179a08a chore: Server, use auto where possible 2025-04-28 13:50:43 +01:00
sithlord48
f3fca87e19 chore: InputFilter, use auto where possible 2025-04-28 13:50:43 +01:00
sithlord48
a3093fa046 chore: Config, use auto where possible 2025-04-28 13:50:43 +01:00
sithlord48
c00ebbd6c1 chore: ClientProxy1_6, use auto where possible 2025-04-28 13:50:43 +01:00
sithlord48
09457793b4 chore: ClientProxy1_0, use auto where possible 2025-04-28 13:50:43 +01:00
sithlord48
d436aa3001 chore: ClientListener, use auto where possible 2025-04-28 13:50:43 +01:00
sithlord48
63d65bb47b chore: use nullptr where possible in place of NULL 2025-04-28 13:08:40 +01:00
sithlord48
48f824ca31 chore: Server, default should be first or last case for switches 2025-04-28 11:47:04 +01:00
sithlord48
41fda741b3 chore: Use override for override methods 2025-04-28 11:27:33 +01:00
sithlord48
80afb92af1 chore: remove more code for inverse connection
related: https://github.com/deskflow/deskflow/pull/8240
2025-04-21 22:39:28 +01:00
sithlord48
201df59cb7 remove Use of libnotify and wintoast 2025-03-27 13:07:59 +00:00
sithlord48
45b6ff19e7 chore: remove StdExcept and include stdexcept directly where needed
remove _NOEXCEPT define and just use throw()
2025-03-21 11:42:32 +00:00
sithlord48
1798d7e4e6 chore: remove StdOStream and include ostream directly where needed 2025-03-21 11:42:32 +00:00
sithlord48
498ffe85c3 chore: remove StdSet and include set directly where needed 2025-03-21 11:42:32 +00:00
sithlord48
cd3f9b2e7d chore: remove StdMap and include map directly where needed 2025-03-21 11:42:32 +00:00
sithlord48
003f87db9e chore: remove StdVector and include vector directly where needed 2025-03-21 11:42:32 +00:00
sithlord48
86dca27e4c chore: remove StdDeque and include deque directly where needed 2025-03-21 11:42:32 +00:00
sithlord48
13c325eb3f chore: rename lib/common/stdvector.h => lib/common/StdVector.h 2025-03-20 13:06:45 +00:00
sithlord48
a3ad66dfb0 chore: rename lib/common/stdset.h => lib/common/StdSet.h 2025-03-20 13:06:45 +00:00
sithlord48
de2e3fb9ce chore: rename lib/common/stdostream.h => lib/common/StdOStream.h 2025-03-20 13:06:45 +00:00
sithlord48
3bad718bb7 chore: rename lib/common/stdmap.h => lib/common/StdMap.h 2025-03-20 13:06:45 +00:00
sithlord48
bf09df835d chore: rename lib/common/stdistream.h => lib/common/StdIStream.h 2025-03-20 13:06:45 +00:00
sithlord48
4a16804d27 chore: rename lib/common/stdexcept.h => lib/common/StdExcept.h 2025-03-20 13:06:45 +00:00
sithlord48
5e1aa9eb5d chore: rename lib/common/stddeque.h => lib/common/StdDeque.h 2025-03-20 13:06:45 +00:00
sithlord48
2ef23b8206 chore: rename lib/deskflow/protocol_types => lib/deskflow/ProtocolTypes 2025-03-20 13:06:45 +00:00
sithlord48
ecf70f09f3 chore: rename lib/deskflow/option_types => lib/deskflow/OptionTypes 2025-03-20 13:06:45 +00:00
sithlord48
397c652e1c chore: rename lib/deskflow/mouse_types => lib/deskflow/MouseTypes 2025-03-20 13:06:45 +00:00
sithlord48
1666a30b94 chore: rename lib/deskflow/clipboard_types => lib/deskflow/ClipboardTypes 2025-03-20 13:06:45 +00:00
sithlord48
827d020d16 chore: rename lib/deskflow/key_types => lib/deskflow/KeyTypes 2025-03-20 13:06:45 +00:00
Kentaro Hayashi
dd895ed99f Fix typos Recieve in methods
...Recieve... =>
...Receive...

Signed-off-by: Kentaro Hayashi <kenhys@xdump.org>
2025-03-17 09:38:18 -04:00
sithlord48
e996471e37 refactor: use enum for connections security level
based on barrier: 5c7d719
2025-02-17 16:26:29 +00:00
sithlord48
1085df54ed refactor: Reuse compliance
build files and documentation: MIT
  images / sources: GPL-2.0-only
  breeze icons: LGPL-2.0-only
  Microsoft MSM file, vc redist license
2025-01-27 17:05:47 -05:00
sithlord48
96092df4fc refactor: replace UInt32 with uint32_t 2025-01-14 20:30:45 +00:00
sithlord48
27eb83c981 refactor: replace SInt32 with int32_t 2025-01-14 20:30:45 +00:00
sithlord48
1ed49e7487 refactor: replace SInt16 with int16_t 2025-01-14 20:30:45 +00:00
sithlord48
ba11eba91e refactor: replace UInt8 with uint8_t 2025-01-14 20:30:45 +00:00
sithlord48
3991e0c1a1 refactor: use std::string in place of String
basedon: https://github.com/debauchee/barrier/pull/709
2025-01-08 00:11:34 +00:00
sithlord48
858c41c946 fix: #7942, Correctly substitute config name part
fixes https://github.com/deskflow/deskflow/issues/7942
2024-12-26 12:28:19 +00:00
Vamshi Maskuri
ab44559df6 fix(CVE-2021-42076): Enforce maximum message length to prevent memory exhaustion
based on barrier: debauchee/barrier@7ab8e01, debauchee/barrier@cc36982,
debauchee/barrier@e33c81b, debauchee/barrier@af90f39, debauchee/barrier@fd5295e
2024-12-26 10:45:21 +00:00
Vamshi Maskuri
937ac053fe fix(CVE-2021-42075): Close connection on app-level handshake failure
based on barrier: debauchee/barrier@deefecc
2024-12-18 17:23:27 +00:00
sithlord48
6b7291f4b1 chore: src/lib/server/Config remove redundant c_str call 2024-12-04 10:40:58 -05:00
sithlord48
2349ce7f52 chore: replace simple cases of typedef with using 2024-12-04 10:40:58 -05:00
sithlord48
1b13c843aa build(lib/server): Explict Sources 2024-10-24 15:11:03 -04:00
Nick Bolton
a5cd0fab9e feat: Option to change server protocol in GUI 2024-10-19 23:46:42 +01:00
Nick Bolton
512faeea28 test: Modularize hello back logic and add tests 2024-10-19 23:46:42 +01:00
sithlord48
47366f1272 feat: Dynamic client Barrier/Synergy hello back response to server 2024-10-19 23:46:42 +01:00
sithlord48
9b9ecb0d05 chore: Adjust Clang-format linter rules
120 Column Lines
 Block Indent for Bracket Align
 Custom Line Break Rules
 No Single Line Functions
2024-10-17 21:38:29 +01:00