Commit graph

2052 commits

Author SHA1 Message Date
sithlord48
8f7fbc0a21 refactor: messages::showReadOnlySettings, use name in title, enable translations 2025-06-09 16:33:27 +01:00
sithlord48
0f5a04825a refactor: Message::showClearSettings, enable translations and simplify method 2025-06-09 16:33:27 +01:00
sithlord48
b8835a8a5a refactor: Messages::showClientConnectError
slight reword for Already Connected error
 use QString::append to add to the message
 create a QMessageBox::warning style box for these errors
 enable translations
2025-06-09 16:33:27 +01:00
sithlord48
8bb6056469 refactor: Messages::showNewClientPrompt enable translations 2025-06-09 16:33:27 +01:00
sithlord48
3adcb64f57 refactor: Messages::showFirstConnectedMessage
add the app name into the title
      use QString::append to add to the string
      enable translations
2025-06-09 16:33:27 +01:00
sithlord48
bc9b1d1178 refactor: Messages::showFirstServerStartMessage
add app name to dialog title
    enable translations
2025-06-09 16:33:27 +01:00
sithlord48
e038dd2b0b chore: message::fileLine use QStringLiteral, multi-arg 2025-06-09 16:33:27 +01:00
sithlord48
1286c18e1d refactor: messages::showCloseReminder
use app name for title
   create message using append
   enable translations
2025-06-09 16:33:27 +01:00
sithlord48
5d94dd0dbf refactor: messages::showErrorDialog, use app name in title
construct QString without concat
return aftershowing fatal error dialog
Enable Translation for user facing strings
2025-06-09 16:33:27 +01:00
sithlord48
b3e03f2856 chore: messages, remove unneeded includes 2025-06-09 16:33:27 +01:00
sithlord48
b62e82e792 refactor: MainWindow, convert btnSaveServerConfig to QPushButton set the icons size 22x22 only when not on macos, make sure the button is square on macos 2025-06-05 21:20:10 +01:00
sithlord48
7837bf416e refactor: Mainwindow, rename btnApplySettings to btnRestartCore to better reflect what it does 2025-06-05 21:00:42 +01:00
sithlord48
d4d6cbb7fb feat: add restart action fixes #8542 2025-06-05 21:00:42 +01:00
sithlord48
d5910d77ec fix: core not starting if gui started minimized, remove firstShown and use open instead
fixes #8641
2025-06-03 17:28:48 +01:00
sithlord48
d01a023a8b chore: ApputilsUnix, remove unneeded includes 2025-06-02 14:28:51 -07:00
sithlord48
d246d9527a Feat: Define QT_NO_KEYWORDS, allowing us to use Qt in more places
must use Q_SIGNALS, Q_SLOTS and Q_EMIT in place of signals, slots and emit macros
2025-06-02 14:28:51 -07:00
sithord48
a31cff0225 chore: Cleanup windows includes 2025-06-02 21:55:36 +01:00
sithlord48
da06e97521 build: remove unused platform/MSWindowsUtils 2025-06-02 21:55:36 +01:00
sithlord48
7e4d43f1cc fix: (ui), ServerConfigDialog enable spinboxes and controls that depend on another option being enabled example being the heatbeat spinbox if heatbeat is enabled 2025-06-02 20:31:18 +01:00
sithlord48
7abaca76af chore: update CLI11 to v2.5.0 2025-05-28 19:22:13 +01:00
Povilas Kanapickas
5ee3fc41bd chore: arch: Remove XArch exception class
XArch no longer contains any extra functionality in addition to what
std::runtime_error nor it signifies a particular type of error.
based-on: 5b991692af
ported-by: sithlord48
2025-05-28 14:00:18 +01:00
Povilas Kanapickas
cab1eb9cee chore: arch: Derive XThread from std::exception
This is needed because by convention exceptions must derive from at
least std::exception.
ported from: 22aec16dc7
ported-by sithlord48
2025-05-28 14:00:18 +01:00
Povilas Kanapickas
51db919d8f chore: arch, remove XARCH_SUBCLASS Macro
ported from: 1f3cd0dab3
ported-by sithlord48
2025-05-28 14:00:18 +01:00
Povilas Kanapickas
314899ac7d chore: arch, Remove support for lazy error code to string evaluations
This functionality is not needed because in all code paths the error
code is immediately converted to string without actually using the lazy
evaluation functionality.

based-on: 53dff5b803
ported and expanded by sithlord48
2025-05-28 14:00:18 +01:00
Povilas Kanapickas
d597d023b1 chore: use std::unique_ptr for eventQueueHandlers
ports input-leap/5044b79a4f98ea5da0b8cbe950123f061d4c1c5f
ported-by sithlord48
2025-05-28 09:54:04 +01:00
Povilas Kanapickas
807e60ded2 chore: use std::unique_prt for EventQueue's Buffer
port input-leap/9dbfd551cda4367bdc8067b5c3ca9c4027494503
ported-by sithlord48
2025-05-28 09:54:04 +01:00
Povilas Kanapickas
0b4a2e0e5b chore: use std::unique_ptr for IDataSocket
port-of input-leap/836e08b0642ad158ecedc44e59a3bd3c61b56141
ported-by sithlord48
2025-05-28 09:54:04 +01:00
sithlord48
9eabbb690c chore: MSWindows only items initilize members in header 2025-05-28 09:42:08 +01:00
sithlord48
3eb3969a01 chore: use final for overrides and remove virtual for non base classes 2025-05-28 09:42:08 +01:00
sithlord48
d2ac36f3ed chore: make more const methods 2025-05-28 09:42:08 +01:00
sithlord48
e6a374369b chore: use const for more local ref and pointer vars 2025-05-28 09:42:08 +01:00
sithlord48
9c56fa5dda chore: Combine unnessessary multi level if into less fewer checks 2025-05-28 09:42:08 +01:00
sithlord48
6875969255 chore: static_cast to replace reinterpret_cast where possible 2025-05-28 09:42:08 +01:00
sithlord48
aa1eaf601c chore: SecureUtils, do not use final for stringVar name 2025-05-28 09:42:08 +01:00
sithlord48
f77213af04 chore: ActionDialog, remove empty statement 2025-05-28 09:42:08 +01:00
sithlord48
a4f1a382d3 chore: use ranged for in ClientListener::cleanupClientSockets 2025-05-23 10:19:11 -07:00
sithlord48
647201cd37 refactor: server/Config to the variable initializer and condition part of the for loop when checking for a valid screen name 2025-05-23 10:19:11 -07:00
sithlord48
e24b1c4b68 chore: use a const Ref for ServerConnection client name check 2025-05-23 10:19:11 -07:00
sithlord48
475b895755 chore: initialize class vars using the order class define, initilizer list, constructor 2025-05-23 10:19:11 -07:00
sithlord48
593e53370a chore: rename a missed namespace from synergy::gui => deskflow::gui 2025-05-23 10:19:11 -07:00
sithlord48
be6a4f6b4d chore: ScreenSettingsDialog rename ui_ => ui 2025-05-23 10:19:11 -07:00
sithlord48
929131d10b refactor: Log Error stop the core process if unable to write to the required fingerprint database 2025-05-23 18:08:41 +01:00
sithlord48
767919b342 refactor: consolidate IArchString subclasses into ArchString 2025-05-23 17:58:36 +01:00
sithlord48
4224215991 chore: make IArchString::EWideCharEncoding a enum class 2025-05-23 17:58:36 +01:00
sithlord48
45090d6b85 chore: IArchString clean up remaing code smells 2025-05-23 17:58:36 +01:00
sithlord48
476f3ba243 refactor: remove Ifdef around iso_level5 2025-05-23 17:19:55 +01:00
sithlord48
a33574e1bd chore: use more ranged for loops 2025-05-22 20:46:41 +01:00
sithlord48
456afaa13e chore: use emplace_back where possible 2025-05-22 20:46:41 +01:00
sithlord48
17f12d8334 chore: ClientApp remove unused restartRetryTimer and nextRetryTimer, use RETRY_TIME directly in ClientApp instead 2025-05-22 20:46:41 +01:00
sithlord48
723671c2e5 chore: remove // from inside comment blocks 2025-05-22 20:46:41 +01:00
sithlord48
5a90b51e97 chore: use string_view in place of string where possible 2025-05-22 20:46:41 +01:00
sithlord48
fe12972e83 chore: use const pointer / ref where possible 2025-05-22 20:46:41 +01:00
sithlord48
9bdb4252e5 chore: remove goto in EventQueue, instead use a private processEvent method 2025-05-22 20:46:41 +01:00
sithlord48
c73729e72e chore: static number number of priorities 2025-05-22 20:46:41 +01:00
sithlord48
04805d9a7e chore: mark explicit methods 2025-05-22 20:46:41 +01:00
sithlord48
3cf0fb89ef chore: add comment to empty methods 2025-05-20 16:20:07 +01:00
sithlord48
52b0c1f061 chore: use auto or (const auto) where possible 2025-05-20 16:20:07 +01:00
sithlord48
c224cd4661 chore: declare const methods recommened by sonar 2025-05-20 16:20:07 +01:00
sithlord48
635962618f chore: define only one variable per line 2025-05-20 16:20:07 +01:00
sithlord48
0ff72441e6 chore: use c++17 style if,switch init-initilizer where possible
chore: correct spelling of "colon" in NetworkAddresses variables
chore: correct some multi line defines near needed init-initilizers
2025-05-20 16:20:07 +01:00
sithlord48
bdffda9a2f chore: replace typedef with using 2025-05-20 16:20:07 +01:00
sithlord48
cac63937ff chore: cleansmells in ArchDaemon 2025-05-20 16:20:07 +01:00
sithlord48
a5e5bbc2e4 fix: race case if first run message is up and a client connects 2025-05-20 12:12:54 +01:00
Nick Bolton
34f6186941 fix: Disable the save button when config not writable 2025-05-19 22:10:41 +01:00
sithlord48
486b5a491f chore: LogOutputers add comments to empty overrides 2025-05-19 21:48:27 +01:00
sithlord48
037fee0e59 refactor: remove archConsole use its only implemented method directly in logOutputters 2025-05-19 21:48:27 +01:00
sithlord48
a9e0c62c24 refactor: link mt to base 2025-05-19 21:35:08 +01:00
sithlord48
43a51434ce chore: remove unused MinimalApp Class 2025-05-19 21:35:08 +01:00
Nick Bolton
eaa4c71d6e fix: Show first server start message only in server mode 2025-05-15 17:40:17 +01:00
sithlord48
393a006773 fix settings modifiers initilization, move initization to header
fixes: #8587
2025-05-15 17:25:08 +01:00
sithlord48
332e6c4a4d refactor: do not write sha1 to localdb and no longer send sha1 as part of comparison 2025-05-15 15:46:16 +01:00
Sam Umbach
14cb921d4c Resolve deprecated-enum-float-conversion compiler warnings
- Observed on macOS Monterey 12.7.6 with cmake version 4.0.1, Homebrew clang version 20.1.4, Target: x86_64-apple-darwin21.6.0
2025-05-14 11:05:41 -04:00
sithlord48
de583145d0 chore: remove unused deskflow::string methods toHex, fromHex, uppercase, fromHexChar 2025-05-13 11:32:02 -04:00
sithlord48
0309d35aef feat: port fingerprint info into Qt
mv FingerprintData -> Fingerprint
2025-05-13 11:32:02 -04:00
sithlord48
c4704649ea refactor: make sure settings dialog pushes all options to the top 2025-05-13 15:48:33 +01:00
sithlord48
33edb6ce01 refactor: simplify wayland warnings remove waylandwarnigns dialog test 2025-05-12 13:48:21 +01:00
Tomaz Canabrava
af383decca chore: Type fixes / Const correctness 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
8526facbe9 refactor: Fixes, Use enum instead of cast to int 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
2b3ecd39c6 refactor: ScreenCorners, Use enum instead of cast to int 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
49589ae4aa refactor, Modifiers, Use enum instead of cast to int 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
8ce6a07d18 refactor: Simplify Mainwindow, autoAddScreen also Removes warning 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
a8eb772b68 chore: Mainwindow, Send const-ref 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
0916009601 chore: Add nodiscard to methods 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
f5cb636b31 chore: MainWindow, Remove unimplemented methods 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
7ced794317 refactor: Screen, Mark methods as no discard, remove uneeded method 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
7c279ec72d refactor: No else after return 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
83a8d1c4ac refactor: Screen, simplify init call 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
84a9367124 refactor: Screen, remove uneeded constructor 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
aaeef7905a refactor: Initialize value on constructor 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
a0d0936433 refactor: Use smaller integers on enums
We do not have > 255 values here.
2025-05-09 12:27:56 +01:00
sithlord48
8f53b88bb6 chore: remove unused tests
Remove Unused Mocks
Remove remaing uses of TEST_ENV and its guarded items
2025-05-08 15:26:44 +01:00
sithlord48
9d867f6146 refactor: port deskflow/keyMapTest to QtTests
remove TEST_ENV items from KeyMap
KeyMap and KeyMapTests are friends
2025-05-08 15:26:44 +01:00
sithlord48
632be4b240 refactor: port gui/ScreenTest to QtTests
remove TEST_ENV items from Screen
2025-05-08 15:26:44 +01:00
sithlord48
38dc845c72 refactor: port serverConfigTests to QtTests
remove TEST_ENV items from server/Config
2025-05-08 15:26:44 +01:00
sithlord48
b56a282a9c refactor: port ServerTests to QtTests
remove TEST_ENV items from Server
2025-05-08 15:26:44 +01:00
sithlord48
5365e34f08 feat: remove drag and drop support, its broken on all platforms 2025-05-08 09:47:41 -04:00
sithlord48
55a7fa3266 Port simplified EventTypes from 8b23570379 2025-05-05 17:17:01 -04:00
sithlord48
118f867fd1 refactor: Remove unused IEventQueue::getRegisteredType()
ported from a5b6017235
2025-05-05 17:17:01 -04:00
sithlord48
99dae58fd3 chore: clean up macos code smell missed by sonarscan 2025-05-03 21:23:15 +01:00
sithlord48
e9ccd513f7 chore: clean up windows code smells missed by sonarscan 2025-05-03 21:13:09 +01:00
sithlord48
903401796e refactor: Remove use of DESKFLOW_RESET_ALL and all users to pass --reset switch to deskflow-gui instead 2025-05-03 21:09:41 +01:00
sithlord48
d643e4b189 chore: PrimaryClient, use default for deconstructors / constructors 2025-05-02 12:12:17 +01:00
sithlord48
c8734755c5 chore: InputFilter, use default for deconstructors / constructors 2025-05-02 12:12:17 +01:00
sithlord48
edea3b0df1 chore: server/Config use default for deconstructors 2025-05-02 12:12:17 +01:00
sithlord48
f4264d71a1 chore: ClientProxy1_6 use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
6ffd0eb471 chore: ClientProxy1_4 use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
7619928d56 chore: ClientProxy1_3 use override where possible 2025-05-02 12:12:17 +01:00
sithlord48
d70c7fe720 chore: ClientProxy1_2 use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
b26ca77ff1 chore: ClientProxy1_1 use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
68db2c3484 chore: BaseClientProxy use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
81c19c6ee8 chore: XClipboardUTF8Converter use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
1276a4a29c chore: XClipboardUCS2Converter use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
d97f4d87ad chore: XClipboardTextConverter use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
d5cbd002a9 chore: XClipboardHTMLConverter use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
31a6fd23e7 chore: XClipboardBMPConverter use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
f6c6d4e3a7 chore: XClipboardAnyBitmapConverter use default for constructor / deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
5801b92636 chore: XSocket use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
b427ac91c2 chore: TCPSocketFactory use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
e87c596fbe chore: SecureSocket, add missing nullptr replacement 2025-05-02 12:12:17 +01:00
sithlord48
35b4749627 chore: XThread use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
6b2a28600a chore: CondVar, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
600378b72d chore: StreamBuffer, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
8e24689f72 chore: IStream, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
07f9c4ba47 chore: AddClientDialog, add missing nullptr replacement 2025-05-02 12:12:17 +01:00
sithlord48
9d476e143e chore: KeySequence, add missing nullptr replacement 2025-05-02 12:12:17 +01:00
sithlord48
6bcdd4ebe7 chore: DataDownloader, use default for deconstructor, add missing nullptr replacement 2025-05-02 12:12:17 +01:00
sithlord48
9085468d1c chore: AppUtilUnix, use default for deconstructors 2025-05-02 12:12:17 +01:00
sithlord48
7bace4d36d chore: XScreen, use default for deconstructors 2025-05-02 12:12:17 +01:00
sithlord48
ca0d095283 chore: XDeskflow, use default for deconstructors 2025-05-02 12:12:17 +01:00
sithlord48
ace5b54912 chore: ServerArgs, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
c99767c8b7 chore: ServerApp, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
297b781578 chore: PlatformScreen, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
8c4dc001bf chore: PacketStreamFilter, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
9ca13a65d1 chore: keystate: using nullptr 2025-05-02 12:12:17 +01:00
sithlord48
73566c061d chore: Keymap, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
ed3118b81a chore: DragInformation, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
cc209b9b1f chore: Clipboard, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
ee22c31f32 chore: ClientArgs, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
f376b049e4 chore: ClientApp, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
57e3ff1fab chore: ArgBase, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
c39f69b64d chore: AppUtil use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
218a506970 chore: MinimalApp, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
57cb7227a4 chore: Interface.h, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
6aabb1e858 chore: XBase, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
9aec1ad479 chore: TMethodEventJob, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
c8d4a2186a chore: TMethodJob use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
f68744a36d chore: Stopwatch, use default for deconstructor and explicit constructor 2025-05-02 12:12:17 +01:00
sithlord48
183d660186 chore: PriorityQueue, use default for deconstructor / constructors 2025-05-02 12:12:17 +01:00
sithlord48
e20ef3ae55 chore: LogOutputters, use default for deconstructor / constructors 2025-05-02 12:12:17 +01:00
sithlord48
0bfb95996a chore: FunctionJob, use default for deconstructor 2025-05-02 12:12:17 +01:00