sithlord48
e3f940c70a
refactor: Simplify CoreProcess::QuoteArgs, use QString::Simplify and simplify logic in the loop
2025-10-13 08:34:12 -04:00
sithlord48
bb1e2ecc78
refactor: makeQuotedArgs is now a static private member or CoreProcess
2025-10-13 08:34:12 -04:00
sithlord48
8d0c368c8f
refactor: CoreProcess::start return early if called with coreMode of None
2025-10-13 08:34:12 -04:00
sithlord48
9e94a4fe0e
refactor: CoreProcess::start, early return if process is already started
2025-10-13 08:34:12 -04:00
sithlord48
a346ff6161
chore: X11LayoutsParser remove stray semi colon
2025-10-13 12:45:44 +01:00
sithlord48
eed4b49ea0
chore: remove unused member App::configSection
2025-10-13 12:45:44 +01:00
sithlord48
88c0c49ba3
chore: remove unused member App::s_helpVersionArgs
2025-10-13 12:45:44 +01:00
Nick Bolton
f64d430f96
fix: Remove assertion for unused name parameter in daemonize function
2025-10-13 07:23:59 -04:00
sithlord48
04b3f5c769
chore: remove unused name parameter from ARCH->daemonize
2025-10-09 13:30:41 +01:00
sithlord48
aae3067f03
fix: stop retry if core has crashed
...
fixes : #9003
2025-10-07 14:57:22 +01:00
sithlord48
8ea2671e65
refactor: cleanup daemonApp args
2025-10-07 13:01:47 +01:00
sithlord48
12ea23a3bd
refactor: App::run remove unused args
2025-10-07 13:01:47 +01:00
sithlord48
0bc82c3a57
refactor App::runInner remove unused argc and argv
2025-10-07 13:01:47 +01:00
sithlord48
3270b40455
refactor: App, remove args from static startup methods to make StartupFunc no longer take args
2025-10-07 13:01:47 +01:00
sithlord48
9f2327932d
refactor: IApp::start remove unused args
2025-10-07 13:01:47 +01:00
sithlord48
1b44a24d75
refactor: IApp::initApp remove unused args
2025-10-07 13:01:47 +01:00
sithlord48
8db65da345
refactor: use QString to set log level value
...
fixes : #8999
2025-10-07 12:40:18 +01:00
sithlord48
06263ceaad
feat: drop cli11
2025-10-01 10:55:03 -04:00
sithlord48
4a5f173422
feat: remove toml config file only use our QSettings based format
...
remove deskflow/Config and related tests
2025-10-01 09:41:12 -04:00
sithlord48
e30025ea8b
feat: SettingsDialog, add control to adjust scrollSpeed option for clients
2025-09-30 06:39:54 -04:00
sithlord48
59d860874e
refactor: App::ParseArgs remove all unneeed arguments
2025-09-30 06:39:54 -04:00
sithlord48
5978694d95
chore: remove unused ArgParser
2025-09-30 06:39:54 -04:00
sithlord48
d98f8a524d
remove: argsBase
2025-09-30 06:39:54 -04:00
sithlord48
37827f0540
refactor: remove ClientArgs
2025-09-30 06:39:54 -04:00
sithlord48
6fa8ba087a
refactor: move remoteHost to coreArgs
2025-09-30 06:39:54 -04:00
sithlord48
a78959e66f
refactor: move invert-scroll to coreArgs
2025-09-30 06:39:54 -04:00
sithlord48
5fc00f7af4
refactor: use bool for invert scrolling
2025-09-30 06:39:54 -04:00
sithlord48
2cb36777f9
refactor: move languageSync to coreArgs
2025-09-30 06:39:54 -04:00
sithlord48
b0fe79d527
refactor: move yscroll to coreArgs
2025-09-30 06:39:54 -04:00
sithlord48
efebe9ca56
refactor: remove ServerArgs
2025-09-30 06:39:54 -04:00
sithlord48
bf7a50ab0e
refactor: move -c --config to coreArgs
2025-09-30 06:39:54 -04:00
sithlord48
cfedfc2c1e
refactor: move peerCert option to coreArgs
2025-09-30 06:39:54 -04:00
sithlord48
cfd580fb21
refactor: move ArgsBase:m_pname to App
2025-09-30 06:39:54 -04:00
sithlord48
1884ab3555
refactor: move --no-hooks to coreArgs
2025-09-30 06:39:54 -04:00
sithlord48
eeaf139bd9
refactor: move no-restart to CoreArgs
...
chore: Client remove unused ClientArgs member m_args
2025-09-30 06:39:54 -04:00
sithlord48
295137dbd2
refactor: CoreArgs Add display option
2025-09-30 06:39:54 -04:00
sithlord48
c2ee366e23
refactor: move preventsleep option into CoreArgs
2025-09-30 06:39:54 -04:00
sithlord48
a8348b1ccb
refactor: move tls-cert to coreArgs
2025-09-30 06:39:54 -04:00
sithlord48
ff4c9dc421
refactor: move enable-crypto to new core option secure to set the TLS setting
2025-09-30 06:39:54 -04:00
sithlord48
53b36801e1
refactor: move Log option to coreArgs
2025-09-30 06:39:54 -04:00
sithlord48
f3a1bbaf5b
refactor: move setting of log level to CoreArgParser
2025-09-30 06:39:54 -04:00
sithlord48
05f377e21b
refactor: Handle Name option in CoreArgParser
2025-09-30 06:39:54 -04:00
sithlord48
ead49c4025
refactor: move address option to deskflow-core, split into --interface (-i) and --port (-p) options
2025-09-30 06:39:54 -04:00
sithlord48
5e02adc772
refactor: deskflow-core take over --version arg for App class
...
change the serverAppTest to not call version
2025-09-30 06:39:54 -04:00
sithlord48
10f34f214f
refactor: new Classes CoreArg and CoreArgParser to use to create and parse core options
2025-09-30 06:39:54 -04:00
sithlord48
6f574a3076
refactor: set const for Reverse FQDN name to use for deployment on linux
2025-09-30 06:17:23 -04:00
sithlord48
dc86538456
feat: Set app id on wayland this is required for restore tokens to work correctly
2025-09-30 06:17:23 -04:00
sithlord48
7698980576
refactor: simplify desktop::platform::isWayland
2025-09-30 06:17:23 -04:00
sithlord48
9fe445ebd0
feat: add methods to check if running from a sandbox, flatpak and or snap
2025-09-30 06:17:23 -04:00
sithlord48
087afd22b2
refactor: use CoreProcess::m_appPath to store app
2025-09-28 10:53:16 -04:00
sithlord48
8192d7b2d8
refactor: remove Settings::Client::Binary and Settings::Server::Binary use kCoreBinName, instead
2025-09-28 10:53:16 -04:00
sithlord48
d9ce9c4f10
chore: remove unused CoreProcess::extracted
2025-09-28 10:53:16 -04:00
sithlord48
4dfc98c93c
fix: SettingsDialog, ensure debug warning is shown without changing the combobox
2025-09-28 10:36:23 -04:00
sithlord48
abbfc91192
chore: PriorityQueue::comp add no_unique_address attritribute
2025-09-25 15:01:17 +01:00
sithlord48
e3f5e045b7
chore: FileLogOutputter::write use Static QFile::rename in place of local file method
2025-09-25 15:01:17 +01:00
sithlord48
7f7e7de841
chore: SecureSocket serviceConnect / serviceAccept make anonymous ISocketMultiplexer a pointer const
2025-09-25 15:01:17 +01:00
sithlord48
bd63d54a9e
chore: EiScreen::m_powerManager add no_unique_address
2025-09-25 15:01:17 +01:00
sithlord48
9dae55fc6f
chore: remove unused ClientProxy1_5::m_events
2025-09-25 15:01:17 +01:00
sithlord48
e35a2b1c29
chore: remove unused ClientProxy1_7::m_events
2025-09-25 15:01:17 +01:00
sithlord48
4157367aaa
chore: remove unused InputFilter::RestartServer::m_events
2025-09-25 15:01:17 +01:00
sithlord48
3945dc927c
chore: remove unused ArgsBase::m_disableTray
2025-09-25 14:41:35 +01:00
Nick Bolton
801ada88b7
fix: correct spelling of convertLayoutToISO in X11LayoutsParser
2025-09-25 09:18:06 -04:00
Nick Bolton
c234f2fc66
fix: Do not reuse listen sockets on Windows
2025-09-25 14:00:48 +01:00
sithlord48
ff1726677b
chore: remove unused --service and --relaunch options for windows
2025-09-24 16:28:19 +01:00
sithlord48
57e34ded54
chore: rename IApp::standardStartup -> IApp::start
2025-09-24 16:28:19 +01:00
sithlord48
03e014c753
feat: Remove daemon / no-daemon option
2025-09-24 16:28:19 +01:00
Roman Vasiyarov
9f8c45b449
fix: XWindowsScreen: stop centering panned screens on client when leaving screen
...
panned screens still needs `xtestIsXineramaUnaware` option enabled. this change
forcefully uses XTest only when leaving
useful examples:
* double 1 FullHD screen (main output) by:
`xrandr --fb 3840x1080 --output DP-1 --panning 3840x1080+0+0/3840x1000+0+80`,
leaving top 80 pixels for moving mouse out without actual panning
* dedicate right half of framebuffer to FullHD TV (second output):
`xrandr --fb 3840x1080 --output HDMI-0 --panning 1920x1080+1920+0`
2025-09-23 12:12:59 +01:00
Roman Vasiyarov
bf5b0de6ee
fix: XWindowsScreen: properly calculate xrandr/xinerama screens
...
this allows screens to overlap, use panning, etc
2025-09-23 12:12:59 +01:00
Roman Vasiyarov
3aef2f4309
chore: XWindowsScreen: remove duplicate function
2025-09-23 12:12:59 +01:00
sithlord48
35c7fe7fc4
fix: screensettingsDialog, do not allow aliases to be ip addresses
...
fixes : #8952
2025-09-15 16:31:52 +01:00
sithlord48
612ca91f9c
chore: rename XWindowsPowerManager => XDGPowerManager
...
fixes: 8949
2025-09-15 13:21:51 +01:00
Nick Bolton
fcdea215be
Reapply "refactor: App use Uniqueprt for SocketMultiplexer"
...
This reverts commit 6f18cf74c5 .
2025-09-12 16:03:22 +01:00
Nick Bolton
6f18cf74c5
Revert "refactor: App use Uniqueprt for SocketMultiplexer"
...
This reverts commit 4d738b4784 .
2025-09-12 15:03:52 +01:00
Nick Bolton
162cb85811
fix: Improve output loop error handling in MSWindowsWatchdog
...
Prevents high CPU usage while waiting for data (ERROR_NO_DATA)
2025-09-12 13:17:50 +01:00
Nick Bolton
5ea8d0326a
fix: Use QString for Windows error functions
...
Was returning only first char of error message (mild-mojibake)
2025-09-12 13:17:50 +01:00
Louis des Landes
7a2591a1fa
fix: wayland sleep inhibit on client
...
Fixes #8827
Adds the XWindowsPowerManager to the EiScreen as, despite the name, this
works on Wayland as well.
2025-09-12 10:54:25 +01:00
sithlord48
2f2754ab97
refactor: LogDock::eventFilter mark as override
2025-09-11 14:53:20 +01:00
sithlord48
9883fb988a
refactor: remove Arch::hostname, use QSysInfo::machineHostName directly in the only place its used
2025-09-11 14:53:20 +01:00
sithlord48
38a74d7d0f
refactor: Arch::getHostName(), use QSysInfo::machineHostname in place of system specific impl
2025-09-11 11:18:12 +01:00
sithlord48
949f1d6534
refactor: MainWindow, minimize / restore action use window-*-pip icons
2025-09-11 10:57:08 +01:00
sithlord48
de42f53d68
refactor: new LogDock, handle hiding and float correctly'
2025-09-11 10:57:08 +01:00
sithlord48
c4c2f7f37f
feat: begin to use QStrings for strings
...
feat: get windows building with the UNICODE forced by using Qt
refactor: remove ARCHString use QString to convert to / from utf8
build: (arch) link to common
build: (base) link to arch
build: (io) Link to common
build: (client) link to common
build: (server) link to common
fix: Append to log file instead of creating a new one each log line
refactor: Trim cipher description for neater log output
fix: Update log messages to use wide string format for Unicode support
fix: Correct event creation to use wide string for Unicode compatibility
refactor: Use QStringDecoder for UTF-8 handling on Windows Daemon child process
fix: Use correct wide type for Win32 consts
2025-09-10 18:15:19 +01:00
sithlord48
66a022a012
fix: Adjust log level for unconfigured client as we react to this in the gui
2025-09-10 14:31:13 +01:00
Nick Bolton
19eefd65c1
fix: Prevent log visibility toggle when window is hidden
2025-09-10 11:51:37 +00:00
Nick Bolton
ad383ad9d4
chore: Remove unused daemon installation and uninstallation methods
2025-09-10 11:32:02 +00:00
sithlord48
539ddcaf48
refactor: ScreenConfigDialog, make sure to populate the screen model with the server config after its been made
2025-09-09 15:59:07 +00:00
sithlord48
b30f8d253c
refactor: XWindowsKeyState remove name for unused KeyId in remapKeyModifiers
2025-09-05 11:52:17 +01:00
sithlord48
c477d0fcc6
refactor: XWindowsKeyState::init remove unused display var
2025-09-05 11:52:17 +01:00
sithlord48
bc63961e7e
refactor: EIEventQueueBuffer remove unused screen from constructor
2025-09-05 11:52:17 +01:00
sithlord48
30ce0bdf45
refactor: SecureSocket, remove names for unused parameters for socket service accept and serviceConnect
2025-09-05 11:52:17 +01:00
sithlord48
dd66dd21bb
refactor: IDataSocket, add maybe_unused for constructors event pointer
2025-09-05 11:52:17 +01:00
sithlord48
27075a0260
refactor: StreamBuffer::write use emplace when adding m_chunks
2025-09-05 11:52:17 +01:00
sithlord48
6cfd89af8c
refacor: ServerConfigDialog::toggleClipboard use static access to ServerConfig::defaultClipboardSharingSize
2025-09-05 11:52:17 +01:00
sithlord48
8e99700657
refactor: ServerConfigDialog mark that deselected maybe_unused when calling the selectionChanged for our lists
2025-09-05 11:52:17 +01:00
sithlord48
e21c4cdd4d
refactor: CoreProcess::addGenericArgs remove unused processMode var
2025-09-05 11:52:17 +01:00
sithlord48
88efc14bc2
refactor: ServerConfig, use static access to switchCornerNames()
2025-09-05 11:52:17 +01:00
sithlord48
a9d518fbc8
refactor: X11LayoutParser:appendVectorUniq, capture elem by ref in our lambda
2025-09-05 11:52:17 +01:00
sithlord48
43b1014700
refactor: X11LayoutParser::getAllLanguageData , do not shadow variables from outer for loop with the inner one (i.e use differnt nanes for each var)
2025-09-05 11:52:17 +01:00
sithlord48
2e722bdfeb
refactor: Server::handleToggleScreenEvent remove name of the incomming event var to indicate its not used in the method
2025-09-05 11:52:17 +01:00
sithlord48
aedbffa809
refactor: server/Config use empty() to check if args are empty
2025-09-05 11:52:17 +01:00
sithlord48
dc0db9d192
refactor: LogWidget remove unused Q_SIGNALS delclaration
2025-09-05 11:52:17 +01:00
sithlord48
9f3e724218
refactor: ScreenSettingsDialog::removeAlias make const
2025-09-05 11:52:17 +01:00
Jonathan Wakely
f98f8b10d1
refactor: Construct std::string outside critical section
...
There's no need to hold the mutex while constructing a `std::string`
from the `char` string.
Also use `inet_ntop` instead of the potentially thread-unsafe
`inet_ntoa` that might use a static buffer for the result.
This makes the `INet` case match the `INet6` case below.
2025-09-04 16:56:46 +01:00
Jonathan Wakely
b788d63044
refactor: Give internal linkage to global mutex
...
The `static` keyword was removed by #8674 but I think it should be
restored so that this global can't clash with anything else called
`::s_mutex` elsewhere in the executable.
2025-09-04 16:56:46 +01:00
sithlord48
d5936a9e08
refactor: ScreenSettingsDialog, do not use auto connect slots
2025-09-03 10:38:59 +01:00
sithlord48
81c53d3690
refactor: ScreenSettingsDialog, conform to naming conventions
2025-09-03 10:38:59 +01:00
sithlord48
89003082d7
refactor: continue to improve the screen settings dialog ui
2025-09-03 10:38:59 +01:00
Tomaz Canabrava
fe1a48fa28
refactor: Rework Computer Settings
...
Removed almost half of the lines, and still made it
more pretty.
2025-09-03 10:38:59 +01:00
Tomaz Canabrava
c4b2f91424
refactor: Move ServerConfig to the config folder
2025-09-03 10:38:59 +01:00
Tomaz Canabrava
f16c13fa54
refactor: ScreenSettingsDialog, Constify validator variables
2025-09-03 10:38:59 +01:00
sithlord48
43ce3c50e5
refactor: move log to dockwidget simplifying resize code
2025-09-01 18:12:41 +01:00
sithlord48
204a6b5a44
refactor: New LogWidget to handle log output in the mainwindow
2025-09-01 18:12:41 +01:00
sithlord48
a6dc455477
fix: Settings reset on windows, create new profile dir when not in native mode
...
fixes : #8916
2025-09-01 17:22:15 +01:00
sithlord48
138ede0536
refactor: use If in place of switch that looks for single case
2025-09-01 16:57:39 +01:00
sithlord48
eae089d3ec
chore: ServerConfigDialog, conform to naming standards for members
2025-09-01 16:57:39 +01:00
sithlord48
340df69ca2
refactor: ServerConfigDialog, set members in alphbetical order, correct initlization order
2025-09-01 16:57:39 +01:00
sithlord48
507c98adff
refactor: EIKeyState::fakeKey use if in place of a switch that cares only about a single case
2025-09-01 16:57:39 +01:00
sithlord48
0501f2892d
chore: Messages::showClientError remove unneeded capture from lambda
2025-09-01 16:57:39 +01:00
Kris
104d2facdb
feat: add switchToNextScreen hotkey to cycle through computers
2025-09-01 11:39:52 -04:00
Kris
398c9726f3
fix: fixes the mouse label issue
2025-09-01 11:39:52 -04:00
sithlord48
eb2f885983
chore: conform CoreProcess to naming standards
2025-09-01 16:18:02 +01:00
Nick Bolton
4a16931c5d
refactor: Remove QProcessProxy and simplify CoreProcess
...
Making a proxy class for QProcess to make GTest work is an excellent example of over-abstraction making simple things hard to do. I just wanted to call a function on QProcess and had to jump through hoops to do it.
Bye bye QProcessProxy! We can do much better with QTest.
2025-09-01 16:18:02 +01:00
Nick Bolton
78b83c5639
fix: Use correct log function for process exit status in onProcessFinished
2025-09-01 08:05:07 -04:00
sithlord48
9cf25c4caf
feat: Allow suppression of generic client connection dialog
...
fixes 8907
2025-09-01 10:57:59 +01:00
sithlord48
f0e02724ee
refactor: CoreProcess::onProcessFinished add using for ProcessState enum
2025-09-01 10:04:52 +01:00
sithlord48
60e71aad38
fix: missing IPC messages
...
fixes #8905
2025-09-01 10:04:52 +01:00
sithlord48
4e8a67925f
refactor: Add Tooltip to log levels and show a label with info about debug level affecting performance
...
fixes : #8889
2025-08-28 00:45:40 +01:00
sithlord48
cba3881f41
refactor: Move all messages that are checked for by GUI in the log to new IPC Level so the gui can work with any filter level
2025-08-28 00:45:40 +01:00
sithlord48
78eb353985
refactor: Settings Allow all log levels to be shown in the Gui
2025-08-28 00:45:40 +01:00
sithlord48
e7880b72f1
chore: Mainwindow convert comments for regenerateLocalFingerprint to doxygen comments
2025-08-27 19:18:59 -04:00
sithlord48
d864361085
feat: Improve fingerprint comparison dialog, to show both remote and local prints (server is always on left of dialog)
...
fixes : #8866
2025-08-27 19:18:59 -04:00
sithlord48
66366dd95b
refactor: Fingerprintprevew, Add optional title text, remove label for cypher type and add option to toggle the sha mode so art or hash is visible
2025-08-27 19:18:59 -04:00
sithlord48
2c6c65f71e
refactor: MainWindow new localFingerprint method to read the local fingerprint from the db, this is split from showMyFingerprint
2025-08-27 19:18:59 -04:00
sithlord48
9eede5470c
refactor: TLSUtil do not check it tls is enabled before regenerating the certificate
...
fixes #8890
2025-08-27 05:51:15 -04:00
Nick Bolton
07edccb469
fix: Add 'Hyper' key handling
...
In the X11 code, we mapped hyper to super, so perhaps it makes sense to do that here too:
`src/lib/platform/XWindowsUtil.cpp`
```
case XK_Super_L:
case XK_Super_R:
case XK_Hyper_L:
case XK_Hyper_R:
return kKeyModifierBitSuper;
```
2025-08-26 09:52:43 -04:00
Zhuofeng Wang
927075688c
fix: Pass ClientScrollDirection to EiScreen
2025-08-26 09:08:45 -04:00
sithlord48
b18c3b588f
refactor: EIKeyState, compare to the current state when seeing if modifiers are inactive, suggested by wismill
2025-08-26 11:23:29 +01:00
Nick Bolton
34c439b3de
refactor: Use single case to ignore mods in EI mod mask
2025-08-22 17:04:16 +01:00
Nick Bolton
934ddf1499
fix: Disable meta mod (fixes alt key bug)
2025-08-22 17:04:16 +01:00
Nick Bolton
4302d50a42
feat: Use xkb_keymap_mod_get_mask in EiKeyState if available
...
Introduced in xkbcommon v1.10.0
2025-08-22 16:06:03 +01:00
sithlord48
3e96c4d0aa
refactor: Include breeze fallback icons for connect and disconnect
2025-08-22 09:54:20 +01:00
sithlord48
d368b92165
refactor: CoreProcess::onProcessFinished Stop trying to restart the core process if its already running
2025-08-22 09:54:20 +01:00
sithlord48
97e3524a24
build: SecureSocket, include io/FileSystem in SecureSocket.cpp
2025-08-22 09:54:20 +01:00
sithlord48
299ebea0e2
refactor: replace QString::toStdString().c_str with qPrintable(...)
2025-08-22 09:54:20 +01:00
sithlord48
3a66969dec
refactor: add XdpRestoreToken to list of valid keys so its not removed if cleansettings is run
2025-08-21 07:54:21 -04:00
sithlord48
d3c0ce8895
refactor: move all exit codes to new ExitCodes
...
add new exitcode s_exitDuplicate for when exiting because of already running instance
2025-08-21 12:34:50 +01:00
sithlord48
26983dc0e4
refactor MainWindow, move start and restart inline with mode options
...
update labels for the mode buttons actions and menu actions
use callstart / callstop for connect and disconect icons
2025-08-20 16:09:08 -04:00
sithlord48
a0d75b28ba
refactor: SettingsDialog, group client options together into a groupClientOptions
2025-08-20 15:50:26 -04:00
sithlord48
e9cec877f2
fix: SettingDialog, only lock the check peers checkbox in updateTlsControls when in client mode
...
fixes #8870
2025-08-20 15:50:26 -04:00
sithlord48
0bb8ff646a
refactor: SettingsDialog, prevent updateControls from being called twice at startup
2025-08-20 15:50:26 -04:00
sithlord48
9268fef89d
refactor: SettingsDialog remove duplicate code by calling updateTlsControlsEnabled inside updateTlsControls
2025-08-20 15:50:26 -04:00
sithlord48
6f8b3f481d
refactor: adjust the help message for core to combine server and client message fixing man page deployment
2025-08-20 20:33:20 +01:00
sithlord48
3b2d7fc0b3
feat: Switch to deskflow-core instead of split binaries
2025-08-20 20:33:20 +01:00
sithlord48
7cac145500
fix: Allow Gui to work with core ,server or client binaries
...
fixes : #7951
2025-08-20 20:33:20 +01:00
sithlord48
b2aa638b1f
feat: Support Remote Desktop token persistance
2025-08-19 15:46:14 +01:00
sithlord48
2990a1f686
refactor: Server, reorder private member vars to avoid un unessary padding
2025-08-18 11:45:21 +01:00
sithlord48
c3f2c04a28
refactor: remove IAppUtil. AppUtil is the base class now
2025-08-18 11:45:21 +01:00
sithlord48
347cb46f15
refactor: remove IEventJob
2025-08-18 11:45:21 +01:00
sithlord48
bcb6c368b1
refactor: remove unneeded common/Common includes
2025-08-18 11:45:21 +01:00
sithlord48
a9e87d5ef5
refactor: remove INode class as base for Server and Client objects
2025-08-18 11:45:21 +01:00
sithlord48
4eec183598
refactor: remove IInterface class, that only adds a virtual construcor
2025-08-18 11:45:21 +01:00
sithlord48
6c6e5fc4d2
refactor: MainWindow use static for cleanup of QLocalServer
2025-08-15 12:15:40 +01:00
sithlord48
0d7d21aeb2
refactor: Action LockCursorMode => Action::LockCursorMode enum class
2025-08-15 12:15:40 +01:00
sithlord48
ea6f4ce221
refactor: Action SwitchDirection => Action::SwitchDirection enum class
2025-08-15 12:15:40 +01:00
sithlord48
1c7d5de01b
refactor Action::ActionType => Action::Type enum class
2025-08-15 12:15:40 +01:00
sithlord48
d2d28f5ad6
refactor: XWinowsUtil make s_keymap a std::array
2025-08-15 12:15:40 +01:00
sithlord48
04ca52b94e
fix: resolve issues with some swedish characters
...
fixes : #8839
2025-08-14 17:57:26 -04:00
sithlord48
0dfd4ebc4a
refactor: Mainwindow, adjust how and where the ip address is shown.
...
- Add a new method updateNetworkInfo to update lblIpAddresses
This method can be hooked to the system network info in the future
when we want to have this be more dynamic.
- Only show the IP address when in server mode.
- When showing the IP address show either the suggested IP or a message the user maybe offline
- Use the linkVisited color to for our error message
2025-08-12 13:04:09 -04:00
sithlord48
a7048f76f9
refactor: GUI, Mainwindow use the system hyperlink color to color the text of the 'primary' Ip address
2025-08-12 13:04:09 -04:00
sithlord48
8d92a8df68
refactor: On windows use the old malloc method to prevent random test failure in IKeyState
2025-08-12 12:14:21 -04:00
Pranav P
d6b53ea718
fix: failures in big endian machines tests
2025-08-12 16:56:17 +01:00
sithlord48
2e193c6a78
chore: PortalInputCapture, conform to naming conventions
2025-08-11 12:58:52 -04:00
sithlord48
f95230549a
chore: EiScreen: conform to nameing conventions
2025-08-11 12:58:52 -04:00
sithlord48
a13803df94
chore: EiKeyState, conform to naming conventions
2025-08-11 12:58:52 -04:00
sithlord48
2ba7fb2f05
chore: EiEventQueueBuffer, conform to naming conventions
2025-08-11 12:58:52 -04:00
sithlord48
9442295227
chore: remove unused HYPER key
2025-08-11 12:32:50 -04:00
sithlord48
8d87f3250d
refactor: ScreenSettingsDialog use qDeleteAll to clear list of items on alias remove
2025-08-11 12:32:50 -04:00
sithlord48
e700867a32
refactor: remove ServerConfig remove const qualifer from QString return
2025-08-11 12:32:50 -04:00
sithlord48
a21d48defb
refactor: reorder initilization order in XWindowEventQueueBuffer constructor
2025-08-11 12:32:50 -04:00
sithlord48
3770e2c39e
chore: XWindowsScreen::handleSystemEvent, remove unused Window variables
2025-08-11 12:32:50 -04:00
sithlord48
8d90515446
chore: define var on seperate line from type
2025-08-11 12:32:50 -04:00
sithlord48
db67550db3
refactor: server: use contains when possible
2025-08-11 12:32:50 -04:00
sithlord48
85e7d95188
refactor: server/Config use contains
2025-08-11 12:32:50 -04:00
sithlord48
651e093e04
refactor: clientProxy1_4 do not create pointless override that just call the baseclass
2025-08-11 12:32:50 -04:00
sithlord48
02fb9915bf
refactor: Arch, only define init override on windows, where its ambiguious
2025-08-11 12:32:50 -04:00
sithlord48
6153f64fb7
chore: remove uneeded casts
2025-08-11 12:32:50 -04:00
sithlord48
f91df1639b
refactor: make sure to state type of access to base class
2025-08-11 12:32:50 -04:00
sithlord48
63bd2e71b0
refactor: CoreProcess fully qualify enums used in signals
2025-08-11 12:32:50 -04:00
sithlord48
e1d00d59a4
refactor: ScreenSetupModel::isFull compaire same type of iterator
2025-08-11 12:32:50 -04:00
sithlord48
5def3f1f6a
refactor: DaemonApp add context object for lambda starting the thread
...
chore: DaemonApp, remove unnessary QObject:: for connect calls
2025-08-11 12:32:50 -04:00
sithlord48
6840e1e7eb
fix: Better description for InvalidProtocolException
...
fixes : #8830
2025-08-11 17:14:45 +01:00
sithlord48
85d89f9846
refactor: XArch Classes => Arch Exception Classes
2025-08-11 17:14:45 +01:00
sithlord48
8929f85bf7
refactor: XConfigRead => ServerConfigReadException
2025-08-11 17:14:45 +01:00
sithlord48
9601180e1b
refactor: XBase Classes => BaseException
2025-08-11 17:14:45 +01:00
sithlord48
64786ddcb7
refactor: XDeskflow Classes => DeskflowException Classes
2025-08-11 17:14:45 +01:00
sithlord48
e4a9d1eb78
refactor: XScreen Classes => ScreenException Classes
2025-08-11 17:14:45 +01:00
sithlord48
1b04b1137c
refactor: XIO Classes => IOException Classes
2025-08-11 17:14:45 +01:00
sithlord48
813b0c3828
refactor: mt/XThread Classes => mt/ThreadException Classes
2025-08-11 17:14:45 +01:00
sithlord48
22a358fb49
refactor: XMT Classes => MTException Classes
2025-08-11 17:14:45 +01:00
sithlord48
ada2813f9f
refactor: XSocket Classes => XSocketException Classes
2025-08-11 17:14:45 +01:00
sithlord48
906c07e4fd
fix: MainWindow::setHostName only check if the screen is existing when in server mode, In severmode update the serverConfig serverName to prevent a case where the server screen is on the grid with the old name breaking the layout
2025-08-11 16:49:25 +01:00
Nick Bolton
a4c0e30bb8
fix: Ignore Mod2 and Mod3 to make log quieter
2025-08-07 15:31:52 -04:00
Peter Hutterer
a5c9744258
fix: Account for more modifiers in the EI keymap calculation
...
Some modifiers, notably LevelThree, were not accounted for in the
modifier mask calculation. This leads to an incorrect keymap where some
key symbols were listed for keys without (or insufficient) modifiers.
Emulating those keys can then produce the wrong keysyms.
Reproducible with server and client on English(UK) layout and typing
e.g. [. That key has its own key AD11 (right of P) but is also on
the third level of AE08 (the 8 key). When the server sends the keyid 91
(for [) the client looks it up in the pre-generated keymap. It is found
first on the 8 key with no modifiers (because LevelThree was previously
ignored), hence the client simulates a key 8 press without modifiers.
This erroneously produced an 8 instead of the wanted [.
Fix this by ensuring that all modifiers are accounted for in the key
map. This fix is likely incomplete as it does not account for the full
virtual modifier to real modifier mappings possible (e.g. Mod5 *may* be
something other than AltGr) but it does push the can a bit further down
the road, for someone else to release the worms.
Closes : #8168
2025-08-07 15:31:52 -04:00
sithlord48
2a84ef0ebf
refactor: update log calls to LOG_... fixes #8819
2025-08-06 16:18:38 +01:00
Nick Bolton
9a9bd7e262
chore: Improve logging for active sides
...
For the longest time, this log line has bugged me:
```
active sides: e
```
It's hex, but it looks like a bug, since there's no `0x` prefix. Also, most humans can't read hex, so I added a string representation.
New version:
```
[2025-08-06T11:56:00] DEBUG: active sides: LRT (0x0e)
```
2025-08-06 08:38:00 -04:00
James Le Cuirot
47bb33e065
fix: update inclusion of climits and cstdint headers
...
For INT_MAX and SIZE_MAX.
2025-08-06 13:03:52 +01:00
sithlord48
40423397e3
refactor: Config remove redundant != Operator in server/Config
2025-08-06 11:44:38 +01:00
sithlord48
4955e8c2ba
refactor: Fingerprint, KeyMap, KeySequence and Action use default == operator
2025-08-06 11:44:38 +01:00
sithlord48
24480ce946
refactor: AppUtilUnix remove name from unused IEventQueue pointer
2025-08-06 11:44:38 +01:00
sithlord48
76d5ac0a34
refactor: KeyTypes::KeyModifierNameMapEntry, remove commented code
2025-08-06 11:44:38 +01:00
sithlord48
d20887f34a
refactor: KeyState::updateModifierState, use std::ranges::set_difference in place of std::set_difference
2025-08-06 11:44:38 +01:00
sithlord48
0cbc922478
refactor: MSWindowsDesks::getCursorPos initialize pos to 0,0
2025-08-06 11:44:38 +01:00
sithlord48
38866cf2c1
refactor: remove unneeed constructors from DisplayInvalidExecption
2025-08-06 11:44:38 +01:00
sithlord48
32165f5b58
refactor: IKeyState remove need for malloc in alloc methods
2025-08-06 11:44:38 +01:00
sithlord48
1968669a39
refactor: App make m_bye private access it from the method bye
2025-08-06 11:44:38 +01:00
sithlord48
3b2b8a9ebe
refactor: IKeyState: directly make string when spilting as arg to emplace
2025-08-06 11:44:38 +01:00
sithlord48
048ce47008
refactor: ServerConfig: used ranged loop to process neighbours
2025-08-06 11:44:38 +01:00
sithlord48
d321e2a874
refactor: TCPSocket Init m_socket before m_events
2025-08-06 11:44:38 +01:00
Nick Bolton
0352e1c6d6
chore: Improve logging in Server::onClipboardChanged
2025-08-05 14:41:50 -04:00
Nick Bolton
98d03fb098
chore: Improve logging in Server::handleClipboardGrabbed
2025-08-05 14:41:50 -04:00
Nick Bolton
739cdc1752
chore: Improve logging for DESKFLOW_MOUSE_ADJUSTMENT env var
...
We plan to move this elsewhere, but in the meantime, the DEBUG1 logging was too noisy. Also fixed some code style that was bugging me.
2025-08-05 14:41:50 -04:00
Nick Bolton
54a7ef24d9
refactor: Remove unused includes from KeyMap.cpp and use correct <algorithm> include
2025-08-05 08:56:53 -04:00
Nick Bolton
c4ff0b1832
refactor: Remove unnecessary debug log from KeyState::fakeKeys
2025-08-05 08:56:53 -04:00
sithlord48
80408b985e
refactor: show display version for --version
2025-08-05 13:36:04 +01:00
sithlord48
ff1e7f3c9f
refactor: ClientApp / ServerApp, remove do nothing updateStatus methods and calls
2025-08-04 13:46:27 +01:00
sithlord48
b2eb3a036d
refactor: move ClientApp::handleScreenError / ServerApp::handleScreenError to base App Class
2025-08-04 13:46:27 +01:00
sithlord48
229fedf347
refactor: App::m_bye make protected
2025-08-04 13:46:27 +01:00
sithlord48
cfccee1592
refactor: TCPSocket, make m_events private access via getEvents method
2025-08-04 13:46:27 +01:00
sithlord48
0c728beb01
refactor: TCPListenSocket, replace make protected members private, use protected methods to acces them in the subclasses
2025-08-04 13:46:27 +01:00
sithlord48
4e01e3f337
refactor: make APP:m_events private access via exsisting getEvents method
2025-08-04 13:46:27 +01:00
sithlord48
92ae41852d
chore: remove Unused Stopwatch::double operator
2025-08-04 13:46:27 +01:00
sithlord48
4f9b042f5a
refactor: explicit constructor for PlatformScreen, FileTail, FunctionJob, FunctionEventJob, ServerConfig, ScreenSettingsDialog, KeySequenceWidget, NetworkAddress, AddClientDialog, ConfigReadContext, LockCursorToScreenAction, RestartServer And KeyboardBroadcastAction
2025-08-04 13:46:27 +01:00
Christian Schmidt
1236fa4cab
fix: server: initialize the m_protocol member with a default value
...
It is likely random whether the server works or not without
a manually configured protocol option, which is neither documented
nor enforced to be set.
With a random uninitialized value in m_protocol, this can happen:
[2025-08-03T12:39:57] NOTE: accepted client connection
[2025-08-03T12:39:57] FATAL: a runtime error occurred: XInvalidProtocol
Reports of "it works with debug enabled" are likely due to having
parts of the memory space the server object is allocated into being
cleared, and thus having a 0 (Synergy) startup value.
2025-08-04 12:47:13 +01:00
sithlord48
e69be64773
refactor: remove redundant != operators c++20 std will generate the !=operator as long as the class has an ==operator
2025-08-01 13:03:51 -04:00
sithlord48
c2db28a624
refactor: ServerProxy::setActiveServerLanguage take std::string_view
2025-08-01 13:03:51 -04:00
sithlord48
1f92f2a2ed
chore: XWindowsScreen declare vars on seperate lines
2025-08-01 13:03:51 -04:00
sithlord48
74bbd5af25
chore: Fingerprint, remove unneed private label in struct
2025-08-01 13:03:51 -04:00
sithlord48
023037f7ee
refactor: XWindowsClipboard, user std::format_to_n in place of snprintf
2025-08-01 13:03:51 -04:00
sithlord48
fe19f4de66
refactor: ServerProxy::setActiveServerLanguage, use std::string size method to get string in place of strlen
2025-08-01 13:03:51 -04:00
sithlord48
d120cc853d
refactor: InputFilter, user std::ranges::partial_sort in == operator
2025-08-01 13:03:51 -04:00
sithlord48
c78665dc35
refactor: XWindowsKeyState, updateKeysymMap use std::ranges::fill to fill modifier array
2025-08-01 13:03:51 -04:00
sithlord48
c4c4c09eb2
refactor: XwindowsClipboard , use std::ranges::for_each in sendReply
2025-08-01 13:03:51 -04:00
sithlord48
2cccc3d0c8
refactor: use std::ranges::find_if when possible
2025-08-01 13:03:51 -04:00
sithlord48
59c414ebad
refactor: IKeyState: use emplace in place of insert for set addition
2025-08-01 13:03:51 -04:00
sithlord48
1e7143b85e
refactor: IKeyState, remove name from unused IEventQueue in constructor
2025-08-01 13:03:51 -04:00
sithlord48
a6068ad6f6
refactor: Log use std::format in place of snprintf, when not running on macOS...
2025-08-01 13:03:51 -04:00
Corentin Rossignon
11caf55522
fix: Wrong m_buttons vector size in case of maxButton inferior to numButtons
2025-08-01 08:18:57 -04:00
sithlord48
f73d098b1f
refactor: Unify ENetworkProtocol and ServerProtocol into new enum Class NetworkProtocol in new file base/NetworkProtocol.h
2025-07-31 13:41:29 +01:00
sithlord48
9673943556
refactor: OptionTypes, Remove corner related enums and uses static items for corner masks instead
2025-07-31 13:41:29 +01:00
sithlord48
7c06ae39ef
refactor: AddResults => enum class ScreenAddResults
2025-07-31 13:41:29 +01:00
sithlord48
ffa5b88cdf
refactor: ServerApp::EServerState => Enum class ServerApp::ServerState
2025-07-31 13:41:29 +01:00
sithlord48
8977d70dd9
refactor: IClipboard::EFormat => enum class Clipboard::Format
2025-07-31 13:41:29 +01:00
sithlord48
49e36cfdc6
refactor: Event, make non default constructors explicit
2025-07-29 13:41:34 +01:00
sithlord48
283e0c6367
refactor: KeyMap EType => enum class KeyType
2025-07-29 13:41:34 +01:00
sithlord48
902f5823f2
refactor: KeyMap::keysToRestoreModifiers, use ranged for loops
2025-07-29 13:41:34 +01:00
sithlord48
7785c954d5
refactor: KeyMap::mapCommandKey to use ranged loop
2025-07-29 13:41:34 +01:00
sithlord48
db841f71bd
refactor: PriorityQueue, Use std::ranges version of heap methods
2025-07-29 13:41:34 +01:00
sithlord48
84c2234869
refactor: ActionDialog use proper ActionDialog::itemToggled in place of lambda
2025-07-29 13:41:34 +01:00
Nick Bolton
51e467d45e
feat: Enable 'MouseKeys' on screen setup and never restore old settings
...
Previously we were toggling the 'MouseKeys' Windows accessibility feature on and off, but this was causing many bugs; cursor show delay while Windows brings up the mouse stack(?) and often forever lost mouse cursor when toggling off the 'MouseKeys' feature. After a few days of hacking away at this, it seems safest to just leave it on.
2025-07-28 21:45:05 +01:00
Nick Bolton
e184475a24
feat: Add logging in MSWindowsScreen for setup and cursor centering
2025-07-28 21:45:05 +01:00
Nick Bolton
1fb2789cb1
fix: Prevent flicker on desk leave with 30ms delay
2025-07-28 21:45:05 +01:00
Nick Bolton
8979d7f94f
feat: Cursor visibility retry mechanism
...
The `ShowCursor` function does not directly show/hide the cursor; it increments or decrements the internal display counter. When that counter reaches a certain positive/negative number, then the cursor is shown or hidden at a particular threshold.
2025-07-28 21:45:05 +01:00
Nick Bolton
9033198aed
refactor: Change mouse keys functions names to expose actual behavior
2025-07-28 21:45:05 +01:00
Nick Bolton
db55c3f0e7
build: remove unused includes from MSWindowsDesks.cpp|h
2025-07-28 21:45:05 +01:00
sithlord48
2c55f4fe06
refactor: windows write daemon log in ProgramData\Deskflow
...
remove old log file on update
2025-07-21 12:41:46 +01:00
sithlord48
a4c82869a6
fix: split version info in new header
...
a new file src/lib/VersionInfo.h.in now holds our version info vars
fixes #8657
2025-07-21 12:06:01 +01:00
sithlord48
f33848f9b8
fix: setWindowIcon explicitly, fixes #8756
2025-07-21 11:10:19 +01:00
sithlord48
e828563190
chore: MainWindow, use system correct monospace font for log
2025-07-18 10:51:50 -04:00
sithlord48
c7873f2f81
refactor: DisplayInvalidExecption pass const ref to string
2025-07-17 18:47:50 +01:00
sithlord48
9f72b44d2a
refactor: ClientApp indicate msg is unused in update status
2025-07-17 18:47:50 +01:00
sithlord48
8dcd9b0c01
refactor: ArgParser::assemble command use const ref std::string_view for ingoreArg
2025-07-17 18:47:50 +01:00
sithlord48
e436b41ab0
refactor: ArgParser::parsePlatformArgs remove unused argument isServer
2025-07-17 18:47:50 +01:00
sithlord48
c2eae36650
refactor: ArgParser, simplify arg parsing by combining duplicate checks into one
2025-07-17 18:47:50 +01:00
sithlord48
1079c22736
refactor: Settings use Static methods where possible internally
2025-07-17 18:47:50 +01:00
sithlord48
d69febe2dc
refactor: Unicode, declare vars on seperate line as untions, using string_view for UCS2ToUTF8 input, remove redundant parentheses
2025-07-17 18:47:50 +01:00
sithlord48
c6a97c24a2
refactor: String, use std::ranges::lexicogriphical_compare to simplify CaselessCpm::less
2025-07-17 18:47:50 +01:00
sithlord48
d9ec93e7ee
refactor: String, pass stringToSizeType a const ref of the string we are to get the size of
2025-07-17 18:47:50 +01:00
sithlord48
9db11a90eb
refactor: TCPSocket, new protected methods to access m_readable, m_writable and m_connected, use them in place of direct access and make the variables private
...
TCPSocket, remove duplicate private and protected sections in header
2025-07-17 18:47:50 +01:00
sithlord48
c327c80d63
refector: TCPListenSocket, remove duplicate public in header, make m_mutex private
2025-07-17 18:47:50 +01:00
sithlord48
0884a267d1
refactor: App move m_suspended to the subclasses where its is used
2025-07-17 18:47:50 +01:00
sithlord48
d1b810baa5
refactor: use std::size to get size of arrays
2025-07-17 18:47:50 +01:00
sithlord48
f51abad8cc
feat: Wayland, only set a side to a border if if has a neighboring screen
...
move protocolTypes Direction enum to new base/DirectionTypes
use the direction info when calling
fixes #8572
fixes #8452
fixes #8605
fixes #8005
2025-07-14 10:31:50 +01:00
sithlord48
ae5ba4e51f
chore: remove dev method PortalInputCapture::fakeEisFd
2025-07-14 10:31:50 +01:00
sithlord48
9413393057
refactor: anonymous enum in ServerConfig => ServerConfig::AddResults enum class
2025-07-11 03:06:24 -07:00
sithlord48
79b445373b
refactor: FingerPrintDialog::FingerpringDialogMode now enum class
2025-07-11 03:06:24 -07:00
sithlord48
9beea1abfe
refactor: anon enum in AddClientDialog to AddAction enum class
2025-07-11 03:06:24 -07:00
sithlord48
a88a67d47f
refactor: ActionDialog::ActionType enum is now a struct
2025-07-11 03:06:24 -07:00
sithlord48
7fd9070a80
refactor: InputFilter::EFilterStatus => InputFilter::FilterStatus enum class
2025-07-11 03:06:24 -07:00
sithlord48
e37cea2d6b
refactor: replace anon Enum in XWindowsKeyState with static vars
2025-07-11 03:06:24 -07:00
sithlord48
181d862838
refactor EiEventQueue remove anon enum for a few static members
2025-07-11 03:06:24 -07:00
sithlord48
6ca980e3e5
refactor: XSocket::EError => XSocket::SocketError enum class
2025-07-11 03:06:24 -07:00
sithlord48
94be5f7498
refactor: TCPSocket::EJobResult => enum class TCPSocket::JobResult
2025-07-11 03:06:24 -07:00
sithlord48
32e6a84a6f
chore: remove unused anon enum in SecureSocket
2025-07-11 03:06:24 -07:00
sithlord48
b9964b5e90
refactor: remove anon enum in IKeyState and replace with static s_numButtons
2025-07-11 03:06:24 -07:00
sithlord48
422b4c3a23
refactor ClientArgs ClientScrollDirection to enum class use Members Normal and Inverted for names
2025-07-11 03:06:24 -07:00
sithlord48
05e32497d1
refactor: ArgsBase::Type => ArgsBase::ClassType class enum
2025-07-11 03:06:24 -07:00
sithlord48
9905f32738
refactor: Common.h replace anon enum with set constexpr exit codes
2025-07-11 03:06:24 -07:00
sithlord48
29e9b8ae3b
refactor: ServerProxy::EResult => ServerProxy::ConnectionResult enum class
2025-07-11 03:06:24 -07:00
sithlord48
fe3c41f857
refactor: remove Unneed enum for LogOutputters and use a constexp instead
2025-07-11 03:06:24 -07:00
sithlord48
3ececbcfd9
refactor: Event anon enum => EventFlags struct
2025-07-11 03:06:24 -07:00
sithlord48
c12aa4c6e9
refactor: Make IEventQueueBuffer Types an enum class, use proper names rename kNone => Unknown to reflect its unknowns an unknown type of event
2025-07-11 03:06:24 -07:00
sithlord48
fc58688bb0
refactor: replace throw() with noexcept in cases where execeptions are not possible
2025-07-11 03:06:24 -07:00
sithlord48
77bdde5434
refactor: Elevel => LogLevel enum class, use proper names for items in the class
2025-07-11 03:06:24 -07:00
sithlord48
3472ff6ce5
chore: ArchNetworkBSD, use std::ignore in place of unused int
2025-07-11 03:06:24 -07:00
sithlord48
2d3105206d
fix: save geometry not frameGeometry on exit
...
fixes #8741
2025-07-09 09:32:39 +01:00
sithlord48
c6778dc9be
refactor: use more if and switch init-statements
2025-07-07 17:53:56 +01:00
sithlord48
36e985d8ab
chore: add missing default for switches
2025-07-07 17:53:56 +01:00
sithlord48
865365b2fa
chore: add noreturn to more methods
2025-07-07 17:53:56 +01:00
sithlord48
8a83f68ff0
chore: remove unused < operator for Timer class
2025-07-07 17:53:56 +01:00
sithlord48
245fa815d2
refactor: Server::onMouseMousePrimary, use std array for horizontal and vertical direction array
2025-07-07 17:53:56 +01:00
sithlord48
f12f312dab
refactor: ProtocolTypes EDirection => enum class Direction
2025-07-07 17:53:56 +01:00
sithlord48
dded2e3711
refactor: ProtocolTypes EDirectionMask => enum class DirectionMask
2025-07-07 17:53:56 +01:00
sithlord48
d71d4eaf07
refactor: ProtocolTypes EDataTransfer => struct ProtocolTypes::ChunkType
2025-07-07 17:53:56 +01:00
sithlord48
bc9f47c957
refactor: ProtocolTypes EDataReceived => enum class ProtocolTypes::TransferState
2025-07-07 17:53:56 +01:00
sithlord48
0ea2576032
refactor: XWindowsEventQueueBuffer, use static const for timeoutd delay
2025-07-07 17:53:56 +01:00
sithlord48
0100cb796e
chore: SecureSocket remove unused MAX_ERROR_SIZE define , rename MAX_INPUT_BUFFER_SIZE static to confirm to naming convention
2025-07-07 17:53:56 +01:00
sithlord48
8ec40dd74b
refactor: ClipboardChunk Replace CLIPBOARD_CHUNK_META_SIZE define with constexpr
2025-07-07 17:53:56 +01:00
sithlord48
4034d15fb3
refactor: ClientApp Replace RETRY_TIME define with constexpr
2025-07-07 17:53:56 +01:00
sithlord48
1a9f8d5cdc
refactor: app Replace options defines as constexpr use more sane names
2025-07-07 17:53:56 +01:00
sithlord48
66ddaca410
refactor: PriorityQueue::Swap make noexcept
2025-07-07 17:53:56 +01:00
sithlord48
2c2a5c0269
refactor: Make KeyMake::Swap noexcept
2025-07-07 17:53:56 +01:00
sithlord48
e42d3b45b6
refactor: SocketMultiplexer, do not create nested pointer in new Thread call
2025-07-07 17:53:56 +01:00
sithlord48
5aa9b1bfd4
refactor: PortalRemoteDesktop, do not create nested pointer in new Thread call
2025-07-07 17:53:56 +01:00
sithlord48
cfbfa88cdc
refactor: PortalInputCapture: do not create nested pointer in new Thread call
2025-07-07 17:53:56 +01:00
sithlord48
4a92a3295b
refactor: ScreenSettingsDialog, do not create nested validators in the Lines setValidator method
2025-07-07 17:53:56 +01:00
sithlord48
ede27975d7
chore: clean up remaing sonar warnings to use in class intializers where possible
2025-07-07 17:53:56 +01:00
sithlord48
a175c293f6
chore: comment empty methods that do nothing
2025-07-07 17:53:56 +01:00
sithlord48
7fe50748f3
refactor: ServerApp use if in places of multi ternary ops for readablitly
2025-07-03 03:24:16 +00:00
sithlord48
0474e10b03
chore: Arch::time explictly convert to double on return
2025-07-03 03:24:16 +00:00
sithlord48
2421a8b725
refactor: Make throwError and throwNameError members of IArchNetwork
...
make throwError and throwNameError noreturn
remove unused extra private section in IArchNetwork subclasses
2025-07-03 03:24:16 +00:00
sithlord48
ab4fbd1c85
refactor: use using enum EventTypes when possible to reduce verbosity
2025-07-03 03:24:16 +00:00
sithlord48
8f6f014bcd
refactor: IArchNetwork turn anonymous enum into PollEventMask struct with set of static values
2025-07-03 03:24:16 +00:00
sithlord48
47d44db497
refactor: make EStreamType enum Class StreamType, and conform members to naming conventions
2025-07-03 03:24:16 +00:00
sithlord48
879283f46f
refactor: Make IArchNetwork::EAddressFamily enum class IArchNetwork::AddressFamily
...
confirm AddressFamily items to naming convention
2025-07-03 03:24:16 +00:00
sithlord48
cbbfd495e3
refactor: make ESignal an enum Class IArchMultiThread::ThreadSignal, conform ThreadSignal items to naming conventions
2025-07-03 03:24:16 +00:00
sithlord48
4c2b9eb9e4
chore: remove unused XScreenInputFailure
2025-06-30 20:55:06 +01:00
sithlord48
872db8910e
chore: remove unused XSubscription class
2025-06-30 20:55:06 +01:00
sithlord48
e06b6b0be4
refactor: XSocket, new XSocketWithWhat subclass used to reduce duplication in XSocket subclasses that have a common with method
2025-06-30 20:55:06 +01:00
sithlord48
a04572a8c2
docs: remove sonar warning about // in comments, within ProtocolTypes.h
2025-06-30 20:55:06 +01:00
sithlord48
958e14cb13
refactor: remove XBASE related macros, fixes #8723
2025-06-30 20:55:06 +01:00
laz-001
22b1e8e543
docs: fix broken link to 'Protocol Reference'
...
Also fixes duplicate sidenav entries for 'Contributing'
2025-06-26 11:19:41 +01:00
sithlord48
cf9e2ecf49
refactor: simplify setting the fallback theme search path, does require sub dirs but we should only need the theme root
...
refactor: set the Icon theme in deskflow-gui insetead of MainWindow
2025-06-26 09:50:53 +01:00
sithlord48
cb508f5c3a
chore: Remove DRAG_AND_DROP left over define
2025-06-25 16:16:13 +01:00
laz-001
26cc85e878
add protocol developer documentation
2025-06-25 15:42:16 +01:00
sithlord48
42cd01efd7
refactor: PortalInputCapture, fix a missed non compliant variable names
...
refactor: PortalInputCapture, more const args
2025-06-20 18:10:40 +01:00
sithlord48
a7a54ad8a7
refactor: PortalInputCapture use std::map to hold signals and enum class as the key
...
fixes: InputCapturePortal crash in debug builds
2025-06-20 18:10:40 +01:00
sithlord48
20bc88eb1f
refactor: PortalInputCapture sonar adjustments
2025-06-20 12:41:34 +01:00
sithlord48
969b642e0b
refactor: EiScreen sonar adjustments
2025-06-20 12:41:34 +01:00
sithlord48
a89f3b6892
refactor: conform EiScreen to code standards
...
fixes #8700
2025-06-20 12:41:34 +01:00
sithlord48
a973d4277c
refactor: conform PortalInputCapture to coding standards
2025-06-20 12:41:34 +01:00