smw/deskflow
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
6677 commits 2 branches 0 tags 101 MiB
Commit graph

2664 commits

Author SHA1 Message Date
sithlord48
dc0db9d192 refactor: LogWidget remove unused Q_SIGNALS delclaration 2025-09-05 11:52:17 +01:00
sithlord48
9f3e724218 refactor: ScreenSettingsDialog::removeAlias make const 2025-09-05 11:52:17 +01:00
Jonathan Wakely
f98f8b10d1 refactor: Construct std::string outside critical section 
There's no need to hold the mutex while constructing a `std::string`
from the `char` string.

Also use `inet_ntop` instead of the potentially thread-unsafe
`inet_ntoa` that might use a static buffer for the result.

This makes the `INet` case match the `INet6` case below.
 2025-09-04 16:56:46 +01:00
Jonathan Wakely
b788d63044 refactor: Give internal linkage to global mutex 
The `static` keyword was removed by #8674 but I think it should be
restored so that this global can't clash with anything else called
`::s_mutex` elsewhere in the executable.
 2025-09-04 16:56:46 +01:00
sithlord48
d5936a9e08 refactor: ScreenSettingsDialog, do not use auto connect slots 2025-09-03 10:38:59 +01:00
sithlord48
81c53d3690 refactor: ScreenSettingsDialog, conform to naming conventions 2025-09-03 10:38:59 +01:00
sithlord48
89003082d7 refactor: continue to improve the screen settings dialog ui 2025-09-03 10:38:59 +01:00
Tomaz Canabrava
fe1a48fa28 refactor: Rework Computer Settings 
Removed almost half of the lines, and still made it
more pretty.
 2025-09-03 10:38:59 +01:00
Tomaz Canabrava
c4b2f91424 refactor: Move ServerConfig to the config folder 2025-09-03 10:38:59 +01:00
Tomaz Canabrava
f16c13fa54 refactor: ScreenSettingsDialog, Constify validator variables 2025-09-03 10:38:59 +01:00
sithlord48
43ce3c50e5 refactor: move log to dockwidget simplifying resize code 2025-09-01 18:12:41 +01:00
sithlord48
204a6b5a44 refactor: New LogWidget to handle log output in the mainwindow 2025-09-01 18:12:41 +01:00
sithlord48
a6dc455477 fix: Settings reset on windows, create new profile dir when not in native mode 
fixes: #8916
 2025-09-01 17:22:15 +01:00
sithlord48
138ede0536 refactor: use If in place of switch that looks for single case 2025-09-01 16:57:39 +01:00
sithlord48
eae089d3ec chore: ServerConfigDialog, conform to naming standards for members 2025-09-01 16:57:39 +01:00
sithlord48
340df69ca2 refactor: ServerConfigDialog, set members in alphbetical order, correct initlization order 2025-09-01 16:57:39 +01:00
sithlord48
507c98adff refactor: EIKeyState::fakeKey use if in place of a switch that cares only about a single case 2025-09-01 16:57:39 +01:00
sithlord48
0501f2892d chore: Messages::showClientError remove unneeded capture from lambda 2025-09-01 16:57:39 +01:00
Kris
104d2facdb feat: add switchToNextScreen hotkey to cycle through computers 2025-09-01 11:39:52 -04:00
Kris
398c9726f3 fix: fixes the mouse label issue 2025-09-01 11:39:52 -04:00
sithlord48
eb2f885983 chore: conform CoreProcess to naming standards 2025-09-01 16:18:02 +01:00
Nick Bolton
4a16931c5d refactor: Remove QProcessProxy and simplify CoreProcess 
Making a proxy class for QProcess to make GTest work is an excellent example of over-abstraction making simple things hard to do. I just wanted to call a function on QProcess and had to jump through hoops to do it.

Bye bye QProcessProxy! We can do much better with QTest.
 2025-09-01 16:18:02 +01:00
Nick Bolton
78b83c5639 fix: Use correct log function for process exit status in onProcessFinished 2025-09-01 08:05:07 -04:00
sithlord48
9cf25c4caf feat: Allow suppression of generic client connection dialog 
fixes 8907
 2025-09-01 10:57:59 +01:00
sithlord48
f0e02724ee refactor: CoreProcess::onProcessFinished add using for ProcessState enum 2025-09-01 10:04:52 +01:00
sithlord48
60e71aad38 fix: missing IPC messages 
fixes #8905
 2025-09-01 10:04:52 +01:00
sithlord48
4e8a67925f refactor: Add Tooltip to log levels and show a label with info about debug level affecting performance 
fixes: #8889
 2025-08-28 00:45:40 +01:00
sithlord48
cba3881f41 refactor: Move all messages that are checked for by GUI in the log to new IPC Level so the gui can work with any filter level 2025-08-28 00:45:40 +01:00
sithlord48
78eb353985 refactor: Settings Allow all log levels to be shown in the Gui 2025-08-28 00:45:40 +01:00
sithlord48
e7880b72f1 chore: Mainwindow convert comments for regenerateLocalFingerprint to doxygen comments 2025-08-27 19:18:59 -04:00
sithlord48
d864361085 feat: Improve fingerprint comparison dialog, to show both remote and local prints (server is always on left of dialog) 
fixes: #8866
 2025-08-27 19:18:59 -04:00
sithlord48
66366dd95b refactor: Fingerprintprevew, Add optional title text, remove label for cypher type and add option to toggle the sha mode so art or hash is visible 2025-08-27 19:18:59 -04:00
sithlord48
2c6c65f71e refactor: MainWindow new localFingerprint method to read the local fingerprint from the db, this is split from showMyFingerprint 2025-08-27 19:18:59 -04:00
sithlord48
9eede5470c refactor: TLSUtil do not check it tls is enabled before regenerating the certificate 
fixes #8890
 2025-08-27 05:51:15 -04:00
Nick Bolton
07edccb469 fix: Add 'Hyper' key handling 
In the X11 code, we mapped hyper to super, so perhaps it makes sense to do that here too:

`src/lib/platform/XWindowsUtil.cpp`
```
  case XK_Super_L:
  case XK_Super_R:
  case XK_Hyper_L:
  case XK_Hyper_R:
    return kKeyModifierBitSuper;
```
 2025-08-26 09:52:43 -04:00
Zhuofeng Wang
927075688c fix: Pass ClientScrollDirection to EiScreen 2025-08-26 09:08:45 -04:00
sithlord48
b18c3b588f refactor: EIKeyState, compare to the current state when seeing if modifiers are inactive, suggested by wismill 2025-08-26 11:23:29 +01:00
Nick Bolton
34c439b3de refactor: Use single case to ignore mods in EI mod mask 2025-08-22 17:04:16 +01:00
Nick Bolton
934ddf1499 fix: Disable meta mod (fixes alt key bug) 2025-08-22 17:04:16 +01:00
Nick Bolton
4302d50a42 feat: Use xkb_keymap_mod_get_mask in EiKeyState if available 
Introduced in xkbcommon v1.10.0
 2025-08-22 16:06:03 +01:00
sithlord48
3e96c4d0aa refactor: Include breeze fallback icons for connect and disconnect 2025-08-22 09:54:20 +01:00
sithlord48
d368b92165 refactor: CoreProcess::onProcessFinished Stop trying to restart the core process if its already running 2025-08-22 09:54:20 +01:00
sithlord48
97e3524a24 build: SecureSocket, include io/FileSystem in SecureSocket.cpp 2025-08-22 09:54:20 +01:00
sithlord48
299ebea0e2 refactor: replace QString::toStdString().c_str with qPrintable(...) 2025-08-22 09:54:20 +01:00
sithlord48
3a66969dec refactor: add XdpRestoreToken to list of valid keys so its not removed if cleansettings is run 2025-08-21 07:54:21 -04:00
sithlord48
d3c0ce8895 refactor: move all exit codes to new ExitCodes 
add new exitcode s_exitDuplicate for when exiting because of already running instance
 2025-08-21 12:34:50 +01:00
sithlord48
26983dc0e4 refactor MainWindow, move start and restart inline with mode options 
update labels for the mode buttons actions and menu actions
                     use callstart / callstop for connect and disconect icons
 2025-08-20 16:09:08 -04:00
sithlord48
a0d75b28ba refactor: SettingsDialog, group client options together into a groupClientOptions 2025-08-20 15:50:26 -04:00
sithlord48
e9cec877f2 fix: SettingDialog, only lock the check peers checkbox in updateTlsControls when in client mode 
fixes #8870
 2025-08-20 15:50:26 -04:00
sithlord48
0bb8ff646a refactor: SettingsDialog, prevent updateControls from being called twice at startup 2025-08-20 15:50:26 -04:00
sithlord48
9268fef89d refactor: SettingsDialog remove duplicate code by calling updateTlsControlsEnabled inside updateTlsControls 2025-08-20 15:50:26 -04:00
sithlord48
6f8b3f481d refactor: adjust the help message for core to combine server and client message fixing man page deployment 2025-08-20 20:33:20 +01:00
sithlord48
3b2d7fc0b3 feat: Switch to deskflow-core instead of split binaries 2025-08-20 20:33:20 +01:00
sithlord48
7cac145500 fix: Allow Gui to work with core ,server or client binaries 
fixes: #7951
 2025-08-20 20:33:20 +01:00
sithlord48
b2aa638b1f feat: Support Remote Desktop token persistance 2025-08-19 15:46:14 +01:00
sithlord48
2990a1f686 refactor: Server, reorder private member vars to avoid un unessary padding 2025-08-18 11:45:21 +01:00
sithlord48
c3f2c04a28 refactor: remove IAppUtil. AppUtil is the base class now 2025-08-18 11:45:21 +01:00
sithlord48
347cb46f15 refactor: remove IEventJob 2025-08-18 11:45:21 +01:00
sithlord48
bcb6c368b1 refactor: remove unneeded common/Common includes 2025-08-18 11:45:21 +01:00
sithlord48
a9e87d5ef5 refactor: remove INode class as base for Server and Client objects 2025-08-18 11:45:21 +01:00
sithlord48
4eec183598 refactor: remove IInterface class, that only adds a virtual construcor 2025-08-18 11:45:21 +01:00
sithlord48
6c6e5fc4d2 refactor: MainWindow use static for cleanup of QLocalServer 2025-08-15 12:15:40 +01:00
sithlord48
0d7d21aeb2 refactor: Action LockCursorMode => Action::LockCursorMode enum class 2025-08-15 12:15:40 +01:00
sithlord48
ea6f4ce221 refactor: Action SwitchDirection => Action::SwitchDirection enum class 2025-08-15 12:15:40 +01:00
sithlord48
1c7d5de01b refactor Action::ActionType => Action::Type enum class 2025-08-15 12:15:40 +01:00
sithlord48
d2d28f5ad6 refactor: XWinowsUtil make s_keymap a std::array 2025-08-15 12:15:40 +01:00
sithlord48
04ca52b94e fix: resolve issues with some swedish characters 
fixes: #8839
 2025-08-14 17:57:26 -04:00
sithlord48
0dfd4ebc4a refactor: Mainwindow, adjust how and where the ip address is shown. 
- Add a new method updateNetworkInfo to update lblIpAddresses
   This method can be hooked to the system network info in the future
   when we want to have this be more dynamic.
 - Only show the IP address when in server mode.
 - When showing the IP address show either the suggested IP or a message the user maybe offline
 - Use the linkVisited color to for our error message
 2025-08-12 13:04:09 -04:00
sithlord48
a7048f76f9 refactor: GUI, Mainwindow use the system hyperlink color to color the text of the 'primary' Ip address 2025-08-12 13:04:09 -04:00
sithlord48
8d92a8df68 refactor: On windows use the old malloc method to prevent random test failure in IKeyState 2025-08-12 12:14:21 -04:00
Pranav P
d6b53ea718 fix: failures in big endian machines tests 2025-08-12 16:56:17 +01:00
sithlord48
2e193c6a78 chore: PortalInputCapture, conform to naming conventions 2025-08-11 12:58:52 -04:00
sithlord48
f95230549a chore: EiScreen: conform to nameing conventions 2025-08-11 12:58:52 -04:00
sithlord48
a13803df94 chore: EiKeyState, conform to naming conventions 2025-08-11 12:58:52 -04:00
sithlord48
2ba7fb2f05 chore: EiEventQueueBuffer, conform to naming conventions 2025-08-11 12:58:52 -04:00
sithlord48
9442295227 chore: remove unused HYPER key 2025-08-11 12:32:50 -04:00
sithlord48
8d87f3250d refactor: ScreenSettingsDialog use qDeleteAll to clear list of items on alias remove 2025-08-11 12:32:50 -04:00
sithlord48
e700867a32 refactor: remove ServerConfig remove const qualifer from QString return 2025-08-11 12:32:50 -04:00
sithlord48
a21d48defb refactor: reorder initilization order in XWindowEventQueueBuffer constructor 2025-08-11 12:32:50 -04:00
sithlord48
3770e2c39e chore: XWindowsScreen::handleSystemEvent, remove unused Window variables 2025-08-11 12:32:50 -04:00
sithlord48
8d90515446 chore: define var on seperate line from type 2025-08-11 12:32:50 -04:00
sithlord48
db67550db3 refactor: server: use contains when possible 2025-08-11 12:32:50 -04:00
sithlord48
85e7d95188 refactor: server/Config use contains 2025-08-11 12:32:50 -04:00
sithlord48
651e093e04 refactor: clientProxy1_4 do not create pointless override that just call the baseclass 2025-08-11 12:32:50 -04:00
sithlord48
02fb9915bf refactor: Arch, only define init override on windows, where its ambiguious 2025-08-11 12:32:50 -04:00
sithlord48
6153f64fb7 chore: remove uneeded casts 2025-08-11 12:32:50 -04:00
sithlord48
f91df1639b refactor: make sure to state type of access to base class 2025-08-11 12:32:50 -04:00
sithlord48
63bd2e71b0 refactor: CoreProcess fully qualify enums used in signals 2025-08-11 12:32:50 -04:00
sithlord48
e1d00d59a4 refactor: ScreenSetupModel::isFull compaire same type of iterator 2025-08-11 12:32:50 -04:00
sithlord48
5def3f1f6a refactor: DaemonApp add context object for lambda starting the thread 
chore: DaemonApp, remove unnessary QObject:: for connect calls
 2025-08-11 12:32:50 -04:00
sithlord48
6840e1e7eb fix: Better description for InvalidProtocolException 
fixes: #8830
 2025-08-11 17:14:45 +01:00
sithlord48
85d89f9846 refactor: XArch Classes => Arch Exception Classes 2025-08-11 17:14:45 +01:00
sithlord48
8929f85bf7 refactor: XConfigRead => ServerConfigReadException 2025-08-11 17:14:45 +01:00
sithlord48
9601180e1b refactor: XBase Classes => BaseException 2025-08-11 17:14:45 +01:00
sithlord48
64786ddcb7 refactor: XDeskflow Classes => DeskflowException Classes 2025-08-11 17:14:45 +01:00
sithlord48
e4a9d1eb78 refactor: XScreen Classes => ScreenException Classes 2025-08-11 17:14:45 +01:00
sithlord48
1b04b1137c refactor: XIO Classes => IOException Classes 2025-08-11 17:14:45 +01:00
sithlord48
813b0c3828 refactor: mt/XThread Classes => mt/ThreadException Classes 2025-08-11 17:14:45 +01:00
sithlord48
22a358fb49 refactor: XMT Classes => MTException Classes 2025-08-11 17:14:45 +01:00
sithlord48
ada2813f9f refactor: XSocket Classes => XSocketException Classes 2025-08-11 17:14:45 +01:00
sithlord48
906c07e4fd fix: MainWindow::setHostName only check if the screen is existing when in server mode, In severmode update the serverConfig serverName to prevent a case where the server screen is on the grid with the old name breaking the layout 2025-08-11 16:49:25 +01:00
Nick Bolton
a4c0e30bb8 fix: Ignore Mod2 and Mod3 to make log quieter 2025-08-07 15:31:52 -04:00
Peter Hutterer
a5c9744258 fix: Account for more modifiers in the EI keymap calculation 
Some modifiers, notably LevelThree, were not accounted for in the
modifier mask calculation. This leads to an incorrect keymap where some
key symbols were listed for keys without (or insufficient) modifiers.
Emulating those keys can then produce the wrong keysyms.

Reproducible with server and client on English(UK) layout and typing
e.g. [. That key has its own key AD11 (right of P) but is also on
the third level of AE08 (the 8 key). When the server sends the keyid 91
(for [) the client looks it up in the pre-generated keymap. It is found
first on the 8 key with no modifiers (because LevelThree was previously
ignored), hence the client simulates a key 8 press without modifiers.
This erroneously produced an 8 instead of the wanted [.

Fix this by ensuring that all modifiers are accounted for in the key
map. This fix is likely incomplete as it does not account for the full
virtual modifier to real modifier mappings possible (e.g. Mod5 *may* be
something other than AltGr) but it does push the can a bit further down
the road, for someone else to release the worms.

Closes: #8168
 2025-08-07 15:31:52 -04:00
sithlord48
2a84ef0ebf refactor: update log calls to LOG_... fixes #8819 2025-08-06 16:18:38 +01:00
Nick Bolton
9a9bd7e262 chore: Improve logging for active sides 
For the longest time, this log line has bugged me:
```
active sides: e
```

It's hex, but it looks like a bug, since there's no `0x` prefix. Also, most humans can't read hex, so I added a string representation.

New version:
```
[2025-08-06T11:56:00] DEBUG: active sides: LRT (0x0e)
```
 2025-08-06 08:38:00 -04:00
James Le Cuirot
47bb33e065 fix: update inclusion of climits and cstdint headers 
For INT_MAX and SIZE_MAX.
 2025-08-06 13:03:52 +01:00
sithlord48
40423397e3 refactor: Config remove redundant != Operator in server/Config 2025-08-06 11:44:38 +01:00
sithlord48
4955e8c2ba refactor: Fingerprint, KeyMap, KeySequence and Action use default == operator 2025-08-06 11:44:38 +01:00
sithlord48
24480ce946 refactor: AppUtilUnix remove name from unused IEventQueue pointer 2025-08-06 11:44:38 +01:00
sithlord48
76d5ac0a34 refactor: KeyTypes::KeyModifierNameMapEntry, remove commented code 2025-08-06 11:44:38 +01:00
sithlord48
d20887f34a refactor: KeyState::updateModifierState, use std::ranges::set_difference in place of std::set_difference 2025-08-06 11:44:38 +01:00
sithlord48
0cbc922478 refactor: MSWindowsDesks::getCursorPos initialize pos to 0,0 2025-08-06 11:44:38 +01:00
sithlord48
38866cf2c1 refactor: remove unneeed constructors from DisplayInvalidExecption 2025-08-06 11:44:38 +01:00
sithlord48
32165f5b58 refactor: IKeyState remove need for malloc in alloc methods 2025-08-06 11:44:38 +01:00
sithlord48
1968669a39 refactor: App make m_bye private access it from the method bye 2025-08-06 11:44:38 +01:00
sithlord48
3b2b8a9ebe refactor: IKeyState: directly make string when spilting as arg to emplace 2025-08-06 11:44:38 +01:00
sithlord48
048ce47008 refactor: ServerConfig: used ranged loop to process neighbours 2025-08-06 11:44:38 +01:00
sithlord48
d321e2a874 refactor: TCPSocket Init m_socket before m_events 2025-08-06 11:44:38 +01:00
Nick Bolton
0352e1c6d6 chore: Improve logging in Server::onClipboardChanged 2025-08-05 14:41:50 -04:00
Nick Bolton
98d03fb098 chore: Improve logging in Server::handleClipboardGrabbed 2025-08-05 14:41:50 -04:00
Nick Bolton
739cdc1752 chore: Improve logging for DESKFLOW_MOUSE_ADJUSTMENT env var 
We plan to move this elsewhere, but in the meantime, the DEBUG1 logging was too noisy. Also fixed some code style that was bugging me.
 2025-08-05 14:41:50 -04:00
Nick Bolton
54a7ef24d9 refactor: Remove unused includes from KeyMap.cpp and use correct <algorithm> include 2025-08-05 08:56:53 -04:00
Nick Bolton
c4ff0b1832 refactor: Remove unnecessary debug log from KeyState::fakeKeys 2025-08-05 08:56:53 -04:00
sithlord48
80408b985e refactor: show display version for --version 2025-08-05 13:36:04 +01:00
sithlord48
ff1e7f3c9f refactor: ClientApp / ServerApp, remove do nothing updateStatus methods and calls 2025-08-04 13:46:27 +01:00
sithlord48
b2eb3a036d refactor: move ClientApp::handleScreenError / ServerApp::handleScreenError to base App Class 2025-08-04 13:46:27 +01:00
sithlord48
229fedf347 refactor: App::m_bye make protected 2025-08-04 13:46:27 +01:00
sithlord48
cfccee1592 refactor: TCPSocket, make m_events private access via getEvents method 2025-08-04 13:46:27 +01:00
sithlord48
0c728beb01 refactor: TCPListenSocket, replace make protected members private, use protected methods to acces them in the subclasses 2025-08-04 13:46:27 +01:00
sithlord48
4e01e3f337 refactor: make APP:m_events private access via exsisting getEvents method 2025-08-04 13:46:27 +01:00
sithlord48
92ae41852d chore: remove Unused Stopwatch::double operator 2025-08-04 13:46:27 +01:00
sithlord48
4f9b042f5a refactor: explicit constructor for PlatformScreen, FileTail, FunctionJob, FunctionEventJob, ServerConfig, ScreenSettingsDialog, KeySequenceWidget, NetworkAddress, AddClientDialog, ConfigReadContext, LockCursorToScreenAction, RestartServer And KeyboardBroadcastAction 2025-08-04 13:46:27 +01:00
Christian Schmidt
1236fa4cab fix: server: initialize the m_protocol member with a default value 
It is likely random whether the server works or not without
a manually configured protocol option, which is neither documented
nor enforced to be set.
With a random uninitialized value in m_protocol, this can happen:
[2025-08-03T12:39:57] NOTE: accepted client connection
[2025-08-03T12:39:57] FATAL: a runtime error occurred: XInvalidProtocol

Reports of "it works with debug enabled" are likely due to having
parts of the memory space the server object is allocated into being
cleared, and thus having a 0 (Synergy) startup value.
 2025-08-04 12:47:13 +01:00
sithlord48
e69be64773 refactor: remove redundant != operators c++20 std will generate the !=operator as long as the class has an ==operator 2025-08-01 13:03:51 -04:00
sithlord48
c2db28a624 refactor: ServerProxy::setActiveServerLanguage take std::string_view 2025-08-01 13:03:51 -04:00
sithlord48
1f92f2a2ed chore: XWindowsScreen declare vars on seperate lines 2025-08-01 13:03:51 -04:00
sithlord48
74bbd5af25 chore: Fingerprint, remove unneed private label in struct 2025-08-01 13:03:51 -04:00
sithlord48
023037f7ee refactor: XWindowsClipboard, user std::format_to_n in place of snprintf 2025-08-01 13:03:51 -04:00
sithlord48
fe19f4de66 refactor: ServerProxy::setActiveServerLanguage, use std::string size method to get string in place of strlen 2025-08-01 13:03:51 -04:00
sithlord48
d120cc853d refactor: InputFilter, user std::ranges::partial_sort in == operator 2025-08-01 13:03:51 -04:00
sithlord48
c78665dc35 refactor: XWindowsKeyState, updateKeysymMap use std::ranges::fill to fill modifier array 2025-08-01 13:03:51 -04:00
sithlord48
c4c4c09eb2 refactor: XwindowsClipboard , use std::ranges::for_each in sendReply 2025-08-01 13:03:51 -04:00
sithlord48
2cccc3d0c8 refactor: use std::ranges::find_if when possible 2025-08-01 13:03:51 -04:00
sithlord48
59c414ebad refactor: IKeyState: use emplace in place of insert for set addition 2025-08-01 13:03:51 -04:00
sithlord48
1e7143b85e refactor: IKeyState, remove name from unused IEventQueue in constructor 2025-08-01 13:03:51 -04:00
sithlord48
a6068ad6f6 refactor: Log use std::format in place of snprintf, when not running on macOS... 2025-08-01 13:03:51 -04:00
Corentin Rossignon
11caf55522 fix: Wrong m_buttons vector size in case of maxButton inferior to numButtons 2025-08-01 08:18:57 -04:00
sithlord48
f73d098b1f refactor: Unify ENetworkProtocol and ServerProtocol into new enum Class NetworkProtocol in new file base/NetworkProtocol.h 2025-07-31 13:41:29 +01:00
sithlord48
9673943556 refactor: OptionTypes, Remove corner related enums and uses static items for corner masks instead 2025-07-31 13:41:29 +01:00
sithlord48
7c06ae39ef refactor: AddResults => enum class ScreenAddResults 2025-07-31 13:41:29 +01:00
sithlord48
ffa5b88cdf refactor: ServerApp::EServerState => Enum class ServerApp::ServerState 2025-07-31 13:41:29 +01:00
sithlord48
8977d70dd9 refactor: IClipboard::EFormat => enum class Clipboard::Format 2025-07-31 13:41:29 +01:00
sithlord48
49e36cfdc6 refactor: Event, make non default constructors explicit 2025-07-29 13:41:34 +01:00
sithlord48
283e0c6367 refactor: KeyMap EType => enum class KeyType 2025-07-29 13:41:34 +01:00
sithlord48
902f5823f2 refactor: KeyMap::keysToRestoreModifiers, use ranged for loops 2025-07-29 13:41:34 +01:00
sithlord48
7785c954d5 refactor: KeyMap::mapCommandKey to use ranged loop 2025-07-29 13:41:34 +01:00
sithlord48
db841f71bd refactor: PriorityQueue, Use std::ranges version of heap methods 2025-07-29 13:41:34 +01:00
sithlord48
84c2234869 refactor: ActionDialog use proper ActionDialog::itemToggled in place of lambda 2025-07-29 13:41:34 +01:00
Nick Bolton
51e467d45e feat: Enable 'MouseKeys' on screen setup and never restore old settings 
Previously we were toggling the 'MouseKeys' Windows accessibility feature on and off, but this was causing many bugs; cursor show delay while Windows brings up the mouse stack(?) and often forever lost mouse cursor when toggling off the 'MouseKeys' feature. After a few days of hacking away at this, it seems safest to just leave it on.
 2025-07-28 21:45:05 +01:00
Nick Bolton
e184475a24 feat: Add logging in MSWindowsScreen for setup and cursor centering 2025-07-28 21:45:05 +01:00
Nick Bolton
1fb2789cb1 fix: Prevent flicker on desk leave with 30ms delay 2025-07-28 21:45:05 +01:00
Nick Bolton
8979d7f94f feat: Cursor visibility retry mechanism 
The `ShowCursor` function does not directly show/hide the cursor; it increments or decrements the internal display counter. When that counter reaches a certain positive/negative number, then the cursor is shown or hidden at a particular threshold.
 2025-07-28 21:45:05 +01:00
Nick Bolton
9033198aed refactor: Change mouse keys functions names to expose actual behavior 2025-07-28 21:45:05 +01:00
Nick Bolton
db55c3f0e7 build: remove unused includes from MSWindowsDesks.cpp|h 2025-07-28 21:45:05 +01:00
sithlord48
2c55f4fe06 refactor: windows write daemon log in ProgramData\Deskflow 
remove old log file on update
 2025-07-21 12:41:46 +01:00
sithlord48
a4c82869a6 fix: split version info in new header 
a new file src/lib/VersionInfo.h.in now holds our version info vars
fixes #8657
 2025-07-21 12:06:01 +01:00
sithlord48
f33848f9b8 fix: setWindowIcon explicitly, fixes #8756 2025-07-21 11:10:19 +01:00
sithlord48
e828563190 chore: MainWindow, use system correct monospace font for log 2025-07-18 10:51:50 -04:00
sithlord48
c7873f2f81 refactor: DisplayInvalidExecption pass const ref to string 2025-07-17 18:47:50 +01:00
sithlord48
9f72b44d2a refactor: ClientApp indicate msg is unused in update status 2025-07-17 18:47:50 +01:00
sithlord48
8dcd9b0c01 refactor: ArgParser::assemble command use const ref std::string_view for ingoreArg 2025-07-17 18:47:50 +01:00
sithlord48
e436b41ab0 refactor: ArgParser::parsePlatformArgs remove unused argument isServer 2025-07-17 18:47:50 +01:00
sithlord48
c2eae36650 refactor: ArgParser, simplify arg parsing by combining duplicate checks into one 2025-07-17 18:47:50 +01:00
sithlord48
1079c22736 refactor: Settings use Static methods where possible internally 2025-07-17 18:47:50 +01:00
sithlord48
d69febe2dc refactor: Unicode, declare vars on seperate line as untions, using string_view for UCS2ToUTF8 input, remove redundant parentheses 2025-07-17 18:47:50 +01:00
sithlord48
c6a97c24a2 refactor: String, use std::ranges::lexicogriphical_compare to simplify CaselessCpm::less 2025-07-17 18:47:50 +01:00
sithlord48
d9ec93e7ee refactor: String, pass stringToSizeType a const ref of the string we are to get the size of 2025-07-17 18:47:50 +01:00
sithlord48
9db11a90eb refactor: TCPSocket, new protected methods to access m_readable, m_writable and m_connected, use them in place of direct access and make the variables private 
TCPSocket, remove duplicate private and protected sections in header
 2025-07-17 18:47:50 +01:00
sithlord48
c327c80d63 refector: TCPListenSocket, remove duplicate public in header, make m_mutex private 2025-07-17 18:47:50 +01:00
sithlord48
0884a267d1 refactor: App move m_suspended to the subclasses where its is used 2025-07-17 18:47:50 +01:00
sithlord48
d1b810baa5 refactor: use std::size to get size of arrays 2025-07-17 18:47:50 +01:00
sithlord48
f51abad8cc feat: Wayland, only set a side to a border if if has a neighboring screen 
move protocolTypes Direction enum to new base/DirectionTypes
use the direction info when calling
fixes #8572
fixes #8452
fixes #8605
fixes #8005
 2025-07-14 10:31:50 +01:00
sithlord48
ae5ba4e51f chore: remove dev method PortalInputCapture::fakeEisFd 2025-07-14 10:31:50 +01:00
sithlord48
9413393057 refactor: anonymous enum in ServerConfig => ServerConfig::AddResults enum class 2025-07-11 03:06:24 -07:00
sithlord48
79b445373b refactor: FingerPrintDialog::FingerpringDialogMode now enum class 2025-07-11 03:06:24 -07:00
sithlord48
9beea1abfe refactor: anon enum in AddClientDialog to AddAction enum class 2025-07-11 03:06:24 -07:00
sithlord48
a88a67d47f refactor: ActionDialog::ActionType enum is now a struct 2025-07-11 03:06:24 -07:00
sithlord48
7fd9070a80 refactor: InputFilter::EFilterStatus => InputFilter::FilterStatus enum class 2025-07-11 03:06:24 -07:00
sithlord48
e37cea2d6b refactor: replace anon Enum in XWindowsKeyState with static vars 2025-07-11 03:06:24 -07:00
sithlord48
181d862838 refactor EiEventQueue remove anon enum for a few static members 2025-07-11 03:06:24 -07:00
sithlord48
6ca980e3e5 refactor: XSocket::EError => XSocket::SocketError enum class 2025-07-11 03:06:24 -07:00
sithlord48
94be5f7498 refactor: TCPSocket::EJobResult => enum class TCPSocket::JobResult 2025-07-11 03:06:24 -07:00
sithlord48
32e6a84a6f chore: remove unused anon enum in SecureSocket 2025-07-11 03:06:24 -07:00
sithlord48
b9964b5e90 refactor: remove anon enum in IKeyState and replace with static s_numButtons 2025-07-11 03:06:24 -07:00
sithlord48
422b4c3a23 refactor ClientArgs ClientScrollDirection to enum class use Members Normal and Inverted for names 2025-07-11 03:06:24 -07:00
sithlord48
05e32497d1 refactor: ArgsBase::Type => ArgsBase::ClassType class enum 2025-07-11 03:06:24 -07:00
sithlord48
9905f32738 refactor: Common.h replace anon enum with set constexpr exit codes 2025-07-11 03:06:24 -07:00
sithlord48
29e9b8ae3b refactor: ServerProxy::EResult => ServerProxy::ConnectionResult enum class 2025-07-11 03:06:24 -07:00
sithlord48
fe3c41f857 refactor: remove Unneed enum for LogOutputters and use a constexp instead 2025-07-11 03:06:24 -07:00
sithlord48
3ececbcfd9 refactor: Event anon enum => EventFlags struct 2025-07-11 03:06:24 -07:00
sithlord48
c12aa4c6e9 refactor: Make IEventQueueBuffer Types an enum class, use proper names rename kNone => Unknown to reflect its unknowns an unknown type of event 2025-07-11 03:06:24 -07:00
sithlord48
fc58688bb0 refactor: replace throw() with noexcept in cases where execeptions are not possible 2025-07-11 03:06:24 -07:00
sithlord48
77bdde5434 refactor: Elevel => LogLevel enum class, use proper names for items in the class 2025-07-11 03:06:24 -07:00
sithlord48
3472ff6ce5 chore: ArchNetworkBSD, use std::ignore in place of unused int 2025-07-11 03:06:24 -07:00
sithlord48
2d3105206d fix: save geometry not frameGeometry on exit 
fixes #8741
 2025-07-09 09:32:39 +01:00
sithlord48
c6778dc9be refactor: use more if and switch init-statements 2025-07-07 17:53:56 +01:00
sithlord48
36e985d8ab chore: add missing default for switches 2025-07-07 17:53:56 +01:00
sithlord48
865365b2fa chore: add noreturn to more methods 2025-07-07 17:53:56 +01:00
sithlord48
8a83f68ff0 chore: remove unused < operator for Timer class 2025-07-07 17:53:56 +01:00
sithlord48
245fa815d2 refactor: Server::onMouseMousePrimary, use std array for horizontal and vertical direction array 2025-07-07 17:53:56 +01:00
sithlord48
f12f312dab refactor: ProtocolTypes EDirection => enum class Direction 2025-07-07 17:53:56 +01:00
sithlord48
dded2e3711 refactor: ProtocolTypes EDirectionMask => enum class DirectionMask 2025-07-07 17:53:56 +01:00
sithlord48
d71d4eaf07 refactor: ProtocolTypes EDataTransfer => struct ProtocolTypes::ChunkType 2025-07-07 17:53:56 +01:00
sithlord48
bc9f47c957 refactor: ProtocolTypes EDataReceived => enum class ProtocolTypes::TransferState 2025-07-07 17:53:56 +01:00
sithlord48
0ea2576032 refactor: XWindowsEventQueueBuffer, use static const for timeoutd delay 2025-07-07 17:53:56 +01:00
sithlord48
0100cb796e chore: SecureSocket remove unused MAX_ERROR_SIZE define , rename MAX_INPUT_BUFFER_SIZE static to confirm to naming convention 2025-07-07 17:53:56 +01:00
sithlord48
8ec40dd74b refactor: ClipboardChunk Replace CLIPBOARD_CHUNK_META_SIZE define with constexpr 2025-07-07 17:53:56 +01:00
sithlord48
4034d15fb3 refactor: ClientApp Replace RETRY_TIME define with constexpr 2025-07-07 17:53:56 +01:00
sithlord48
1a9f8d5cdc refactor: app Replace options defines as constexpr use more sane names 2025-07-07 17:53:56 +01:00
sithlord48
66ddaca410 refactor: PriorityQueue::Swap make noexcept 2025-07-07 17:53:56 +01:00
sithlord48
2c2a5c0269 refactor: Make KeyMake::Swap noexcept 2025-07-07 17:53:56 +01:00
sithlord48
e42d3b45b6 refactor: SocketMultiplexer, do not create nested pointer in new Thread call 2025-07-07 17:53:56 +01:00
sithlord48
5aa9b1bfd4 refactor: PortalRemoteDesktop, do not create nested pointer in new Thread call 2025-07-07 17:53:56 +01:00
sithlord48
cfbfa88cdc refactor: PortalInputCapture: do not create nested pointer in new Thread call 2025-07-07 17:53:56 +01:00
sithlord48
4a92a3295b refactor: ScreenSettingsDialog, do not create nested validators in the Lines setValidator method 2025-07-07 17:53:56 +01:00
sithlord48
ede27975d7 chore: clean up remaing sonar warnings to use in class intializers where possible 2025-07-07 17:53:56 +01:00
sithlord48
a175c293f6 chore: comment empty methods that do nothing 2025-07-07 17:53:56 +01:00
sithlord48
7fe50748f3 refactor: ServerApp use if in places of multi ternary ops for readablitly 2025-07-03 03:24:16 +00:00
sithlord48
0474e10b03 chore: Arch::time explictly convert to double on return 2025-07-03 03:24:16 +00:00
sithlord48
2421a8b725 refactor: Make throwError and throwNameError members of IArchNetwork 
make throwError and throwNameError noreturn
          remove unused extra private section in IArchNetwork subclasses
 2025-07-03 03:24:16 +00:00
sithlord48
ab4fbd1c85 refactor: use using enum EventTypes when possible to reduce verbosity 2025-07-03 03:24:16 +00:00
sithlord48
8f6f014bcd refactor: IArchNetwork turn anonymous enum into PollEventMask struct with set of static values 2025-07-03 03:24:16 +00:00
sithlord48
47d44db497 refactor: make EStreamType enum Class StreamType, and conform members to naming conventions 2025-07-03 03:24:16 +00:00
sithlord48
879283f46f refactor: Make IArchNetwork::EAddressFamily enum class IArchNetwork::AddressFamily 
confirm AddressFamily items to naming convention
 2025-07-03 03:24:16 +00:00
sithlord48
cbbfd495e3 refactor: make ESignal an enum Class IArchMultiThread::ThreadSignal, conform ThreadSignal items to naming conventions 2025-07-03 03:24:16 +00:00
sithlord48
4c2b9eb9e4 chore: remove unused XScreenInputFailure 2025-06-30 20:55:06 +01:00
sithlord48
872db8910e chore: remove unused XSubscription class 2025-06-30 20:55:06 +01:00
sithlord48
e06b6b0be4 refactor: XSocket, new XSocketWithWhat subclass used to reduce duplication in XSocket subclasses that have a common with method 2025-06-30 20:55:06 +01:00
sithlord48
a04572a8c2 docs: remove sonar warning about // in comments, within ProtocolTypes.h 2025-06-30 20:55:06 +01:00
sithlord48
958e14cb13 refactor: remove XBASE related macros, fixes #8723 2025-06-30 20:55:06 +01:00
laz-001
22b1e8e543 docs: fix broken link to 'Protocol Reference' 
Also fixes duplicate sidenav entries for 'Contributing'
 2025-06-26 11:19:41 +01:00
sithlord48
cf9e2ecf49 refactor: simplify setting the fallback theme search path, does require sub dirs but we should only need the theme root 
refactor: set the Icon theme in deskflow-gui insetead of MainWindow
 2025-06-26 09:50:53 +01:00
sithlord48
cb508f5c3a chore: Remove DRAG_AND_DROP left over define 2025-06-25 16:16:13 +01:00
laz-001
26cc85e878 add protocol developer documentation 2025-06-25 15:42:16 +01:00
sithlord48
42cd01efd7 refactor: PortalInputCapture, fix a missed non compliant variable names 
refactor: PortalInputCapture, more const args
 2025-06-20 18:10:40 +01:00
sithlord48
a7a54ad8a7 refactor: PortalInputCapture use std::map to hold signals and enum class as the key 
fixes: InputCapturePortal crash in debug builds
 2025-06-20 18:10:40 +01:00
sithlord48
20bc88eb1f refactor: PortalInputCapture sonar adjustments 2025-06-20 12:41:34 +01:00
sithlord48
969b642e0b refactor: EiScreen sonar adjustments 2025-06-20 12:41:34 +01:00
sithlord48
a89f3b6892 refactor: conform EiScreen to code standards 
fixes #8700
 2025-06-20 12:41:34 +01:00
sithlord48
a973d4277c refactor: conform PortalInputCapture to coding standards 2025-06-20 12:41:34 +01:00
sithlord48
b8124107aa refactor: conform EiKeyState to coding standards 2025-06-20 12:41:34 +01:00
sithlord48
0691d586e7 refactor: conform EiEventQueueBuffer to coding standards 2025-06-20 12:41:34 +01:00
sithlord48
e8c85611a0 refactor: conform PortalRemoteDesktop to naming standards 
remove unused method and includes
 2025-06-20 12:41:34 +01:00
sithlord48
0321b2d36e chore: ArchNetworkBSD:Deps use make_shared now that we dont build on ubuntu 22 anymore 2025-06-20 09:39:26 +01:00
sithlord48
f4a49749c7 chore: remove todo in places where its done or just a note 2025-06-20 09:39:26 +01:00
sithlord48
59ed15628e refactor: remove redundant access specifiers 2025-06-20 09:39:26 +01:00
sithlord48
dddb6aadf1 refactor: Settings remove const for return by vaule 2025-06-20 09:39:26 +01:00
sithlord48
2110411c6d refactor: remove redundant cast 2025-06-20 09:39:26 +01:00
sithlord48
b29c5b1bb2 refactor: use contains to find if an item is in a container 2025-06-20 09:39:26 +01:00
sithlord48
07a217f54f refactor: concatenate Namespaces 2025-06-20 09:39:26 +01:00
sithlord48
aacf922319 refactor: remove names for unused handle function args 2025-06-20 09:39:26 +01:00
sithlord48
a80e255bb0 refactor: Add a few missing overrides 
make ~XThreadExit() override
 make ~ArchString() overide
 make ~ArchNetworkBDS() overide
 2025-06-20 09:39:26 +01:00
sithlord48
6299f04b59 refactor: make TlsUtility::generatateCertificate and TlsUtility::persistCertificate const 2025-06-20 09:39:26 +01:00
sithlord48
97006889bd refactor: ServerConnection::handleLogLine use referance to avoid unneeded copy 2025-06-20 09:39:26 +01:00
sithlord48
f0bb4e5cb3 refactor: make ServerApp::HandleScreenSwitch, Also does not use the Event * so removing it from the methods arguments 2025-06-20 09:39:26 +01:00
sithlord48
dcb047b6c5 refactor: make ClientApp::handleClientConnected const 2025-06-20 09:39:26 +01:00
sithlord48
551368a2d2 refactor: AboutDialog, Remove lambda for btnClose and connect directly to AboutDialog::close 2025-06-19 12:19:08 -07:00
sithlord48
4d738b4784 refactor: App use Uniqueprt for SocketMultiplexer 
basedon: 8dd6bc2c55
 2025-06-19 19:13:24 +01:00
sithlord48
06a616ef42 refactor: secureSocket uniqueprt for Ssl object 
based on: 89d8ce20b0
 2025-06-19 19:13:24 +01:00
sithlord48
90a651b409 refactor: server use std::unique_ptr for socketFactory 
based on ff7f23e79d
 2025-06-19 19:13:24 +01:00
sithlord48
dbc7aebfbc refactor: free SecureSocket cert after use 2025-06-19 18:56:14 +01:00
Nick Bolton
024436d82f refactor: Improve display of names on about screen with nbsp 2025-06-19 05:39:52 -07:00
sithlord48
b6bc469744 chore: adjust the about dialog default size 2025-06-19 09:54:37 +01:00
sithlord48
c4e47c0f2c chore: add main barrier/input-leap dev to our important devs list 2025-06-19 09:54:37 +01:00
sithlord48
66e201c8ef chore: remove handle* methods that are a single oneline forward and use the line directly 2025-06-18 13:17:16 +01:00
sithlord48
3a35b183d3 refactor: use std::function for Event callback 
based on 6d347337c3
 2025-06-18 13:17:16 +01:00
sithlord48
c15214aee7 refactor: use std::scoped_lock inplace of std::lock_guard 2025-06-17 10:23:42 +01:00
sithlord48
5fd4d93f7f refactor: replace ARCH->sleep(...) calls with Arch::sleep(...) 2025-06-17 10:23:42 +01:00
sithlord48
84e289bc30 refactor: replace ARCH->time() with Arch::time() 2025-06-17 10:23:42 +01:00
sithlord48
04943fad79 feat: Enforce a minimum TLS size of 2048bit 2025-06-16 05:02:33 -07:00
Nick Bolton
a7c1dc4520 chore: Remove 1024 TLS key length option 2025-06-16 05:02:33 -07:00
sithlord48
a73e8df01e feat: improve connections status bar info 2025-06-16 10:35:20 +01:00
sithlord48
782702fe74 refactor: use std::mutex in platform/XWindowsEventQueue 2025-06-14 09:37:48 +01:00
sithlord48
5686d24626 refactor: use std::mutex in net/TCPListenSocket 2025-06-14 09:37:48 +01:00
sithlord48
818d588b65 refactor: use std::mutex in deskflow/PacketStreamFilter 2025-06-14 09:37:48 +01:00
sithlord48
86e109baf5 refactor: use std::mutex in ArchNetworkWinSock 2025-06-14 09:37:48 +01:00
sithlord48
fa1ee0690e refactor: use std::mutex in ArchNetworkBSD 2025-06-14 09:37:48 +01:00
sithlord48
d535593d1d refactor: use std::mutex in ArchMutithreadWindows 2025-06-14 09:37:48 +01:00
Povilas Kanapickas
f89168d00a refactor: use std::mutex in ArchStrings 
port b0e415de03
build: link base to arch
 2025-06-14 09:37:48 +01:00
Povilas Kanapickas
fb3c8eb965 refactor: use std::mutex in Log 
port d9d39040ae
 2025-06-14 09:37:48 +01:00
Povilas Kanapickas
e247f3813a refactor: use std::mutex in EventQueue 
port 9df4741748
 2025-06-14 09:37:48 +01:00
Povilas Kanapickas
f4618ee085 refactor: use std::mutex in place of ArchMutex in AtchMultiThreadPosix 
port f71c68506e
 2025-06-14 09:37:48 +01:00
sithlord48
5430625a7e refactor: handle read and write on tcpsocket at the same time 
port 94f8336af5
 2025-06-14 08:44:21 +01:00
sithlord48
eac59768ea build: remove HAVE_SYS_SOCKET define should be present on all unix systems 2025-06-14 08:22:55 +01:00
sithlord48
cb05ece6b6 build: remove HAVE_PTHREAD define as its required on unix 2025-06-14 08:22:55 +01:00
sithlord48
044c9b24f3 build: remove HAVE_SOCKLEN_T forced define 2025-06-14 08:22:55 +01:00
sithlord48
a3fe66f213 build: remove HAVE_PTHREAD_SIGNAL define it was forced on 2025-06-14 08:22:55 +01:00
sithlord48
60a148ce68 build: remove HAVE_DPMS_PROTOTYPES, Single use and assumed due to another var being set 2025-06-14 08:22:55 +01:00
sithlord48
da5a2088c8 build: remove unset X_DISPLAY_MISSING checks 2025-06-14 08:22:55 +01:00
sithlord48
89abcfb238 build: remove never set HAVE_SYS_TYPES 2025-06-14 08:22:55 +01:00
sithlord48
87704fedb1 build: unistd.h is manditory on unix platforms 2025-06-14 08:22:55 +01:00
sithlord48
3eef21c8df chore: remove pointless SYS_TIME if defs one is set true and the other never used just include the libs 
chore: remove TIME_WITH_SYS_TIME set to 1 and used once as include guard
 2025-06-14 08:22:55 +01:00
Povilas Kanapickas
6fbb60a3c2 chore: remove unused StopWatch Includes 2025-06-14 08:22:55 +01:00
sithlord48
a5522729aa refactor: Unify ArchTime classes into one method 
Idea from https://github.com/input-leap/input-leap/pull/1464'
 2025-06-14 08:22:55 +01:00
sithlord48
36b4bb09bc refactor: Unify ArchSleepClasses into one method 
idea from https://github.com/input-leap/input-leap/pull/1462
 2025-06-14 08:22:55 +01:00
sithlord48
8170dd4e99 chore use std::getenv Not c style getenv 
idea from: https://github.com/debauchee/barrier/pull/847/
 2025-06-12 22:27:16 +01:00
sithlord48
c2a658256e feat: remove defunct --no-xinitThreads option 
based on https://github.com/input-leap/input-leap/pull/1503
 2025-06-12 22:07:40 +01:00
sithlord48
bc350852e7 refactor: remove anon namespace before ServerConfig::addToFirstEmptyGrid 2025-06-11 09:19:07 +01:00
sithlord48
7e568121ee chore: remove unneeded QGuiApplication, QApplication and or QCoreApplication includes 2025-06-09 17:18:05 -07:00
sithlord48
e40cc11fd5 refactor: messages::showDaemonOffline enable translations 2025-06-09 16:33:27 +01:00
sithlord48
ebec6331cd refactor: messages::showUpdateCheckOption enable translation 2025-06-09 16:33:27 +01:00
sithlord48
197b9ed886 refactor: message::showWaylandLibaryError, use name in the title and enable translations 2025-06-09 16:33:27 +01:00
sithlord48
8f7fbc0a21 refactor: messages::showReadOnlySettings, use name in title, enable translations 2025-06-09 16:33:27 +01:00
sithlord48
0f5a04825a refactor: Message::showClearSettings, enable translations and simplify method 2025-06-09 16:33:27 +01:00
sithlord48
b8835a8a5a refactor: Messages::showClientConnectError 
slight reword for Already Connected error
 use QString::append to add to the message
 create a QMessageBox::warning style box for these errors
 enable translations
 2025-06-09 16:33:27 +01:00
sithlord48
8bb6056469 refactor: Messages::showNewClientPrompt enable translations 2025-06-09 16:33:27 +01:00
sithlord48
3adcb64f57 refactor: Messages::showFirstConnectedMessage 
add the app name into the title
      use QString::append to add to the string
      enable translations
 2025-06-09 16:33:27 +01:00
sithlord48
bc9b1d1178 refactor: Messages::showFirstServerStartMessage 
add app name to dialog title
    enable translations
 2025-06-09 16:33:27 +01:00
sithlord48
e038dd2b0b chore: message::fileLine use QStringLiteral, multi-arg 2025-06-09 16:33:27 +01:00
sithlord48
1286c18e1d refactor: messages::showCloseReminder 
use app name for title
   create message using append
   enable translations
 2025-06-09 16:33:27 +01:00
sithlord48
5d94dd0dbf refactor: messages::showErrorDialog, use app name in title 
construct QString without concat
return aftershowing fatal error dialog
Enable Translation for user facing strings
 2025-06-09 16:33:27 +01:00
sithlord48
b3e03f2856 chore: messages, remove unneeded includes 2025-06-09 16:33:27 +01:00
sithlord48
b62e82e792 refactor: MainWindow, convert btnSaveServerConfig to QPushButton set the icons size 22x22 only when not on macos, make sure the button is square on macos 2025-06-05 21:20:10 +01:00
sithlord48
7837bf416e refactor: Mainwindow, rename btnApplySettings to btnRestartCore to better reflect what it does 2025-06-05 21:00:42 +01:00
sithlord48
d4d6cbb7fb feat: add restart action fixes #8542 2025-06-05 21:00:42 +01:00
sithlord48
d5910d77ec fix: core not starting if gui started minimized, remove firstShown and use open instead 
fixes #8641
 2025-06-03 17:28:48 +01:00
sithlord48
d01a023a8b chore: ApputilsUnix, remove unneeded includes 2025-06-02 14:28:51 -07:00
sithlord48
d246d9527a Feat: Define QT_NO_KEYWORDS, allowing us to use Qt in more places 
must use Q_SIGNALS, Q_SLOTS and Q_EMIT in place of signals, slots and emit macros
 2025-06-02 14:28:51 -07:00
sithord48
a31cff0225 chore: Cleanup windows includes 2025-06-02 21:55:36 +01:00
sithlord48
da06e97521 build: remove unused platform/MSWindowsUtils 2025-06-02 21:55:36 +01:00
sithlord48
7e4d43f1cc fix: (ui), ServerConfigDialog enable spinboxes and controls that depend on another option being enabled example being the heatbeat spinbox if heatbeat is enabled 2025-06-02 20:31:18 +01:00
sithlord48
7abaca76af chore: update CLI11 to v2.5.0 2025-05-28 19:22:13 +01:00
Povilas Kanapickas
5ee3fc41bd chore: arch: Remove XArch exception class 
XArch no longer contains any extra functionality in addition to what
std::runtime_error nor it signifies a particular type of error.
based-on: 5b991692af
ported-by: sithlord48
 2025-05-28 14:00:18 +01:00
Povilas Kanapickas
cab1eb9cee chore: arch: Derive XThread from std::exception 
This is needed because by convention exceptions must derive from at
least std::exception.
ported from: 22aec16dc7
ported-by sithlord48
 2025-05-28 14:00:18 +01:00
Povilas Kanapickas
51db919d8f chore: arch, remove XARCH_SUBCLASS Macro 
ported from: 1f3cd0dab3
ported-by sithlord48
 2025-05-28 14:00:18 +01:00
Povilas Kanapickas
314899ac7d chore: arch, Remove support for lazy error code to string evaluations 
This functionality is not needed because in all code paths the error
code is immediately converted to string without actually using the lazy
evaluation functionality.

based-on: 53dff5b803
ported and expanded by sithlord48
 2025-05-28 14:00:18 +01:00
Povilas Kanapickas
d597d023b1 chore: use std::unique_ptr for eventQueueHandlers 
ports input-leap/5044b79a4f98ea5da0b8cbe950123f061d4c1c5f
ported-by sithlord48
 2025-05-28 09:54:04 +01:00
Povilas Kanapickas
807e60ded2 chore: use std::unique_prt for EventQueue's Buffer 
port input-leap/9dbfd551cda4367bdc8067b5c3ca9c4027494503
ported-by sithlord48
 2025-05-28 09:54:04 +01:00
Povilas Kanapickas
0b4a2e0e5b chore: use std::unique_ptr for IDataSocket 
port-of input-leap/836e08b0642ad158ecedc44e59a3bd3c61b56141
ported-by sithlord48
 2025-05-28 09:54:04 +01:00
sithlord48
9eabbb690c chore: MSWindows only items initilize members in header 2025-05-28 09:42:08 +01:00
sithlord48
3eb3969a01 chore: use final for overrides and remove virtual for non base classes 2025-05-28 09:42:08 +01:00
sithlord48
d2ac36f3ed chore: make more const methods 2025-05-28 09:42:08 +01:00
sithlord48
e6a374369b chore: use const for more local ref and pointer vars 2025-05-28 09:42:08 +01:00
sithlord48
9c56fa5dda chore: Combine unnessessary multi level if into less fewer checks 2025-05-28 09:42:08 +01:00
sithlord48
6875969255 chore: static_cast to replace reinterpret_cast where possible 2025-05-28 09:42:08 +01:00
sithlord48
aa1eaf601c chore: SecureUtils, do not use final for stringVar name 2025-05-28 09:42:08 +01:00
sithlord48
f77213af04 chore: ActionDialog, remove empty statement 2025-05-28 09:42:08 +01:00
sithlord48
a4f1a382d3 chore: use ranged for in ClientListener::cleanupClientSockets 2025-05-23 10:19:11 -07:00
sithlord48
647201cd37 refactor: server/Config to the variable initializer and condition part of the for loop when checking for a valid screen name 2025-05-23 10:19:11 -07:00
sithlord48
e24b1c4b68 chore: use a const Ref for ServerConnection client name check 2025-05-23 10:19:11 -07:00
sithlord48
475b895755 chore: initialize class vars using the order class define, initilizer list, constructor 2025-05-23 10:19:11 -07:00
sithlord48
593e53370a chore: rename a missed namespace from synergy::gui => deskflow::gui 2025-05-23 10:19:11 -07:00
sithlord48
be6a4f6b4d chore: ScreenSettingsDialog rename ui_ => ui 2025-05-23 10:19:11 -07:00
sithlord48
929131d10b refactor: Log Error stop the core process if unable to write to the required fingerprint database 2025-05-23 18:08:41 +01:00
sithlord48
767919b342 refactor: consolidate IArchString subclasses into ArchString 2025-05-23 17:58:36 +01:00
sithlord48
4224215991 chore: make IArchString::EWideCharEncoding a enum class 2025-05-23 17:58:36 +01:00
sithlord48
45090d6b85 chore: IArchString clean up remaing code smells 2025-05-23 17:58:36 +01:00
sithlord48
476f3ba243 refactor: remove Ifdef around iso_level5 2025-05-23 17:19:55 +01:00
sithlord48
a33574e1bd chore: use more ranged for loops 2025-05-22 20:46:41 +01:00
sithlord48
456afaa13e chore: use emplace_back where possible 2025-05-22 20:46:41 +01:00
sithlord48
17f12d8334 chore: ClientApp remove unused restartRetryTimer and nextRetryTimer, use RETRY_TIME directly in ClientApp instead 2025-05-22 20:46:41 +01:00
sithlord48
723671c2e5 chore: remove // from inside comment blocks 2025-05-22 20:46:41 +01:00
sithlord48
5a90b51e97 chore: use string_view in place of string where possible 2025-05-22 20:46:41 +01:00
sithlord48
fe12972e83 chore: use const pointer / ref where possible 2025-05-22 20:46:41 +01:00
sithlord48
9bdb4252e5 chore: remove goto in EventQueue, instead use a private processEvent method 2025-05-22 20:46:41 +01:00
sithlord48
c73729e72e chore: static number number of priorities 2025-05-22 20:46:41 +01:00
sithlord48
04805d9a7e chore: mark explicit methods 2025-05-22 20:46:41 +01:00
sithlord48
3cf0fb89ef chore: add comment to empty methods 2025-05-20 16:20:07 +01:00
sithlord48
52b0c1f061 chore: use auto or (const auto) where possible 2025-05-20 16:20:07 +01:00
sithlord48
c224cd4661 chore: declare const methods recommened by sonar 2025-05-20 16:20:07 +01:00
sithlord48
635962618f chore: define only one variable per line 2025-05-20 16:20:07 +01:00
sithlord48
0ff72441e6 chore: use c++17 style if,switch init-initilizer where possible 
chore: correct spelling of "colon" in NetworkAddresses variables
chore: correct some multi line defines near needed init-initilizers
 2025-05-20 16:20:07 +01:00
sithlord48
bdffda9a2f chore: replace typedef with using 2025-05-20 16:20:07 +01:00
sithlord48
cac63937ff chore: cleansmells in ArchDaemon 2025-05-20 16:20:07 +01:00
sithlord48
a5e5bbc2e4 fix: race case if first run message is up and a client connects 2025-05-20 12:12:54 +01:00
Nick Bolton
34f6186941 fix: Disable the save button when config not writable 2025-05-19 22:10:41 +01:00
sithlord48
486b5a491f chore: LogOutputers add comments to empty overrides 2025-05-19 21:48:27 +01:00
sithlord48
037fee0e59 refactor: remove archConsole use its only implemented method directly in logOutputters 2025-05-19 21:48:27 +01:00
sithlord48
a9e0c62c24 refactor: link mt to base 2025-05-19 21:35:08 +01:00
sithlord48
43a51434ce chore: remove unused MinimalApp Class 2025-05-19 21:35:08 +01:00
Nick Bolton
eaa4c71d6e fix: Show first server start message only in server mode 2025-05-15 17:40:17 +01:00
sithlord48
393a006773 fix settings modifiers initilization, move initization to header 
fixes: #8587
 2025-05-15 17:25:08 +01:00
sithlord48
332e6c4a4d refactor: do not write sha1 to localdb and no longer send sha1 as part of comparison 2025-05-15 15:46:16 +01:00
Sam Umbach
14cb921d4c Resolve deprecated-enum-float-conversion compiler warnings 
- Observed on macOS Monterey 12.7.6 with cmake version 4.0.1, Homebrew clang version 20.1.4, Target: x86_64-apple-darwin21.6.0
 2025-05-14 11:05:41 -04:00
sithlord48
de583145d0 chore: remove unused deskflow::string methods toHex, fromHex, uppercase, fromHexChar 2025-05-13 11:32:02 -04:00
sithlord48
0309d35aef feat: port fingerprint info into Qt 
mv FingerprintData -> Fingerprint
 2025-05-13 11:32:02 -04:00
sithlord48
c4704649ea refactor: make sure settings dialog pushes all options to the top 2025-05-13 15:48:33 +01:00
sithlord48
33edb6ce01 refactor: simplify wayland warnings remove waylandwarnigns dialog test 2025-05-12 13:48:21 +01:00
Tomaz Canabrava
af383decca chore: Type fixes / Const correctness 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
8526facbe9 refactor: Fixes, Use enum instead of cast to int 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
2b3ecd39c6 refactor: ScreenCorners, Use enum instead of cast to int 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
49589ae4aa refactor, Modifiers, Use enum instead of cast to int 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
8ce6a07d18 refactor: Simplify Mainwindow, autoAddScreen also Removes warning 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
a8eb772b68 chore: Mainwindow, Send const-ref 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
0916009601 chore: Add nodiscard to methods 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
f5cb636b31 chore: MainWindow, Remove unimplemented methods 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
7ced794317 refactor: Screen, Mark methods as no discard, remove uneeded method 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
7c279ec72d refactor: No else after return 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
83a8d1c4ac refactor: Screen, simplify init call 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
84a9367124 refactor: Screen, remove uneeded constructor 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
aaeef7905a refactor: Initialize value on constructor 2025-05-09 12:27:56 +01:00
Tomaz Canabrava
a0d0936433 refactor: Use smaller integers on enums 
We do not have > 255 values here.
 2025-05-09 12:27:56 +01:00
sithlord48
8f53b88bb6 chore: remove unused tests 
Remove Unused Mocks
Remove remaing uses of TEST_ENV and its guarded items
 2025-05-08 15:26:44 +01:00
sithlord48
9d867f6146 refactor: port deskflow/keyMapTest to QtTests 
remove TEST_ENV items from KeyMap
KeyMap and KeyMapTests are friends
 2025-05-08 15:26:44 +01:00
sithlord48
632be4b240 refactor: port gui/ScreenTest to QtTests 
remove TEST_ENV items from Screen
 2025-05-08 15:26:44 +01:00
sithlord48
38dc845c72 refactor: port serverConfigTests to QtTests 
remove TEST_ENV items from server/Config
 2025-05-08 15:26:44 +01:00
sithlord48
b56a282a9c refactor: port ServerTests to QtTests 
remove TEST_ENV items from Server
 2025-05-08 15:26:44 +01:00
sithlord48
5365e34f08 feat: remove drag and drop support, its broken on all platforms 2025-05-08 09:47:41 -04:00
sithlord48
55a7fa3266 Port simplified EventTypes from 8b23570379 2025-05-05 17:17:01 -04:00
sithlord48
118f867fd1 refactor: Remove unused IEventQueue::getRegisteredType() 
ported from a5b6017235
 2025-05-05 17:17:01 -04:00
sithlord48
99dae58fd3 chore: clean up macos code smell missed by sonarscan 2025-05-03 21:23:15 +01:00
sithlord48
e9ccd513f7 chore: clean up windows code smells missed by sonarscan 2025-05-03 21:13:09 +01:00
sithlord48
903401796e refactor: Remove use of DESKFLOW_RESET_ALL and all users to pass --reset switch to deskflow-gui instead 2025-05-03 21:09:41 +01:00
sithlord48
d643e4b189 chore: PrimaryClient, use default for deconstructors / constructors 2025-05-02 12:12:17 +01:00
sithlord48
c8734755c5 chore: InputFilter, use default for deconstructors / constructors 2025-05-02 12:12:17 +01:00
sithlord48
edea3b0df1 chore: server/Config use default for deconstructors 2025-05-02 12:12:17 +01:00
sithlord48
f4264d71a1 chore: ClientProxy1_6 use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
6ffd0eb471 chore: ClientProxy1_4 use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
7619928d56 chore: ClientProxy1_3 use override where possible 2025-05-02 12:12:17 +01:00
sithlord48
d70c7fe720 chore: ClientProxy1_2 use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
b26ca77ff1 chore: ClientProxy1_1 use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
68db2c3484 chore: BaseClientProxy use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
81c19c6ee8 chore: XClipboardUTF8Converter use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
1276a4a29c chore: XClipboardUCS2Converter use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
d97f4d87ad chore: XClipboardTextConverter use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
d5cbd002a9 chore: XClipboardHTMLConverter use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
31a6fd23e7 chore: XClipboardBMPConverter use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
f6c6d4e3a7 chore: XClipboardAnyBitmapConverter use default for constructor / deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
5801b92636 chore: XSocket use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
b427ac91c2 chore: TCPSocketFactory use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
e87c596fbe chore: SecureSocket, add missing nullptr replacement 2025-05-02 12:12:17 +01:00
sithlord48
35b4749627 chore: XThread use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
6b2a28600a chore: CondVar, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
600378b72d chore: StreamBuffer, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
8e24689f72 chore: IStream, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
07f9c4ba47 chore: AddClientDialog, add missing nullptr replacement 2025-05-02 12:12:17 +01:00
sithlord48
9d476e143e chore: KeySequence, add missing nullptr replacement 2025-05-02 12:12:17 +01:00
sithlord48
6bcdd4ebe7 chore: DataDownloader, use default for deconstructor, add missing nullptr replacement 2025-05-02 12:12:17 +01:00
sithlord48
9085468d1c chore: AppUtilUnix, use default for deconstructors 2025-05-02 12:12:17 +01:00
sithlord48
7bace4d36d chore: XScreen, use default for deconstructors 2025-05-02 12:12:17 +01:00
sithlord48
ca0d095283 chore: XDeskflow, use default for deconstructors 2025-05-02 12:12:17 +01:00
sithlord48
ace5b54912 chore: ServerArgs, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
c99767c8b7 chore: ServerApp, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
297b781578 chore: PlatformScreen, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
8c4dc001bf chore: PacketStreamFilter, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
9ca13a65d1 chore: keystate: using nullptr 2025-05-02 12:12:17 +01:00
sithlord48
73566c061d chore: Keymap, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
ed3118b81a chore: DragInformation, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
cc209b9b1f chore: Clipboard, use default for deconstructor 2025-05-02 12:12:17 +01:00
sithlord48
ee22c31f32 chore: ClientArgs, use default for deconstructor 2025-05-02 12:12:17 +01:00